docbrown/spec
Jeremy Friesen 8b37e3aca9
Tidying up the Articles::Feeds::VariantQuery (#17396)
This commit does three things:

1.  Breaks the inheritance of the VariantQuery.
2.  Revisits the in-line documentation to better reflect current state.
3.  Removes branching logic that we don't need.

My goal is to have a VariantQuery that is what we need, conforms to the
method interface of WeightedQueryStrategy but does not rely on it.

After we merge this, we can observe if things break on DEV and fallback
to WeightedQueryStrategy if this doesn't work.  Once the
`Articles::Feeds::VariantQuery` has fledged on it's own, we can remove
the feature flag and then finally remove the weighted query strategy.

But that's the future steps.

Related to forem/forem#17393
2022-04-22 15:26:37 -04:00
..
controllers/concerns 15 minute fix: Add default argument to JsonApiSortParam (#13369) 2021-04-14 10:32:07 +07:00
decorators Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
factories Context Notifications (#17243) 2022-04-18 10:30:30 +03:00
fixtures Allowing VariantQuery for Feed Generation (#17382) 2022-04-21 11:07:09 -04:00
forms Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Limit an organizations displayed and add an overflow count (#17339) 2022-04-20 13:10:17 +02:00
initializers A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
lib disable creator onboarding feature flag (#17404) 2022-04-22 15:44:07 +01:00
liquid_tags Conditionally disabling Listings (Waiting on Product but technically Good to Go) (#16437) 2022-04-11 20:23:56 -04:00
mailers "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
models Allowing VariantQuery for Feed Generation (#17382) 2022-04-21 11:07:09 -04:00
policies Encapsulating the "why we hide/show" something (#17166) 2022-04-11 13:40:16 -04:00
queries Fixes a name conflict in Rpush models (#15978) 2022-01-07 09:38:16 -06:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Allowing VariantQuery for Feed Generation (#17382) 2022-04-21 11:07:09 -04:00
routing Remove profile admin feature flag (#17194) 2022-04-11 09:27:35 -05:00
sanitizers Don't sanitize anchor elements with no href (#16667) 2022-02-22 11:27:38 -06:00
serializers Refactoring to add helper method (#16064) 2022-01-12 11:21:44 -05:00
services Tidying up the Articles::Feeds::VariantQuery (#17396) 2022-04-22 15:26:37 -04:00
support style the orgs, add cypress tests (#17370) 2022-04-20 15:37:20 +01:00
system remove redundant feat flag (#17405) 2022-04-22 16:14:16 +01:00
tasks Make home link an admin-customisable navigation link (#16268) 2022-02-01 09:27:09 +00:00
uploaders Remove Remaining logo_svg Code (#16291) 2022-02-22 12:05:16 -07:00
validators Don't raise error when empty community emoji setting submitted (#15723) 2021-12-17 09:29:55 -06:00
view_objects Avoid using robohash for factory generated article cover images (#17024) 2022-03-28 14:01:29 -05:00
views Adding logic to hide Create Post on empty dashboard (#17149) 2022-04-11 13:52:35 -04:00
workers Skip rescoring draft articles (#17379) 2022-04-21 10:56:59 -05:00
i18n_spec.rb Show missing translation keys when test fails (#16637) 2022-02-17 16:21:29 -06:00
rails_helper.rb Conditionally disabling Listings (Waiting on Product but technically Good to Go) (#16437) 2022-04-11 20:23:56 -04:00
spec_helper.rb Bump to Rails 7.0.2.2 MVP (#15908) 2022-03-30 15:00:33 -04:00