docbrown/spec/requests
Ridhwana c53cfc5951
RFC#50-P4: Feature Flagged Routes and Interaction Design (#12967)
* feat: add the nested sidebar with some elements

* feat: create a tabbed nav item menu

* feat: add the tabbed nav_item partial to the views that need tabbed nav items

* fix: change variable back

* feat: style the sidebar a bit more

* chore: add some more styles

* feat: add a spec for the nested navigational items

* refactor: a more dynamic tabbed admin helper

* feat: add some more nav items

* fix: controller for reports

* refactor: shorthand if statement

* chore: add the whitespace back

* refactor: rubocop fixes

* chore: use any

* chore: remove whitespace

* refactor: rename the variable

* refactor: use a DSL style admin helper

* chore: variable renaming and routes

* rubocop: fixes

* refactor: move files to more apt places

* chore: keep overview as it was previously

* Update app/views/admin/secrets/index.html.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* Update app/views/admin/shared/_tabbed_navbar.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* Update app/views/admin/badges/index.html.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* chore: disable blocklength

* refactor: move the logic to the model instead of in the view

* chore: remove get_ prefix

* chore: move the request mangling to a helper that finds the controller and scope

* Update app/helpers/admin_helper.rb

Co-authored-by: rhymes <rhymes@hey.com>

* Update app/helpers/admin_helper.rb

Co-authored-by: rhymes <rhymes@hey.com>

* refactor: Address feedback

* oops

* oops use tr

* feat: update specs

* feat: make the navbar a dropdown

* feat: add a cursor pointer to the dropdown

* feat: add the icons which results in changed data structure

* fix: badge achievements

* feat: rename to an html file, show and collapse links + show active links

* chore: rename tabbed view to an html file

* fix: scope should be apps not app

* feat: add icons for the admin menu

* feat: increase the margin left

* feat: move the overview into the feature flag block and add an icon

* chore:remove files

* chore: indent

* feat: update crayons -link to have no text-decoration

* feat: current link for a scope with one controller

* Update app/lib/menu.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* Update app/models/admin_menu.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* refactor: we added svg to the builder so remove it from creating the hash

* feat: undo change to crayons and add it to the admin stylesheet

* Update app/views/admin/shared/_nested_sidebar.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* refactor: change to use ul and li's + a button

* chore: add bracket to next line

* feat: add aria-page

* chore: remove brackets

* feat: added focus specifically for the sidebar

* Update app/views/admin/shared/_nested_sidebar.html.erb

Co-authored-by: Jamie Gaskins <jgaskins@hey.com>

* chore: remove additional title

* chore: indent

* feat: add a visibilee keyword to the payload and set it to true by default

* feat: move the feature flagged routes into the correct sections

* feat: check if an item is visible before rendering it

* feat: amend the tabbed_navbar to be more accessible and add in visibilty checks

* chore: update comment

* chore: amend the styles

* chore: change url to path

* chore: comment

* test: add more tests

* Update app/assets/stylesheets/admin.scss

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Update app/views/admin/shared/_nested_sidebar.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Update app/views/layouts/admin.html.erb

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* chore: merge

* feat: use focus for browsers that dont support focus-visible (I'm looking at you Safari) and move it within the crayons-link so we dont see it on mouse click

* WIP: first pass of stimulus controller code

* feat: interaction design

* chore: remove unnecessary condiition

* chore: only add transparent background when not the current link

* Update app/models/admin_menu.rb

Co-authored-by: Michael Kohl <me@citizen428.net>

* feat; comment explaining

* feat: add an id on the button to be clicked

* feat: disable currentNavItem

* chore: remove event params

* chore: update cursor

* feat: (safe fail)
only show the tabbed navbar when the roures contain values form the data structure

* chore: pass events through + tests

* trigger an onload event and test the disabling of the menu item

* refactor: tabbed menu items

* feat: account for the visibility  of the feature flags

* chore: rubocop fixes

* chore: indentation

* feat: some refactors and updates for rubocop

* Update app/javascript/admin/controllers/sidebar_controller.js

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* feat: set to true

Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2021-03-23 11:12:54 +02:00
..
admin RFC#50-P4: Feature Flagged Routes and Interaction Design (#12967) 2021-03-23 11:12:54 +02:00
api/v0 Articles update refactoring (#12913) 2021-03-10 13:08:36 +03:00
articles Articles update refactoring (#12913) 2021-03-10 13:08:36 +03:00
incoming_webhooks/mailchimp Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
notifications [deploy] Remove All Notification Count Helper Classes (#8221) 2020-06-02 09:48:02 -05:00
oauth Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
podcasts Get the correct episode by finding the given podcast's episodes (#13034) 2021-03-18 12:02:37 -04:00
shared_examples nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
stories Remove concept of "ongoing" field tests and clarify a/b test instructions/expectations. (#11734) 2020-12-07 13:52:54 -05:00
user [15 minute fix] Remove disambiguatingDescription from user profile (#12861) 2021-03-03 08:42:46 +07:00
api_secrets_create_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
api_secrets_destroy_spec.rb Fix access token revoking (#3131) 2019-06-11 15:53:58 -04:00
article_approvals_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
async_info_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
badges_spec.rb Add badges index page. (#4236) 2019-10-06 17:34:52 -04:00
buffer_updates_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
chat_channel_memberships_spec.rb Optimization:Dont Notify of Channel Leavings (#10518) 2020-10-02 16:19:54 +02:00
chat_channels_spec.rb Parenthesis consistency for add_role and remove_role (#12661) 2021-02-15 20:35:25 +02:00
collections_spec.rb [deploy] Add index and show pages for series (#9201) 2020-07-29 10:01:52 -04:00
comments_create_spec.rb Add rate limit for new user comments (#12925) 2021-03-16 08:39:31 +07:00
comments_destroy_spec.rb Rubocop: Enable and fix Style/StringConcatenation (#9844) 2020-08-18 14:50:15 +02:00
comments_spec.rb Bump rubocop from 1.9.1 to 1.10.0 (#12700) 2021-02-16 09:14:17 -05:00
comments_update_spec.rb [deploy] Remove redirect on comments#update (#10337) 2020-09-29 15:33:51 -04:00
credits_spec.rb [deploy] Rename classified listings (#7910) 2020-05-27 13:35:09 +00:00
dashboard_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
devices_spec.rb Change PushNotifications::Send to use user_ids (#13036) 2021-03-19 13:50:04 -06:00
display_ad_events_spec.rb [15-minute fix] Add ThrottledCall to DisplayAdEventsController (#12924) 2021-03-09 09:06:11 +07:00
editor_spec.rb [Email/Password Authentication] Allow Admins to enable email/password login (#10745) 2020-10-12 12:54:35 -04:00
email_subscriptions_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
events_spec.rb Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556) 2020-07-29 11:31:01 +02:00
feedback_messages_spec.rb Email confirmation to abuse reports (#12557) 2021-02-03 22:59:50 +03:00
followings_spec.rb [deploy] Reintroduce sticky_nav changes (ab81f36 & 7f92855) (#10263) 2020-09-09 15:33:13 -04:00
follows_bulk_show_spec.rb [deploy] Bulk Fetch Follow Button Data for Users (#7676) 2020-05-08 13:58:58 -05:00
follows_bulk_update_spec.rb Update all followed tag with one click (#11454) 2021-01-05 16:15:37 +01:00
follows_create_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
follows_show_spec.rb Rubocop: enable and fix Style/Send and Style/Next (#9366) 2020-07-20 16:28:00 +02:00
ga_events_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
github_repos_spec.rb [EOY2020 Issue] Default new forems to Email Authentication only (#11696) 2020-12-02 16:49:07 -05:00
html_variant_successes_spec.rb Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
html_variant_trials_spec.rb Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
image_uploads_spec.rb Refactor:Change Image Article Upload Path to uploads/articles (#12668) 2021-02-15 11:52:00 -06:00
invitations_spec.rb Small Rubocop fixes (#11182) 2020-10-30 14:45:55 +01:00
liquid_embeds_spec.rb [deploy] Decouple Twitter authentication from fetching tweets (#7920) 2020-05-19 18:05:41 -04:00
liquid_tags_request_spec.rb [deploy] Add LiquidTagsController (#10241) 2020-09-08 12:07:33 -04:00
listings_spec.rb Fixing missing category in listing modal (#11301) 2020-11-06 12:29:20 -05:00
messages_spec.rb [deploy] Optimization/Bug Fix:Only Send Mentioned User Notifications, not all for every message (#9493) 2020-07-27 11:16:41 -05:00
moderations_spec.rb Parenthesis consistency for add_role and remove_role (#12661) 2021-02-15 20:35:25 +02:00
notification_counts_spec.rb [deploy] Optimization:Use Scope and current_user to Get Notification Count (#8177) 2020-06-01 09:27:46 -05:00
notification_subscriptions_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
notifications_spec.rb Parenthesis consistency for add_role and remove_role (#12661) 2021-02-15 20:35:25 +02:00
onboardings_spec.rb Simplify onboarding images and centralize config around primary/secondary logos (#12118) 2021-02-08 13:26:28 -05:00
open_search_spec.rb [deploy] Remove need for ENV vars during asset precompile (#10349) 2020-09-16 13:57:05 -04:00
organizations_update_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
page_views_spec.rb Extract page view updates into workers (#12686) 2021-02-17 09:24:05 +07:00
pages_spec.rb Revert "Revert "Removed service worker (#12974)" (#13014)" (#13015) 2021-03-17 10:57:56 -04:00
partnerships_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
poll_skips_spec.rb Small ActiveRecord optimizations: begone race conditions and hello bulk insert (#8436) 2020-06-15 17:57:14 +02:00
poll_votes_spec.rb Fix rubocop detected offenses (#4552) 2019-10-24 11:53:03 -04:00
profile_field_groups_request_spec.rb Deployment Task: Update onboarding fields prior to #11629 (#11704) 2020-12-07 14:57:18 -05:00
profile_pins_spec.rb [deploy] Finalize deleting user associations (#5624) 2020-01-23 11:29:47 -05:00
profiles_request_spec.rb Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
pusher_auth_spec.rb Remove commented code and tests (#3989) [ci skip] 2019-09-09 14:51:02 -04:00
rating_votes_spec.rb Add experience level averaging to articles (#1922) 2019-02-28 08:17:29 -08:00
reactions_spec.rb Test variants for which posts are fetched on initial "hot articles" home feed query. (#11982) 2021-01-05 12:29:46 -05:00
reading_list_items_spec.rb [deploy] Fix Reading List Counter Without last_reacted_at Default (#10933) 2020-10-19 13:26:19 -05:00
registrations_spec.rb Remove config single resource admin from config logic (#11971) 2020-12-18 13:09:31 -05:00
response_templates_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
search_spec.rb [Search 2.0] Add Search::Postgres::Username behind a feature flag (#12975) 2021-03-17 13:45:58 -04:00
sidebars_spec.rb Fetch homepage right sidebar async (and don't fetch for narrow screens) 2020-12-13 18:41:47 -05:00
sitemaps_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
social_previews_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
stories_index_spec.rb Remove asset reconciliation (#12729) 2021-02-18 16:50:03 -05:00
stories_show_spec.rb Replace collective_noun with community_name (#11846) [deploy] 2020-12-28 09:34:17 -07:00
stripe_active_cards_spec.rb Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
tag_adjustments_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
tags_spec.rb [deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) (#8435) 2020-07-07 07:37:04 -05:00
user_blocks_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
user_subscriptions_spec.rb Improve error message of User Subscriptions (#11689) 2020-12-01 08:41:49 -08:00
users_onboarding_spec.rb Add username to onboarding (#12697) 2021-02-24 10:48:31 -06:00
video_states_update_spec.rb [deploy] Refactor/Feature:Use SiteConfig video_encoder_key For Processing Videos (#10848) 2020-10-15 10:16:50 -05:00
videos_spec.rb Rubocop: re-activate Style/RegexpLiteral and fix violations (#9418) 2020-07-22 16:28:27 +02:00