* Hide blocked users' content appropriately * Use RESTful create route * Update functionality to block the user * Fix specs for new route * Use const instead of var * Add noopener and noreferrer * Remove caching for blocked user ids * Add new rule for lack of noopener noreferrer * Update snapshot
105 lines
4.3 KiB
Ruby
105 lines
4.3 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "UserBlock", type: :request do
|
|
let(:blocker) { create(:user) }
|
|
let(:blocked) { create(:user) }
|
|
|
|
before { sign_in blocker }
|
|
|
|
describe "GET /user_blocks/:blocked_id or #show" do
|
|
it "rejects when not-logged-in" do
|
|
sign_out(blocker)
|
|
get "/user_blocks/#{blocked.id}"
|
|
json_response = JSON.parse(response.body)
|
|
expect(response.content_type).to eq "application/json"
|
|
expect(response.status).to eq 401
|
|
expect(json_response["result"]).to eq "not-logged-in"
|
|
end
|
|
|
|
it "returns 'not-blocking' when the user is not blocked" do
|
|
get "/user_blocks/#{blocked.id}"
|
|
json_response = JSON.parse(response.body)
|
|
expect(response.content_type).to eq "application/json"
|
|
expect(json_response["result"]).to eq "not-blocking"
|
|
end
|
|
|
|
it "returns 'blocking' when blocking" do
|
|
create(:user_block, blocker: blocker, blocked: blocked)
|
|
get "/user_blocks/#{blocked.id}"
|
|
json_response = JSON.parse(response.body)
|
|
expect(response.content_type).to eq "application/json"
|
|
expect(json_response["result"]).to eq "blocking"
|
|
end
|
|
end
|
|
|
|
describe "POST /user_blocks or #create" do
|
|
it "renders 'not-logged-in' when not logged in" do
|
|
sign_out blocker
|
|
post "/user_blocks", params: { user_block: { blocked_id: blocked.id } }
|
|
json_response = JSON.parse(response.body)
|
|
expect(response.content_type).to eq "application/json"
|
|
expect(response.status).to eq 401
|
|
expect(json_response["result"]).to eq "not-logged-in"
|
|
end
|
|
|
|
it "creates the correct user_block" do
|
|
post "/user_blocks", params: { user_block: { blocked_id: blocked.id } }
|
|
expect(UserBlock.count).to eq 1
|
|
expect(UserBlock.first.blocker_id).to eq blocker.id
|
|
expect(UserBlock.first.blocked_id).to eq blocked.id
|
|
end
|
|
|
|
it "returns a JSON response with blocked" do
|
|
post "/user_blocks", params: { user_block: { blocked_id: blocked.id } }
|
|
json_response = JSON.parse(response.body)
|
|
expect(response.content_type).to eq "application/json"
|
|
expect(json_response["result"]).to eq "blocked"
|
|
end
|
|
|
|
it "blocks the potential chat channel" do
|
|
chat_channel = create(:chat_channel, channel_type: "direct", slug: "#{blocker.username}/#{blocked.username}", status: "active")
|
|
create(:chat_channel_membership, chat_channel_id: chat_channel.id, user_id: blocker.id)
|
|
create(:chat_channel_membership, chat_channel_id: chat_channel.id, user_id: blocked.id)
|
|
post "/user_blocks", params: { user_block: { blocked_id: blocked.id } }
|
|
expect(chat_channel.reload.status).to eq "blocked"
|
|
end
|
|
end
|
|
|
|
describe "DELETE /user_blocks/:blocked_id or #delete" do
|
|
before do
|
|
create(:user_block, blocker: blocker, blocked: blocked)
|
|
blocker.update(blocking_others_count: 1)
|
|
end
|
|
|
|
it "renders 'not-logged-in' when not logged in" do
|
|
sign_out blocker
|
|
delete "/user_blocks/#{blocked.id}", params: { user_block: { blocked_id: blocked.id } }
|
|
json_response = JSON.parse(response.body)
|
|
expect(response.content_type).to eq "application/json"
|
|
expect(response.status).to eq 401
|
|
expect(json_response["result"]).to eq "not-logged-in"
|
|
end
|
|
|
|
it "renders 'not-blocking-anyone' if there is no one to unblock" do
|
|
UserBlock.delete_all
|
|
blocker.update(blocking_others_count: 0)
|
|
delete "/user_blocks/#{blocked.id}", params: { user_block: { blocked_id: blocked.id } }
|
|
json_response = JSON.parse(response.body)
|
|
expect(response.content_type).to eq "application/json"
|
|
expect(json_response["result"]).to eq "not-blocking-anyone"
|
|
end
|
|
|
|
it "removes the correct user_block" do
|
|
delete "/user_blocks/#{blocked.id}", params: { user_block: { blocked_id: blocked.id } }
|
|
expect(blocker.blocking?(blocked)).to eq false
|
|
end
|
|
|
|
it "unblocks the direct chat channel" do
|
|
chat_channel = create(:chat_channel, channel_type: "direct", slug: "#{blocker.username}/#{blocked.username}", status: "blocked")
|
|
create(:chat_channel_membership, chat_channel_id: chat_channel.id, user_id: blocker.id)
|
|
create(:chat_channel_membership, chat_channel_id: chat_channel.id, user_id: blocked.id)
|
|
delete "/user_blocks/#{blocked.id}", params: { user_block: { blocked_id: blocked.id } }
|
|
expect(chat_channel.reload.status).to eq "active"
|
|
end
|
|
end
|
|
end
|