maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/models
History
Jeremy Friesen e1f7a6548c
Adding docs and specs to AdminMenu.nested_menu_items (#16888) 
* Adding docs and specs to AdminMenu.nested_menu_items

This relates to PR forem/forem#16847 which addresses issue
forem/forem#16842.

The goal of this PR is to help me develop an understanding of the
AdminMenu so I can further extend it and better understand it.

There's also a bit of knowledge sharing that I'm looking for, and the
comments and tests are there to help "confirm" that knowledge.  There
might be more that I'd consider regarding a refactor, but I want to make
sure I'm on the right path before I go further.

tl;dr - this is the smallest commit I can make to begin to tease out an
understanding of the method I put under test.

* Update app/models/admin_menu.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Adding more documentation

* Update app/models/admin_menu.rb

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2022-03-18 08:30:41 -04:00
..
ahoy
articles Replacing custom call with existing cached method (#16083) 2022-01-13 07:48:32 -05:00
concerns Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606) 2021-05-03 11:09:45 -04:00
settings "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
shared_examples Spelling (#15702) 2021-12-07 06:59:10 -07:00
users Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
ab_experiment_spec.rb Let's be friends again, Rubocop (#16294) 2022-01-25 11:58:00 -05:00
admin_menu_spec.rb Adding docs and specs to AdminMenu.nested_menu_items (#16888) 2022-03-18 08:30:41 -04:00
api_secret_spec.rb
application_record_spec.rb Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
article_destroy_spec.rb
article_spec.rb Allowlist character classes for post titles (#16787) 2022-03-09 10:36:33 -05:00
audit_log_spec.rb Add missing presence validators to models (#10495) 2020-10-01 16:15:32 +02:00
badge_achievement_spec.rb Configure badge credits by admins (#13145) 2021-03-30 10:58:48 +03:00
badge_spec.rb Refactor cache purging (#12811) 2021-03-02 10:09:05 -05:00
banished_user_spec.rb
broadcast_spec.rb
collection_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
comment_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
consumer_app_spec.rb ForemMobile namespaced functions (#15212) 2021-11-23 15:25:29 -06:00
credit_spec.rb
data_update_script_spec.rb Save Data Update Script errors to database and show them on http://localhost:3000/admin/data_update_scripts (#12348) 2021-01-21 14:48:34 +01:00
device_spec.rb Add mutable flag to APNS notifcation payload (#14777) 2021-09-21 15:37:43 -05:00
discussion_lock_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
display_ad_event_spec.rb Extracting constants and tidying tests (#15946) 2022-01-05 09:19:39 -05:00
display_ad_spec.rb Remove organization dependency and improve display ad UX (#14913) 2021-10-05 08:29:08 -04:00
email_authorization_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
email_message_spec.rb Delete old retained emails after certain period (#14949) 2021-10-12 16:27:13 -04:00
feedback_message_spec.rb app/models i18n (#16124) 2022-02-03 13:41:42 -05:00
follow_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
forem_instance_spec.rb "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
github_issue_spec.rb Implement Unified Embeds for Github Repo, Issue, Pull-Request and Comment URLs (#16422) 2022-02-07 16:38:43 -05:00
github_repo_spec.rb POC: use Sidekiq.perform_bulk for Github repos (#16293) 2022-01-26 09:11:07 +07:00
hair_trigger_spec.rb Ensure ActiveRecord::Base has descendants before checking triggers (#14732) 2021-09-15 09:29:44 -05:00
html_variant_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
html_variant_success_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
html_variant_trial_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
identity_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
listing_category_spec.rb
listing_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
mention_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
navigation_link_spec.rb Create/update by NavigationLink identity (#16312) 2022-01-27 13:51:41 -05:00
note_spec.rb [deploy] Add missing dependent clauses to User and cleanup relations (#10011) 2020-08-28 20:19:24 +02:00
notification_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
notification_subscription_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
organization_membership_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
organization_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
page_spec.rb Let override of ToS and CoC show in onboarding (#16217) 2022-01-20 19:45:39 -05:00
page_view_spec.rb
pinned_article_spec.rb Pin posts to feed (#13807) 2021-06-04 10:54:53 +02:00
podcast_episode_appearance_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
podcast_episode_spec.rb [15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured (#13767) 2021-05-19 15:03:20 +02:00
podcast_ownership_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
podcast_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
poll_option_spec.rb Add missing presence validators to models (#10495) 2020-10-01 16:15:32 +02:00
poll_skip_spec.rb Refactoring poll/vote/skip logic (#15441) 2021-11-29 10:52:32 -05:00
poll_spec.rb Refactoring poll/vote/skip logic (#15441) 2021-11-29 10:52:32 -05:00
poll_vote_spec.rb Refactoring poll/vote/skip logic (#15441) 2021-11-29 10:52:32 -05:00
profile_field_group_spec.rb Replace calls to Flipper with FeatureFlag (#11386) 2020-11-12 14:15:33 +01:00
profile_field_spec.rb Require profile fields to belong to a group (#16390) 2022-02-15 09:27:18 -06:00
profile_pin_spec.rb
profile_spec.rb Remove check_box type from profile fields (#14832) 2021-09-30 13:27:39 -04:00
rating_vote_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
reaction_spec.rb Don't send notification for invalid reactions (#16721) 2022-02-28 12:36:44 -06:00
response_template_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
role_spec.rb ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
sponsorship_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
tag_adjustment_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
tag_spec.rb Adding indirection for Tag#name to ease future work (#16703) 2022-02-28 16:32:04 -05:00
timeframe_spec.rb Remove timeframer from app/labor (#11782) 2020-12-08 12:52:33 +07:00
tweet_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00
user_block_spec.rb Fix and refactor hide user content (#12307) 2021-01-18 11:08:23 -05:00
user_role_spec.rb [Search 2.0] Users (#13453) 2021-04-24 19:06:06 +02:00
user_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
user_subscription_spec.rb Appeasing Rubocop as it sneaks some changes in (#16085) 2022-01-13 07:48:01 -05:00