* db * Add an iframe to host mod actions menu This iframe is probably the fastest way to get a working mod actions menu without rewriting existing code. We may eventually re-write this, but based on Ben's recommendation we are going to go with an iframe because it gets us a working feature quickly and it seems to be serving us well in other parts of the application. * Add the mod actions menu button to articles When the user is "trusted" they will see a small badge on the lower right-hand side of the screen. Clicking the icon reveals the mod actions menu. * Add header to actions panel (#7395) * Update iframe border * Add 'Moderate Post' header and button * Use inline SVG over <img src='svg'> * Use Crayons variables for units * Use flexbox to center chevron * Add accidentally deleted positioning * Add chevron-right.svg * Use a partial for actions panel and revert /mod page * Load actions panel in iframe and not /mod * Style UpVote, DownVote and Vomit buttons (#7421) * Add a iframe to host mod actions menu * Up and Downvote Icons * Starting with vomit button * Completed UI; interactions pending * Incorporated Andy changes; making mod action-panel * space reactions away from header * UI tweaks and corrections 1 * Fixing styles to match crayons * choose pure white color css variable * Add thumbs-up emoji; address Lisa comments * Trying to fix reactions interactions * remove clearThumbReactions function Co-authored-by: jacobherrington <jacobherringtondeveloper@gmail.com> * Add bottom layout for actions panel (#7501) * WIP for Lisa * Finalize mod actions bottom section * Use showing instead of hidden for transition * Add new optimized SVGs * Fix weird height issues for actions panel * Move hover styles below the cascade, yo * Use margin-top for sticky footer over height: 100% * Move initialize actions panel button to Webpack (#7506) * Move actions panel JS code to webpack * Refactor and use destructuring Thanks @nickytonline! Co-Authored-By: Nick Taylor <nick@iamdeveloper.com> * Rename file Co-authored-by: Nick Taylor <nick@iamdeveloper.com> * Configure Experience Level options for Mod Action Panel (#7507) * Add a iframe to host mod actions menu * Click interactions (no toggle of dropdowns yet) Co-authored-by: jacobherrington <jacobherringtondeveloper@gmail.com> * Fix the iframe's path (#7509) * Toggle the 'Set Experience Level' menu on button-click (#7529) * Add a iframe to host mod actions menu * Add set-exp dropdown functionality * WIP: making exp level updates async * Completes async implementation * Fix controller for "actions_panel" and "/mod" Co-authored-by: jacobherrington <jacobherringtondeveloper@gmail.com> * Add close button interaction (#7552) * Rename actions panel pack file * Add close button toggle to actions panel * DB update * Move more code to Webpack and add conditional tag adjustments section (#7652) * Move JS code to Webpack * Clean up a few style issues * Add styling for tag adjustments * Add active/inactive functionality * Add conditional rendering for tag adjustments section * Add missing variable oops (#7673) * update with upstream * Add missing subtract svg (#7695) * Create 'Flag User' modal (#7626) * Add a iframe to host mod actions menu * Starting task * Phase 1 * Fix "Close Modal" icon * Implement open modal * Working on all "Close Modal" actions * Almost-complete implementation * Remove Abuse Report snackbar * Delete unneeded JS code * Remove "How does this work?" links * Link to Community Moderation page * Addressing code review corrections * Update api call to use "request" method * Make else path clearer in api call Co-authored-by: jacobherrington <jacobherringtondeveloper@gmail.com> * Mod Actions Panel: Prevent nonsensical reaction pairs (#7699) * Still implementing * Completed Implementation * Address code review feednack; refactor "create" method * Move scss variables to native-css (for ModPanel code only) * Correct missing native css * update to native-css again * More sccs -> native-css fixes * Adjust ModPanel Button position on mobile (#7744) * Adjusted ModPanel position on mobile * Better adjustment * Fix phantom schema.rb changes * Fix phantom schema.rb changes * Finalize tag adjustments (#7740) * Finalize tag adjustments and flow * Fix logic for rendering adjust tags options * Clean up alert response * Rename user to trusted user * Use new CSS variables * Add/remove tag on article's tag section after adjusting * Fix logic for admin tag input and some other niceties * Final bug fixes mod panel (#7772) * Use correct boolean statement * Clear the value of the textarea not div * Use the correct attribute * Use actions panel for /mod page (#7775) * Fix loading logic with tag adjust button conditional render * Link to tag moderation for adjust tags section * Use top over window.parent Thanks @nickytonline! Co-authored-by: Nick Taylor <nick@iamdeveloper.com> * Use Webpack alias to import Co-authored-by: Nick Taylor <nick@iamdeveloper.com> * Use place-items shorthand over align-items + justify-content Thanks @nickytonline! Co-authored-by: Nick Taylor <nick@iamdeveloper.com> * Fix typo for utilities * Add new line to end of file * Disable linter for use for top function * Use align-items and justify-content center * Update SVGs to spec * Remove unnecessary height and use spacing units for open button * Remove accidentally added comment * Error handling when selecting reactions; optimize "reactions.each" loop * Add comment about clearing innerHTML * Revert schema back to master * Use each since there should only be two reactions * Fix typo oops * Add missing height oops * Return if there are no reactions to be destroyed * Center path with GUI tool shrug * chose more appropriate name for JS pack; rewrote api calls using async-await * Rename variables and methods and check categories before clearing * Use addSnackbarItem instead of hardcoded version * Place articleModerationTools pack behind user_signed_in * Correct omission * Implement dynamic imports for ModPanel tools * Implemented async/await; added snackbar message for null response use-case * Fix the "/article/mod" page; make sure all reactions, vomit-user and exp-level working as expected * Update language to reflect new UI * Close the modal after the "Confirm Action" button is clicked * Change text for Spam/Abuse button * Fix schema to use with master * Update schema to master again * Use crayons button for actions panel button * UI tweak to play nicer with site themes * Make actions panel work for dev.to/mod * Add snackbar for reactions * Update how does this work links * Add "thumbsup" reactions to logging * Add thumbsup to categories * Add external link icon * Changes to reflect "Privileged" and not "Negative" reactions; spec changes pending * Updated instance variable * Starting to update the specs * Update "thumbsup" points from 10 to 5 * Still working on both requests * Embracing an easier implemantation (thanks Andy!) * Add tests for actions panel * Add some basic tests for actions panel * Change to flag to admins * Indicate that 'Reason for Tag adjust' is required Co-authored-by: Mac Siri <krairit.siri@gmail.com> * Rename negative_reactions to privileged * Update rating level to use correct values * Use a different display value than backend value * Don't show adjust tags for trusted users * Add specs for moderation_routes for admin and super_admin Co-authored-by: Arit Amana <msarit@gmail.com> Co-authored-by: jacobherrington <jacobherringtondeveloper@gmail.com> Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com> Co-authored-by: Nick Taylor <nick@iamdeveloper.com> Co-authored-by: Mac Siri <krairit.siri@gmail.com>
138 lines
4.4 KiB
Ruby
138 lines
4.4 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.shared_examples "an elevated privilege required request" do |path|
|
|
context "when not logged-in" do
|
|
it "does not grant access", proper_status: true do
|
|
get path
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
|
|
it "raises Pundit::NotAuthorizedError internally" do
|
|
expect { get path }.to raise_error(Pundit::NotAuthorizedError)
|
|
end
|
|
end
|
|
|
|
context "when user is not trusted" do
|
|
before { sign_in create(:user) }
|
|
|
|
it "does not grant acesss", proper_status: true do
|
|
get path
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
|
|
it "internally raise Pundit::NotAuthorized internally" do
|
|
expect { get path }.to raise_error(Pundit::NotAuthorizedError)
|
|
end
|
|
end
|
|
end
|
|
|
|
RSpec.describe "Moderations", type: :request do
|
|
let(:trusted_user) { create(:user, :trusted) }
|
|
let(:article) { create(:article) }
|
|
let(:comment) { create(:comment, commentable: article) }
|
|
let(:dev_account) { create(:user) }
|
|
|
|
it_behaves_like "an elevated privilege required request", "/username/random-article/mod"
|
|
it_behaves_like "an elevated privilege required request", "/username/comment/1/mod"
|
|
it_behaves_like "an elevated privilege required request", "/username/random-article/actions_panel"
|
|
|
|
context "when user is trusted" do
|
|
before do
|
|
sign_in trusted_user
|
|
allow(User).to receive(:dev_account).and_return(dev_account)
|
|
end
|
|
|
|
it "grants access to comment moderation" do
|
|
get comment.path + "/mod"
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
|
|
it "grant access to article moderation" do
|
|
get article.path + "/mod"
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
|
|
it "grants access to /mod index" do
|
|
create(:rating_vote, article: article, user: trusted_user)
|
|
get "/mod"
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
|
|
it "grants access to /mod index with articles" do
|
|
create(:article, published: true)
|
|
get "/mod"
|
|
expect(response.body).to include("We build the")
|
|
end
|
|
|
|
it "grants access to /mod/:tag index with articles" do
|
|
create(:article, published: true)
|
|
get "/mod/#{article.tags.first}"
|
|
expect(response.body).to include("#" + article.tags.first.name.titleize)
|
|
end
|
|
|
|
it "returns not found for inappropriate tags" do
|
|
expect { get "/mod/dsdsdsweweedsdseweww" }.to raise_exception(ActiveRecord::RecordNotFound)
|
|
end
|
|
|
|
it "renders not_found when an article can't be found" do
|
|
expect { get "/#{trusted_user.username}/dsdsdsweweedsdseweww/mod/" }.to raise_exception(ActiveRecord::RecordNotFound)
|
|
end
|
|
end
|
|
|
|
describe "actions_panel" do
|
|
context "when the user is a tag moderator" do
|
|
it "shows the option to remove the tag when the article has the tag" do
|
|
tag_mod = create(:user, :tag_moderator)
|
|
tag_mod.add_role :trusted
|
|
tag = tag_mod.roles.find_by(name: "tag_moderator").resource
|
|
article = create(:article, tags: tag)
|
|
sign_in tag_mod
|
|
|
|
get "#{article.path}/actions_panel"
|
|
expect(response.body).to include "circle centered-icon adjustment-icon subtract"
|
|
end
|
|
end
|
|
|
|
it "shows the option to add the tag when the article has the tag" do
|
|
tag_mod = create(:user, :tag_moderator)
|
|
tag_mod.add_role :trusted
|
|
article = create(:article, tags: "javascript, cool, beans")
|
|
sign_in tag_mod
|
|
|
|
get "#{article.path}/actions_panel"
|
|
expect(response.body).to include "circle centered-icon adjustment-icon plus"
|
|
end
|
|
end
|
|
|
|
context "when the user is trusted" do
|
|
before do
|
|
sign_in trusted_user
|
|
get "#{article.path}/actions_panel"
|
|
end
|
|
|
|
it "does not show the adjust tags options" do
|
|
expect(response.body).not_to include "other-things-btn adjust-tags"
|
|
end
|
|
|
|
it "shows the experience level option" do
|
|
expect(response.body).to include "other-things-btn set-experience"
|
|
end
|
|
end
|
|
|
|
context "when the user is an admin" do
|
|
before do
|
|
admin = create(:user, :admin)
|
|
sign_in admin
|
|
article = create(:article, tags: "javascript, cool, beans")
|
|
get "#{article.path}/actions_panel"
|
|
end
|
|
|
|
it "shows the admin add tag option if the article has room for a tag" do
|
|
expect(response.body).to include "admin-add-tag"
|
|
end
|
|
|
|
it "shows the option to remove tags" do
|
|
expect(response.body).to include "circle centered-icon adjustment-icon subtract"
|
|
end
|
|
end
|
|
end
|