b115b2d17e
I was working on another branch and as part of my commit, Rubocop
removed a validation (but not the spec that asserted the validation).
Below is the "non-updating" rubocop offense on the other branch.
```shell
❯ rubocop ./app/models/notification_subscription.rb
Inspecting 1 file
C
Offenses:
app/models/notification_subscription.rb:13:29: C: [Correctable]
Rails/RedundantPresenceValidationOnBelongsTo: Remove explicit presence
validation for notifiable_id.
validates :notifiable_id, presence: true
^^^^^^^^^^^^^^
1 file inspected, 1 offense detected, 1 offense auto-correctable
```
To remediate, I ran:
```shell
> rubocop --only "Rails/RedundantPresenceValidationOnBelongsTo" \
--auto-correct
```
This resolved the `app/models`. Then did some regex magic and removed
the assertions from `spec/models`.
For Forem folks, I wrote a [forem.team post][1] discuss if this is how
we want to proceed.
[1]:https://forem.team/jeremy/rubocop-auto-updating-mayhem-33a6
59 lines
2.3 KiB
Ruby
59 lines
2.3 KiB
Ruby
class Follow < ApplicationRecord
|
|
extend ActsAsFollower::FollowerLib
|
|
extend ActsAsFollower::FollowScopes
|
|
|
|
COUNTER_CULTURE_COLUMN_NAME_BY_TYPE = {
|
|
"User" => "following_users_count",
|
|
"Organization" => "following_orgs_count",
|
|
"ActsAsTaggableOn::Tag" => "following_tags_count"
|
|
}.freeze
|
|
|
|
COUNTER_CULTURE_COLUMNS_NAMES = {
|
|
["follows.followable_type = ?", "User"] => "following_users_count",
|
|
["follows.followable_type = ?", "Organization"] => "following_orgs_count",
|
|
["follows.followable_type = ?", "ActsAsTaggableOn::Tag"] => "following_tags_count"
|
|
}.freeze
|
|
|
|
# Follows belong to the "followable" interface, and also to followers
|
|
belongs_to :followable, polymorphic: true
|
|
belongs_to :follower, polymorphic: true
|
|
|
|
scope :followable_user, ->(id) { where(followable_id: id, followable_type: "User") }
|
|
scope :followable_tag, ->(id) { where(followable_id: id, followable_type: "ActsAsTaggableOn::Tag") }
|
|
|
|
scope :follower_user, ->(id) { where(follower_id: id, followable_type: "User") }
|
|
scope :follower_organization, ->(id) { where(follower_id: id, followable_type: "Organization") }
|
|
scope :follower_podcast, ->(id) { where(follower_id: id, followable_type: "Podcast") }
|
|
scope :follower_tag, ->(id) { where(follower_id: id, followable_type: "ActsAsTaggableOn::Tag") }
|
|
|
|
counter_culture :follower, column_name: proc { |follow| COUNTER_CULTURE_COLUMN_NAME_BY_TYPE[follow.followable_type] },
|
|
column_names: COUNTER_CULTURE_COLUMNS_NAMES
|
|
before_save :calculate_points
|
|
after_create :send_email_notification
|
|
after_save :touch_follower
|
|
|
|
validates :blocked, inclusion: { in: [true, false] }
|
|
validates :followable_type, presence: true
|
|
validates :follower_type, presence: true
|
|
validates :subscription_status, presence: true, inclusion: { in: %w[all_articles none] }
|
|
|
|
def self.need_new_follower_notification_for?(followable_type)
|
|
%w[User Organization].include?(followable_type)
|
|
end
|
|
|
|
private
|
|
|
|
def calculate_points
|
|
self.points = explicit_points + implicit_points
|
|
end
|
|
|
|
def touch_follower
|
|
follower.touch(:updated_at, :last_followed_at)
|
|
end
|
|
|
|
def send_email_notification
|
|
return unless followable.instance_of?(User) && followable.email?
|
|
|
|
Follows::SendEmailNotificationWorker.perform_async(id)
|
|
end
|
|
end
|