docbrown/spec/system/user
Julianna Tetreault d06ee645f8
Improve Error Messaging for Self-Deletion Confirmation Flow (#12266) [deploy]
* Adds guard clauses and better error messages to UsersController #confirm_destroy

* Adds tests around guard clauses in UsersController #confirm_destroy

* Adds a custom error for invalid tokens in UsersController#confirm_destroy

* Refactor user_destroy_token.rb initialize method to be more succinct

* Removes unnecessary code from user_self_destroy_spec.rb and fixes failing InvalidToken spec

* Reworks code in #confirm_destroy to be consistent with other #destroy methods

* Adjust token mismatch test to use mismatched tokens

* Refactors #confirm_destroy and adds a before_action to Users::Controller
 - Reworks the logic within #confirm_destroy and removes excess code
 - Adds set_or_sign_in_user before_action for #confirm_destroy
 - Removes custom InvalidToken error message

* Cleans up spec and adds an additional test around logged out user edge case

* Fixes failing tests due to changes in #confirm_delete flow

* Adjusts test logic in user_self_destroy_spec.rb

* Refactors code by removing custom before_action and rewriting conditionals
2021-01-15 11:51:06 -07:00
..
user_edits_customization_spec.rb Improve information architecture of Settings (#11347) 2020-11-24 12:26:06 -08:00
user_edits_extensions_spec.rb validate payment pointer (#11702) 2020-12-04 12:00:25 -05:00
user_edits_profile_spec.rb Render Profile Fields on user profiles (#11485) 2020-12-09 09:41:11 -06:00
user_self_destroy_spec.rb Improve Error Messaging for Self-Deletion Confirmation Flow (#12266) [deploy] 2021-01-15 11:51:06 -07:00
user_settings_response_templates_spec.rb Improve information architecture of Settings (#11347) 2020-11-24 12:26:06 -08:00
view_user_comments_spec.rb [Crayons] Update comments card in Profile (#11199) 2020-11-04 10:45:17 -08:00
view_user_index_spec.rb Profile UI update (#11357) 2020-11-12 08:47:04 +01:00