docbrown/spec/requests/stories_index_spec.rb
rhymes bc385ae6d5
Switch decorators to Rails builtin decorations - take 2 (#6125) [deploy]
* Revert "Revert "[deploy] Switch decorators from Draper to Rails builtin decorations (#6040)" (#6122) [deploy]"

This reverts commit d438349550.

* Enable serialization for decorators

* Refactor and test default home feed serialization

* Improve spec

* Applied @vaidehijoshi suggestions

* Applied @citizen428 suggestions

* Make CodeClimate happy

* Cleanup stories_index_spec.rb

* Refactor UserDecorator#cached_followed_tags to loop less
2020-02-19 15:30:53 -05:00

229 lines
7.7 KiB
Ruby

require "rails_helper"
RSpec.describe "StoriesIndex", type: :request do
let!(:article) { create(:article, featured: true) }
describe "GET stories index" do
it "renders page with article list" do
get "/"
expect(response.body).to include(article.title)
end
it "renders page with min read" do
get "/"
expect(response.body).to include("min read")
end
it "renders page with proper sidebar" do
get "/"
expect(response.body).to include("<h4>Key links</h4>")
end
it "renders left display_ads when published and approved" do
org = create(:organization)
ad = create(:display_ad, published: true, approved: true, organization: org)
get "/"
expect(response.body).to include(ad.processed_html)
end
it "renders right display_ads when published and approved" do
org = create(:organization)
ad = create(:display_ad, published: true, approved: true, placement_area: "sidebar_right", organization: org)
get "/"
expect(response.body).to include(ad.processed_html)
end
it "does not render left display_ads when not approved" do
org = create(:organization)
ad = create(:display_ad, published: true, approved: false, organization: org)
get "/"
expect(response.body).not_to include(ad.processed_html)
end
it "does not render right display_ads when not approved" do
org = create(:organization)
ad = create(:display_ad, published: true, approved: false, placement_area: "sidebar_right", organization: org)
get "/"
expect(response.body).not_to include(ad.processed_html)
end
it "has gold sponsors displayed" do
org = create(:organization)
sponsorship = create(:sponsorship, level: "gold", tagline: "Oh Yeah!!!", status: "live", organization: org)
get "/"
expect(response.body).to include(sponsorship.tagline)
end
it "does not display silver sponsors" do
org = create(:organization)
sponsorship = create(:sponsorship, level: "silver", tagline: "Oh Yeah!!!", status: "live", organization: org)
get "/"
expect(response.body).not_to include(sponsorship.tagline)
end
it "does not display non live gold sponsorships" do
org = create(:organization)
sponsorship = create(:sponsorship, level: "gold", tagline: "Oh Yeah!!!", status: "pending", organization: org)
get "/"
expect(response.body).not_to include(sponsorship.tagline)
end
it "shows listings" do
user = create(:user)
listing = create(:classified_listing, user_id: user.id)
get "/"
expect(response.body).to include(CGI.escapeHTML(listing.title))
end
context "with campaign hero" do
let!(:hero_html) do
create(:html_variant, group: "campaign", name: "hero", html: Faker::Book.title, published: true, approved: true)
end
it "displays hero html when it exists and is set in config" do
SiteConfig.campaign_hero_html_variant_name = "hero"
get "/"
expect(response.body).to include(CGI.escapeHTML(hero_html.html))
end
it "doesn't display when campaign_hero_html_variant_name is not set" do
SiteConfig.campaign_hero_html_variant_name = ""
get "/"
expect(response.body).not_to include(CGI.escapeHTML(hero_html.html))
end
it "doesn't display when hero html is not approved" do
SiteConfig.campaign_hero_html_variant_name = "hero"
hero_html.update_column(:approved, false)
get "/"
expect(response.body).not_to include(CGI.escapeHTML(hero_html.html))
end
end
context "with campaign_sidebar" do
before do
SiteConfig.campaign_featured_tags = "shecoded,theycoded"
a_body = "---\ntitle: Super-sheep#{rand(1000)}\npublished: true\ntags: heyheyhey,shecoded\n---\n\nHello"
create(:article, approved: true, body_markdown: a_body)
u_body = "---\ntitle: Unapproved-post#{rand(1000)}\npublished: true\ntags: heyheyhey,shecoded\n---\n\nHello"
create(:article, approved: false, body_markdown: u_body)
end
it "doesn't display posts with the campaign tags when sidebar is disabled" do
SiteConfig.campaign_sidebar_enabled = false
get "/"
expect(response.body).not_to include(CGI.escapeHTML("Super-sheep"))
end
it "displays posts with the campaign tags when sidebar is enabled" do
SiteConfig.campaign_sidebar_enabled = true
get "/"
expect(response.body).not_to include(CGI.escapeHTML("Unapproved-post"))
end
it "displays only approved posts with the campaign tags" do
SiteConfig.campaign_sidebar_enabled = false
get "/"
expect(response.body).not_to include(CGI.escapeHTML("Super-puper"))
end
end
describe "when authenticated" do
let(:user) { create(:user) }
before do
sign_in user
end
it "contains the stories correctly serialized" do
# we control titles to avoid escaping errors with apostrophes and such
article = create(:article, featured: true)
article.update_columns(title: "abc")
articles = create_list(:article, 2)
articles.each { |a| a.update_columns(title: "abc") }
get root_path
expect(response).to have_http_status(:ok)
stories = controller.instance_variable_get(:@stories) # cheating a bit ;)
expected_result = ArticleDecorator.decorate_collection(stories).
to_json(controller.class.const_get(:DEFAULT_HOME_FEED_ATTRIBUTES_FOR_SERIALIZATION))
expect(response.body).to include(ERB::Util.html_escape(expected_result))
end
end
end
describe "GET query page" do
it "renders page with proper header" do
get "/search?q=hello"
expect(response.body).to include("query-header-text")
end
end
describe "GET podcast index" do
it "renders page with proper header" do
podcast = create(:podcast)
create(:podcast_episode, podcast: podcast)
get "/" + podcast.slug
expect(response.body).to include(podcast.title)
end
end
describe "GET tag index" do
let(:tag) { create(:tag) }
let(:org) { create(:organization) }
def create_live_sponsor(org, tag)
create(
:sponsorship,
level: :tag,
blurb_html: "<p>Oh Yeah!!!</p>",
status: "live",
organization: org,
sponsorable: tag,
expires_at: 30.days.from_now,
)
end
it "renders page with proper header" do
get "/t/#{tag.name}"
expect(response.body).to include(tag.name)
end
it "renders page with top/week etc." do
get "/t/#{tag.name}/top/week"
expect(response.body).to include(tag.name)
get "/t/#{tag.name}/top/month"
expect(response.body).to include(tag.name)
get "/t/#{tag.name}/top/year"
expect(response.body).to include(tag.name)
get "/t/#{tag.name}/top/infinity"
expect(response.body).to include(tag.name)
end
it "renders tag after alias change" do
tag2 = create(:tag, alias_for: tag.name)
get "/t/#{tag2.name}"
expect(response.body).to redirect_to "/t/#{tag.name}"
end
it "does not render sponsor if not live" do
sponsorship = create(
:sponsorship, level: :tag, tagline: "Oh Yeah!!!", status: "pending", organization: org, sponsorable: tag
)
get "/t/#{tag.name}"
expect(response.body).not_to include("is sponsored by")
expect(response.body).not_to include(sponsorship.tagline)
end
it "renders live sponsor" do
sponsorship = create_live_sponsor(org, tag)
get "/t/#{tag.name}"
expect(response.body).to include("is sponsored by")
expect(response.body).to include(sponsorship.blurb_html)
end
end
end