maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/controllers
History
Jeremy Friesen b8533172e3
Introducing a quick and dirty fix for abtests/admin (#17982) 
This is a "quick and dirty" hack.  Do I like it?  No.  Do I want to delve
into further debugging/refactoring of [a 72 line method][1]?  Not at the
moment.  There are a few pathways forward, but for now, this is the
pathway to hopefully give us insight into the

**Why will this likely address the issue?**

Prior to this commit, for an experiment we would render each of the
goals (anywhere from 8 to 11); each of which would require 2 expensive
queries; which means about 16 expensive queries.

After this commit, the experiment page has none of those expensive
queries; instead each goal now runs the 2 expensive queries.

The hope is that this will help us show the results (albeit on multiple
pages) while coming in under the response time out handlers we have in
place.

**Why no tests?**

Ugh; I know right?!?  I'm beginning to ask that myself.  But for now,
because this is only visible to tech_admins, the consequences of
breaking are limited.  In otherwords, this is not a customer facing
feature, so it can be a bit less robust in it's testing.  At least
that's the rationalization I'm establishing.

Further, local tests would not reveal the production environment
complications of large data sets.  The aforementioned expensive queries
are blisteringly fast on my local machine...in part because I don't much
field_test experiment data.

Closes forem/forem#17981

Related to:

- forem/forem#17895
- forem/forem#17869

[1]:ab2d7d29d0/lib/field_test/experiment.rb (L98-L160)
2022-06-24 09:26:46 -04:00
..
admin Member Index View Actions: "Adjust Credit Balance" (#17974) 2022-06-23 14:30:10 -06:00
api API V1 transition (#17835) 2022-06-23 14:26:00 -06:00
concerns API V1 transition (#17835) 2022-06-23 14:26:00 -06:00
field_test Introducing a quick and dirty fix for abtests/admin (#17982) 2022-06-24 09:26:46 -04:00
incoming_webhooks Remove sustaining member newsletter, and its settings (#17514) 2022-04-29 11:47:12 -05:00
notifications Rubocop: fix additional violations in todo file (#9218) 2020-07-09 10:25:44 -04:00
stories Bump ddtrace from 0.54.2 to 1.0.0 (#17662) 2022-05-18 15:46:49 -04:00
users Refactor OnboardingsController (#17329) 2022-04-27 16:17:02 -04:00
api_secrets_controller.rb Add a contact email address to the /admin/customization/config (#16497) 2022-02-15 17:37:08 +02:00
application_controller.rb Remove name from invitation flow (#17438) 2022-05-03 09:33:12 +01:00
application_metal_controller.rb Add ApplicationMetalController to relevant controllers (#4937) 2019-11-26 16:29:07 -05:00
article_approvals_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
articles_controller.rb Replace links to the repo with newer URLs (#17319) 2022-04-18 22:11:31 -04:00
async_info_controller.rb Adding copy to assist with space toggle decision (#17147) 2022-04-06 11:07:21 -04:00
badges_controller.rb Add badges index page. (#4236) 2019-10-06 17:34:52 -04:00
collections_controller.rb Series count to only include non empty series (#16130) 2022-01-18 10:22:34 +07:00
comments_controller.rb Replace links to the repo with newer URLs (#17319) 2022-04-18 22:11:31 -04:00
confirmations_controller.rb Fix email confirmation logic when registering via Omniauth (#17878) 2022-06-23 16:26:26 -04:00
credits_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
dashboards_controller.rb Show Series counts on all Dashboard Tabs (#17513) 2022-04-29 11:58:06 -04:00
deep_links_controller.rb Add exclusion to AASA supported paths (#14593) 2021-08-26 10:17:39 -06:00
devices_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
discussion_locks_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
display_ad_events_controller.rb Extracting constants and tidying tests (#15946) 2022-01-05 09:19:39 -05:00
email_authorizations_controller.rb Standardize ActiveRecord order clauses (#9395) 2020-07-20 10:00:51 -04:00
email_subscriptions_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
feedback_messages_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
followings_controller.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
follows_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
ga_events_controller.rb Skip google analytics when ga_tracking_id is nil (#15967) 2022-01-06 12:21:07 -05:00
github_repos_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
html_variant_successes_controller.rb Move HtmlVariantSuccessesCreate from job to inline (#5879) [deploy] 2020-02-04 10:24:39 -08:00
html_variant_trials_controller.rb Move HtmlVariantTrial#create inline (#5901) [deploy] 2020-02-04 17:29:46 -08:00
image_uploads_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
invitations_controller.rb Remove name from invitation flow (#17438) 2022-05-03 09:33:12 +01:00
liquid_embeds_controller.rb Move work from template to controller (#16092) 2022-01-18 11:21:25 -05:00
liquid_tags_controller.rb Remove redundant freeze calls (#14596) 2021-08-26 10:01:08 -04:00
listings_controller.rb More listings refactoring (#16343) 2022-02-23 13:44:30 +07:00
moderations_controller.rb Allow Moderator Role to adjust post tags (#17858) 2022-06-14 10:55:19 -04:00
notification_subscriptions_controller.rb Rename unidiomatic methods (#13328) 2021-04-09 10:59:56 -05:00
notifications_controller.rb Removing unused instance variable (#16826) 2022-03-08 13:59:08 -05:00
omniauth_callbacks_controller.rb Fix email confirmation logic when registering via Omniauth (#17878) 2022-06-23 16:26:26 -04:00
open_search_controller.rb [deploy] Remove need for ENV vars during asset precompile (#10349) 2020-09-16 13:57:05 -04:00
organizations_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
page_views_controller.rb Ensuring we don't track views of author or unpublished (#16143) 2022-01-18 11:23:18 -05:00
pages_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
passwords_controller.rb Add a notification on password reset (#14968) 2021-10-07 14:48:01 -04:00
podcast_episodes_controller.rb Fix and clean up podcast pages (#15004) 2021-10-15 17:38:57 -04:00
podcasts_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
poll_skips_controller.rb Use constants for Permitted params in controller (#14895) 2021-10-05 09:00:14 -04:00
poll_votes_controller.rb Use constants for Permitted params in controller (#14895) 2021-10-05 09:00:14 -04:00
pro_accounts_controller.rb Add basic pro accounts lander test (#3433) 2019-07-09 22:10:50 -04:00
profile_field_groups_controller.rb Add ProfileFieldGroupsController to API (#10124) 2020-09-03 10:12:53 +07:00
profile_pins_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
profile_preview_cards_controller.rb Add JSON representation of Profile Preview Card info (#14296) 2021-07-21 16:23:54 +01:00
profiles_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
rating_votes_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
reactions_controller.rb Ensuring only privileged users may give certain reactions (#17632) 2022-05-10 16:13:23 -04:00
reading_list_items_controller.rb [deploy] Fix Reading List Counter Without last_reacted_at Default (#10933) 2020-10-19 13:26:19 -05:00
registrations_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
response_templates_controller.rb Trusted users can view & use moderator response templates (#17867) 2022-06-16 14:05:49 +02:00
search_controller.rb validate sort direction (#17439) 2022-04-27 08:59:13 -05:00
service_worker_controller.rb Revert "Revert "Removed service worker (#12974)" (#13014)" (#13015) 2021-03-17 10:57:56 -04:00
sidebars_controller.rb Refactoring to consolidate logic (#15851) 2021-12-29 11:08:04 -05:00
sitemaps_controller.rb Spelling (#15702) 2021-12-07 06:59:10 -07:00
social_previews_controller.rb Enable Rails framework 7.0's isolation_level, partial_inserts, & raise_on_open_redirects (#17970) 2022-06-23 10:30:58 -04:00
stories_controller.rb Removing unused instance variable (#17414) 2022-04-25 10:43:21 -04:00
stripe_active_cards_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
tag_adjustments_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
tags_controller.rb Add ability to bulk search tags by name or id (#16671) 2022-02-24 12:34:50 -05:00
user_blocks_controller.rb ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
user_subscriptions_controller.rb UserSubscription backend refactor (#9060) 2020-07-02 12:08:37 -04:00
users_controller.rb Refactor: Move onboarding routes out of UsersController (#17189) 2022-04-13 14:20:16 -04:00
video_states_controller.rb app/controllers & decorators i18n (#16126) 2022-02-03 13:35:56 -05:00
videos_controller.rb Removing before_action in favor of explicity call (#16777) 2022-03-04 11:08:53 -05:00