* Trying some models for audience segmentation * AudienceSegment basics * Attach AudienceSegment to DisplayAd * Possibly use a DUS to populate AudienceSegments * Add to display ad form UI * Add to display ad API * Refresh strategy for audience segments * Add user_id to async ads query * Maybe :testing -> :manual, for no-refresh segment * Test & tweak segment refresh * Testing audience_segment#refresh logic * Coverage: testing human_readable * Scope segment refresh to recently active users * Tweak logic for when to refresh * Tweak experience levels to match SettingsHelper * Test for front-end logic * Fix test, hope this helps coverage? * Better test names * One worker for all, many workers for each, perform_bulk * Fix audience segment UI, needs to use id, not enum * cron/schedule should RefreshAll * Singular id in RefreshWorker
59 lines
1.9 KiB
Ruby
59 lines
1.9 KiB
Ruby
module Api
|
|
module V1
|
|
class DisplayAdsController < ApiController
|
|
before_action :authenticate_with_api_key!
|
|
before_action :require_admin
|
|
|
|
def index
|
|
@display_ads = DisplayAd.order(id: :desc).page(params[:page]).per(50)
|
|
@display_ads = @display_ads.search_ads(params[:search]) if params[:search].present?
|
|
render json: @display_ads
|
|
end
|
|
|
|
def show
|
|
@display_ad = DisplayAd.find(params[:id])
|
|
render json: @display_ad
|
|
end
|
|
|
|
def create
|
|
@display_ad = DisplayAd.new(permitted_params)
|
|
result = @display_ad.save
|
|
render json: @display_ad, status: (result ? :ok : :unprocessable_entity)
|
|
rescue ArgumentError => e
|
|
# enums raise ArgumentError exceptions on unexpected inputs!
|
|
render json: { error: e }, status: :unprocessable_entity
|
|
end
|
|
|
|
def update
|
|
@display_ad = DisplayAd.find(params[:id])
|
|
result = @display_ad.update(permitted_params)
|
|
render json: @display_ad, status: (result ? :ok : :unprocessable_entity)
|
|
rescue ArgumentError => e
|
|
# enums raise ArgumentError exceptions on unexpected inputs!
|
|
render json: { error: e }, status: :unprocessable_entity
|
|
end
|
|
|
|
def unpublish
|
|
@display_ad = DisplayAd.find(params[:id])
|
|
result = @display_ad.update(published: false)
|
|
if result
|
|
head :no_content
|
|
else
|
|
render json: @display_ad, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def require_admin
|
|
authorize DisplayAd, :access?, policy_class: InternalPolicy
|
|
end
|
|
|
|
def permitted_params
|
|
params.permit :approved, :body_markdown, :creator_id, :display_to,
|
|
:name, :organization_id, :placement_area, :published,
|
|
:tag_list, :type_of, :exclude_article_ids, :audience_segment_type
|
|
end
|
|
end
|
|
end
|
|
end
|