b2e18aeb72
* WIP use redis-session-store for sessions * Use Redis as session storage * Add redis-server to Travis * Use integer for SESSION_EXPIRY_SECONDS env variable Co-Authored-By: rhymes <rhymesete@gmail.com> * Remove sessions b/c no custom sessions logic * Use ApplicationConfig instead * Rename default value * Remove rememberable module * Persist the user for the test * Remove remember_me related tests * Revert 'undo remember_me' commits * Add redis to procfile * Cleanup devise configuration * Move REDIS configuration in the basic configuration section * Make sure the expiration time can't zero * Restore old order and remove useless comment line * Delete legacy session cookie after login Once deployed the server will start using the new session cookie, this makes sure the legacy one is deleted on the user's browser * Remove redis from Procfile * Add signed, secure and httponly to the Redis session cookie
67 lines
2.5 KiB
Ruby
67 lines
2.5 KiB
Ruby
class OmniauthCallbacksController < Devise::OmniauthCallbacksController
|
|
LEGACY_COOKIE_NAME = "_PracticalDeveloper_session".freeze
|
|
|
|
# Don't need a policy for this since this is our sign up/in route
|
|
include Devise::Controllers::Rememberable
|
|
|
|
def twitter
|
|
callback_for("twitter")
|
|
end
|
|
|
|
def github
|
|
callback_for("github")
|
|
end
|
|
|
|
def failure
|
|
logger.error "Omniauth failure",
|
|
omniauth_failure: {
|
|
error: request.env["omniauth.error"]&.inspect,
|
|
error_type: request.env["omniauth.error.type"].to_s,
|
|
auth: request.env["omniauth.auth"],
|
|
provider: request.env["omniauth.strategy"].to_s,
|
|
cookie: request.env["rack.request.cookie_hash"]
|
|
}
|
|
super
|
|
end
|
|
|
|
private
|
|
|
|
def callback_for(provider)
|
|
cta_variant = request.env["omniauth.params"]["state"].to_s
|
|
@user = AuthorizationService.new(request.env["omniauth.auth"], current_user, cta_variant).get_user
|
|
|
|
if persisted_and_valid?
|
|
# delete legacy session based cookie once the user has logged in again
|
|
request.cookie_jar.delete(LEGACY_COOKIE_NAME) if request.cookies[LEGACY_COOKIE_NAME]
|
|
|
|
remember_me(@user)
|
|
sign_in_and_redirect @user, event: :authentication
|
|
set_flash_message(:notice, :success, kind: provider.to_s.capitalize) if is_navigational_format?
|
|
elsif persisted_but_username_taken?
|
|
redirect_to "/settings?state=previous-registration"
|
|
else
|
|
session["devise.#{provider}_data"] = request.env["omniauth.auth"]
|
|
user_errors = @user.errors.full_messages
|
|
logger.error "Log in error: sign in failed. username: #{@user.username} - email: #{@user.email}"
|
|
logger.error "Log in error: auth data hash - #{request.env['omniauth.auth']}"
|
|
logger.error "Log in error: auth data hash - #{request.env['omniauth.error']&.inspect}"
|
|
logger.error "Log in error: user_errors: #{user_errors}"
|
|
flash[:alert] = user_errors
|
|
redirect_to new_user_registration_url
|
|
end
|
|
rescue StandardError => e
|
|
logger.error "Log in error: #{e}"
|
|
logger.error "Log in error: auth data hash - #{request.env['omniauth.auth']}"
|
|
logger.error "Log in error: auth data hash - #{request.env['omniauth.error']&.inspect}"
|
|
flash[:alert] = "Log in error: #{e}"
|
|
redirect_to new_user_registration_url
|
|
end
|
|
|
|
def persisted_and_valid?
|
|
@user.persisted? && @user.valid?
|
|
end
|
|
|
|
def persisted_but_username_taken?
|
|
@user.persisted? && @user.errors.full_messages.join(", ").include?("username has already been taken")
|
|
end
|
|
end
|