b12ebfa0e5
* Adds landing_page checkbox for Landing Page * Adds landing_page to page_params in Admin::Pages::Controller * Adds landing_page to admin_manages_pages and admin_creates_pages specs * Adjusts copy for Landing Page in pages/_form.html.erb * Places #post_a_job before #privacy in Pages::Controller - Ensures that all page-related methods are properly alphabetized * Alphabetizes remaining out-of-order page-related methods - Ensures that all page-related methods within the Pages::Controller are in alphabetical order, following the order of the other methods * Adds landing_page check to ApplicationController#verify_private_forem * Adds a single_landing_page validation to the Page model * Adds a lock.svg to /images and uses it in the pages index * Adjusts buttons and checkboxes to use crayons class in pages partial * Ensures that pages/_form.html.erb destroy button uses crayons * Adds a landing_page validation-related test to page_spec.rb * Updates #single_landing_page validation and error message * WIP: Adds JS modal upon landing_page error in pages/_form.html.erb * Adds a working modal upon error in pages/_form.html.erb - Removes redundant #single_landing_page validation from Page - Adds #has_a_landing_page? in place of #single_landing_page - Conditionally renders the landing_page checkbox in _form.html.erb - Adds styles to locked screen/landing page modal - Adds copy to locked screen/landing page modal - Beings adding buttons to overwrite current landing_page * Updates the data-modal-selectors and ids in pages/_form.html.erb * Uses #landing_page_path within pages/_form.html.erb modal - Adds a link_to to link to the current landing page in the modal - Adds styles to buttons and link_to in modal * Adds back single_landing_page validation to Page.rb * Reverts changes and updates methods within Page.rb - Reverts changes to #single_landing_page - Refactors #has_a_landing_page? and #landing_page_path - Updates div id in pages/_form.html.erb * Adjusts #single_landing_page error message slightly * Adds a test for landing_pages in stories_index_spec.rb * Adds an overwrite attribute to Pages for the modal in _form - Fixes anonymous spelling * Refactors pages/_form.html.erb and cleans up spelling * Adds a safe operator to landing_page.path in Page - Adjusts the placement of the hidden value in pages/_form.html.erb * Updates styling for Current Locked Screen link * Adds the ability to overwrite an active landing page on click - Adds Admin::PagesController#update_and_overwrite and refactors AdminPages::Controller#udpate to work with new method - Adds a remote attribute, overwrite, to Admin::PagesController via a hidden_field in pages/_form.html.erb and an attr_accessor in the Page model - Adds a toggleOverwrite() function to pages/_form.html.erb to toggle the (soon to be hidden) overwrite checkbox in the form -- the checkbox is toggled on button click * Adds a guard clause to #landing_page_path in Page.rb * Adds a safe naviagtor to Admin::PagesController#update_and_overwrite_landing_page * Adds a type and return to Overwrite button to prevent submit * Adds a hidden class to the overwrite checkbox field in _form.html.erb - Hides the overwrite checkbox since it is only used to overwrite the landing_page boolean on click of the "Overwrite current locked screen" button * Adds Admin::PagesController#create_and_overwrite and removes hidden class * Adds landing page-related tests to admin_manages_pages_spec.rb * Remove messy commented out code and place it in GH comment instead * PR Review Feedback: Renames remote attr, defines class methods, updates views - Renames remote attribute to overwrite_landing_page - Updates all necessary views, methods, etc. w/ new attr - Defines two class methods to make code more extensible - Updates all necessary views, methods, etc. w/ new methods * Remove unnecessary comments and revert changes to ternary in _form.html.erb * Adjustments for accessibility within _form and index - Adds a descriptive id to <p> in _form.html.erb - Adds an ariadescribedby field to _form.html.erb - Adjusts title within index.html.erb * Refactors landing_page-related code per PR review requests - Adds a landing_page_modal_controller.js that handles and further customizes the dismiss and overwrite button, and handles opening the modal - Adds a _landing_page_modal partial to extract modal-specific html outside of the _form.html.erb partial - Refactors _form.html.erb to account for the _landing_page_modal partial and the landing_page_modal_controller.js - Refactors the overwrite checkbox to be a hidden_field rather than a hidden checkbox and removes existing hidden_field to accomodate it - Loads the @landing_page within Admin::PagesController#edit for use by the _landing_page_modal.html.erb partial - Refactors Page#single_landing_page to be more readable - Removes useless JS from _form.html.erb * Removes #landing_page_exists? class method since it isnt used now * Uses the #landing_page class method within ApplicationController * Removes pending status from test in admin_manages_pages_spec.rb * Adds an e2e test for landing pages and adds to seeds_e2e - Adds a landingPage.spec.js to test landing pages - Adds a Page to seeds_e2e.rb for landingPage.spec.js * Removes references to articles from e2e test and adds clickable link * Adds another Page to seeds_e2e.rb and updates link names in test * Adds the Current Locked Screen title to modal and opens in new link * Renames Dismiss to Cancel and updates all necessary code * Adjusts landingPage.spec.js * check for existing landing page before showing modal * Update Cypress tests and fix bug in LandingPageModalController * Apply suggestions from code review Co-authored-by: Suzanne Aitchison <suzanne@forem.com> * Orders Pages by created_at desc in /admin/pages/index.html.erb for consistency * Targets specific edit button in landingPage.spec.js Co-authored-by: Suzanne Aitchison <suzanne@forem.com> Co-authored-by: rhymes <github@rhymes.dev>
74 lines
2.3 KiB
Ruby
74 lines
2.3 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe Page, type: :model do
|
|
describe "#validations" do
|
|
it "requires either body_markdown, body_html, or body_json" do
|
|
page = build(:page)
|
|
page.body_html = nil
|
|
page.body_markdown = nil
|
|
page.body_json = nil
|
|
expect(page).not_to be_valid
|
|
end
|
|
|
|
it "takes organization slug into account" do
|
|
create(:organization, slug: "benandfriends")
|
|
page = build(:page, slug: "benandfriends")
|
|
expect(page).not_to be_valid
|
|
expect(page.errors[:slug].to_s.include?("taken")).to be true
|
|
end
|
|
|
|
it "takes podcast slug into account" do
|
|
create(:podcast, slug: "benmeetsworld")
|
|
page = build(:page, slug: "benmeetsworld")
|
|
expect(page).not_to be_valid
|
|
expect(page.errors[:slug].to_s.include?("taken")).to be true
|
|
end
|
|
|
|
it "takes user username into account" do
|
|
create(:user, username: "bennybenben")
|
|
page = build(:page, slug: "bennybenben")
|
|
expect(page).not_to be_valid
|
|
expect(page.errors[:slug].to_s.include?("taken")).to be true
|
|
end
|
|
|
|
it "takes sitemap into account" do
|
|
page = build(:page, slug: "sitemap-hey")
|
|
expect(page).not_to be_valid
|
|
expect(page.errors[:slug].to_s.include?("taken")).to be true
|
|
end
|
|
|
|
it "only allows a single landing_page to be set to true" do
|
|
create(:page, landing_page: true)
|
|
page = build(:page, landing_page: true)
|
|
expect(page).not_to be_valid
|
|
expect(page.errors[:base].to_s.include?("Only one page")).to be true
|
|
end
|
|
end
|
|
|
|
context "when callbacks are triggered before save" do
|
|
let(:page) { create(:page) }
|
|
|
|
describe "#processed_html" do
|
|
it "accepts body markdown and turns it into html" do
|
|
page.update(body_markdown: "Hello `heyhey`")
|
|
expect(page.processed_html).to include("<code>")
|
|
end
|
|
|
|
it "accepts body html without changing it" do
|
|
html = "Hello `heyhey`"
|
|
page.update(body_html: html, body_markdown: "")
|
|
expect(page.processed_html).to eq(html)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when callbacks are triggered after save" do
|
|
let(:page) { create(:page) }
|
|
|
|
it "triggers cache busting on save" do
|
|
sidekiq_assert_enqueued_with(job: Pages::BustCacheWorker, args: [page.slug]) do
|
|
page.save
|
|
end
|
|
end
|
|
end
|
|
end
|