maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/services
History
Jeremy Friesen 1b337b85d9
Only fetch RSS of users who can create articles (#16766) 
* Only fetch RSS of users who can create articles

This commit leverages changes from forem/forem#16732 and
forem/forem#16763 to ensure that we're only fetching RSS feeds for
folks who have permission to create articles.

In addition, I chose to rename the variable `user_scope` to
`users_scope` to bring consistency in the variable names.

I also chose to refactor a private method so that it wasn't setting two
instance variables but was instead returning a value that could be used
to set an instance variable.

Closes forem/forem#16487

* Amending method name
2022-03-04 14:06:38 -05:00
..
articles Removing Articles::Builder making policy decision (#16536) 2022-02-14 11:39:22 -05:00
audit Remove Audit::Event::Util (#8704) 2020-06-16 12:50:53 -04:00
authentication Prevent banished users from updating their profiles (#16122) 2022-01-17 10:54:02 -05:00
badges Skip badge awards for spam accounts (#15344) 2021-11-10 10:48:01 -06:00
broadcasts/welcome_notification Login with Google (#15986) 2022-01-13 10:25:52 -06:00
color Spelling (#15702) 2021-12-07 06:59:10 -07:00
credits More ListingsToolkit refactoring (#16221) 2022-01-27 09:47:41 +07:00
discover Add Forem Discover registration worker and service (#14865) 2021-10-01 10:27:31 -04:00
edge_cache ✂✂✂ Remove events (#15062) 2021-10-15 09:31:08 -04:00
exporter Create Settings::SMTP (#13943) 2021-06-14 10:29:43 -04:00
fastly_config Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
feeds Only fetch RSS of users who can create articles (#16766) 2022-03-04 14:06:38 -05:00
follows Move app/labor/follow_checker.rb to service (#11613) 2020-12-01 14:14:36 +07:00
giphy Adjust type tags for RSpec (#4864) 2019-11-20 13:01:30 -05:00
github Implement Unified Embeds for Github Repo, Issue, Pull-Request and Comment URLs (#16422) 2022-02-07 16:38:43 -05:00
homepage Extracting duplicate logic (#16035) 2022-01-10 15:19:04 -05:00
html Remove line break after linking username mentions (#15788) 2021-12-16 10:39:07 -06:00
images Refactoring to add helper method (#16064) 2022-01-12 11:21:44 -05:00
listings ListingsToolkit refactoring (#16184) 2022-01-21 09:27:10 +07:00
loggers Move LogWorkerQueueStats from labor to services (#11642) 2020-11-30 09:31:15 +07:00
mailchimp Handle GibbonError when Mailchimp api key was not set (#14695) 2021-09-13 10:30:35 -05:00
markdown_processor Allowing dependency injection for LiquidTag policy (#16511) 2022-02-10 07:47:16 -05:00
mentions Issue #9077 has already been resolved, added specs (#15342) 2021-11-17 11:27:50 +02:00
moderator Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
notification_subscriptions Add Article post_commit when user_id changes with specs (#15132) 2021-10-25 10:53:21 +07:00
notifications Fix integer > nil error when sending reaction notifications (#16627) 2022-02-17 16:30:39 -06:00
organizations Organizations delete optimizations and refactoring (#13610) 2021-05-11 12:14:55 +03:00
payments Validate payment info present before attempting to process (#15629) 2021-12-03 13:09:23 -06:00
podcasts Spelling (#15702) 2021-12-07 06:59:10 -07:00
profile_fields Require profile fields to belong to a group (#16390) 2022-02-15 09:27:18 -06:00
push_notifications Fix Rpush app when creating Android notification (#15529) 2021-11-30 10:05:40 +05:30
re_captcha Spelling (#15702) 2021-12-07 06:59:10 -07:00
search Added "Tags" category to search results (#16265) 2022-01-26 20:51:15 +03:00
settings/authentication Disable all providers when providers_to_enable param is blank (#15260) 2021-11-02 21:20:26 -04:00
slack Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
spam Refactoring Spam Handler (#15412) 2021-11-30 12:45:12 -05:00
tag_moderators ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
twitter_client Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
user_subscriptions Update CODEOWNERS and team names in TODO comments (#9460) 2020-07-24 12:17:20 +07:00
users Automatically create user profile if it's missing (#15787) 2021-12-15 14:03:51 -05:00
analytics_service_spec.rb Ensure the domain of other_url is different from top_url (#16373) 2022-02-01 09:18:49 -05:00
article_with_video_creation_service_spec.rb Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121) 2021-07-08 09:31:34 -05:00
bulk_sql_delete_spec.rb Routine rubocop fixes (#10237) 2020-09-08 12:06:47 -04:00
email_digest_article_collector_spec.rb Don't include "anti-followed" tags in email digest (#14782) 2021-09-30 10:44:38 +07:00
email_digest_spec.rb Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121) 2021-07-08 09:31:34 -05:00
feature_flag_spec.rb Add FeatureFlag.all (#16496) 2022-02-11 13:38:17 +07:00
flare_tag_spec.rb [deploy] Optimization: Dont Use Redis For Flare Tag IDs, Load Them On Boot (#8987) 2020-06-30 09:48:08 -05:00
medium_article_retrieval_service_spec.rb Nokogiri::HTML should receive the body, not the response object (#5297) 2019-12-31 08:46:49 -05:00
rate_limit_checker_spec.rb Fixing Rubocop's auto-correct recommendations (#16098) 2022-01-13 21:40:19 -05:00
tag_adjustment_creation_service_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
tag_adjustment_update_service_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00