* Conditionally disabling Listings Prior to this commit, we were assuming everyone still had the Listing's feature turned on. With this commit, we move from the "implicitly on" nature of `FeatureFlag.accessible?` to the "explicitly off" nature of `FeatureFlag.enabled?`. The key differentiator is that we are not "pushing out a feature flag setting to other forems." Listings now become an "opt-in". This requires a few things: 1) Ensure that DEV.to enables the `:listing_feature` before we deploy this branch. 2) Communicate this change to other Forem adopters and provide a timeline for when we'll deploy this change. 3) Documentation. Given that we have this feature, but it will be disabled by default, we want to look into communicating what it is and how to enable it. Further, I chose to do the least effort change on our specs. Namely to treat the specs as though someone fully enabled the listing feature. This pull request is a "competetor" to #16423. Closes forem/rfcs#291 Relates to #16420 and #16461. * Favoring only setting feature for specific tests. * Adjusting cypress to avoid listing check * Removing redundant test based on feedback * Fixing feature spec * Fixing cypress test |
||
|---|---|---|
| .. | ||
| fixtures | ||
| integration | ||
| plugins | ||
| support | ||
| util | ||
| .eslintrc.js | ||
| jsconfig.json | ||