* Rename banned and comment_banned roles * Add data update script to rename roles containing 'ban' * Add named error for Suspended users * Update unidiomatic method names * Rename misc banned to suspended * Apply suggestions from code review Co-authored-by: Michael Kohl <me@citizen428.net> * Add unit tests for suspended methods This commit also adds TODO comments for removing banned and comment_banned from the codebase after data update scripts have successfully run on all of our Forems. Co-authored-by: Michael Kohl <me@citizen428.net>
111 lines
2.9 KiB
Ruby
111 lines
2.9 KiB
Ruby
module Profiles
|
|
class Update
|
|
using HashAnyKey
|
|
include ImageUploads
|
|
|
|
CORE_PROFILE_FIELDS = %i[summary brand_color1 brand_color2].freeze
|
|
CORE_USER_FIELDS = %i[name username profile_image].freeze
|
|
|
|
def self.call(user, updated_attributes = {})
|
|
new(user, updated_attributes).call
|
|
end
|
|
|
|
def initialize(user, updated_attributes)
|
|
@user = user
|
|
@profile = user.profile
|
|
@updated_profile_attributes = updated_attributes[:profile] || {}
|
|
@updated_user_attributes = updated_attributes[:user].to_h || {}
|
|
@errors = []
|
|
@success = false
|
|
end
|
|
|
|
def call
|
|
if update_successful?
|
|
@success = true
|
|
@user.touch(:profile_updated_at)
|
|
conditionally_resave_articles
|
|
else
|
|
errors.concat(@profile.errors.full_messages)
|
|
errors.concat(@user.errors.full_messages)
|
|
Honeycomb.add_field("error", errors_as_sentence)
|
|
Honeycomb.add_field("errored", true)
|
|
end
|
|
self
|
|
end
|
|
|
|
def success?
|
|
@success
|
|
end
|
|
|
|
def errors_as_sentence
|
|
errors.to_sentence
|
|
end
|
|
|
|
private
|
|
|
|
attr_reader :errors
|
|
|
|
def update_successful?
|
|
return false unless verify_profile_image
|
|
|
|
Profile.transaction do
|
|
update_profile
|
|
@user.update!(@updated_user_attributes)
|
|
end
|
|
true
|
|
rescue ActiveRecord::RecordInvalid
|
|
false
|
|
end
|
|
|
|
def verify_profile_image
|
|
image = @updated_user_attributes[:profile_image]
|
|
return true unless image
|
|
return true if valid_image_file?(image) && valid_filename?(image)
|
|
|
|
false
|
|
end
|
|
|
|
def valid_image_file?(image)
|
|
return true if file?(image)
|
|
|
|
errors.append(IS_NOT_FILE_MESSAGE)
|
|
false
|
|
end
|
|
|
|
def valid_filename?(image)
|
|
return true unless long_filename?(image)
|
|
|
|
errors.append(FILENAME_TOO_LONG_MESSAGE)
|
|
false
|
|
end
|
|
|
|
def update_profile
|
|
# Handle user specific custom profile fields
|
|
if (custom_profile_attributes = @profile.custom_profile_attributes).any?
|
|
custom_attributes = @updated_profile_attributes.extract!(*custom_profile_attributes)
|
|
@updated_profile_attributes[:custom_attributes] = custom_attributes
|
|
end
|
|
|
|
# We don't update `data` directly. This uses the defined store_attributes
|
|
# so we can make use of their typecasting.
|
|
@profile.assign_attributes(@updated_profile_attributes)
|
|
|
|
# Before saving, filter out obsolete profile fields
|
|
@profile.data.slice!(*Profile.attributes)
|
|
|
|
@profile.save!
|
|
end
|
|
|
|
def conditionally_resave_articles
|
|
return unless core_profile_details_changed? && !@user.suspended?
|
|
|
|
Users::ResaveArticlesWorker.perform_async(@user.id)
|
|
end
|
|
|
|
def core_profile_details_changed?
|
|
user_fields = CORE_USER_FIELDS + Authentication::Providers.username_fields
|
|
@updated_user_attributes.any_key?(user_fields) ||
|
|
@updated_profile_attributes.any_key?(CORE_PROFILE_FIELDS)
|
|
end
|
|
end
|
|
end
|