maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/system
History
Joshua Wehner a20cf3e02b
Unique cross-model-slug check is likely misconfigured (#19263) 
* Page unique_cross_model_slug seems misconfigured

* Update validator test

* More verbose invalid attribute message

* Try dynamic model/attribute registration

* Rubocop

* Use the cross-model-slug existence check

* Register with the dynamic cross-model-slug checker

* Cleanup

* Add missing keys to fr

* Update format regex

* Adjust validation: always presence, unique if changed

* Tests can create reserved-word pages when they need to

* Slugs can be mixed case?

* Case-sensitive is better, actually

* Refactor to use CrossModel check

* Refactor, rename for clarity

* Refactor, avoid mocking oneself

* Refactor, injectable everything

* Add reservedword check to extracted exists? checker

* Move to concerns

* Without dynamic registration

* extend when needed

* Cleanup comments, remove registration references

---------

Co-authored-by: Goran <gorang.pub@gmail.com>
2023-04-07 17:04:45 +02:00
..
admin Unique cross-model-slug check is likely misconfigured (#19263) 2023-04-07 17:04:45 +02:00
ahoy Async Hamburger Menu Implementation + Caching Optimizations (#18818) 2022-12-20 20:00:08 +02:00
articles Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
authentication Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
collections Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
comments Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
dashboards Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
homepage Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
notifications Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
onboardings Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
organization Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
podcasts Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
search Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
tags Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
user Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
videos Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
banned_user_interactions_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
feedback_message_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
link_for_tags_in_posts_in_notifications_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
user_logs_in_with_password_spec.rb Show a "Unable to login" message in browser when a user is unable to login. (#17261) 2022-04-13 09:00:56 -04:00
user_uses_the_editor_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
user_views_a_reading_list_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
user_views_logo_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00
user_visits_a_comments_page_spec.rb Routine rubocop fix on /spec (#19217) 2023-03-21 09:55:26 -04:00