2b3f4e1342
* Refactoring cached_followed_tags This refactor consolidates two queries and a loop into a single query. One thing that is unclear is if we're ever really clearing the cache of the user by id? What follows is un-related to the refactor but appears to be related to #14937. > First, I see we set a cache here: > >ebdaaaf15b/app/decorators/user_decorator.rb (L23-L34)> > But when I look at what busts the user cache, it doesn’t look like we’re busting it for the above cached location: > >ebdaaaf15b/app/services/edge_cache/bust_user.rb (L3-L22)> > What if anything am I missing in regards to cache busting? * Adding some deprecated methods * Updating documentation * Bump for travis * Bump for travis * Updating comments to fix confusion NOTE: I might be introducing more confusion, but at least I'm addressing the prior confusion. * Bump for travis * Updating so we don't cache ActiveRecord objects * Selecting only applicable attributes for caching * Apply suggestions from code review Co-authored-by: Michael Kohl <citizen428@forem.com> * Adjusting code based on feedback * Bump for travis * Bump for travis * Update app/decorators/user_decorator.rb Co-authored-by: Michael Kohl <citizen428@forem.com> Co-authored-by: Michael Kohl <citizen428@forem.com>
60 lines
2.3 KiB
Ruby
60 lines
2.3 KiB
Ruby
class Follow < ApplicationRecord
|
|
extend ActsAsFollower::FollowerLib
|
|
extend ActsAsFollower::FollowScopes
|
|
|
|
COUNTER_CULTURE_COLUMN_NAME_BY_TYPE = {
|
|
"User" => "following_users_count",
|
|
"Organization" => "following_orgs_count",
|
|
"ActsAsTaggableOn::Tag" => "following_tags_count"
|
|
}.freeze
|
|
|
|
COUNTER_CULTURE_COLUMNS_NAMES = {
|
|
["follows.followable_type = ?", "User"] => "following_users_count",
|
|
["follows.followable_type = ?", "Organization"] => "following_orgs_count",
|
|
["follows.followable_type = ?", "ActsAsTaggableOn::Tag"] => "following_tags_count"
|
|
}.freeze
|
|
|
|
# Follows belong to the "followable" interface, and also to followers
|
|
belongs_to :followable, polymorphic: true
|
|
belongs_to :follower, polymorphic: true
|
|
|
|
scope :followable_user, ->(id) { where(followable_id: id, followable_type: "User") }
|
|
scope :followable_tag, ->(id) { where(followable_id: id, followable_type: "ActsAsTaggableOn::Tag") }
|
|
|
|
# NOTE: These assume that we have one follower_type (as defined by acts_as_follower).
|
|
scope :follower_user, ->(id) { where(follower_id: id, followable_type: "User") }
|
|
scope :follower_organization, ->(id) { where(follower_id: id, followable_type: "Organization") }
|
|
scope :follower_podcast, ->(id) { where(follower_id: id, followable_type: "Podcast") }
|
|
scope :follower_tag, ->(id) { where(follower_id: id, followable_type: "ActsAsTaggableOn::Tag") }
|
|
|
|
counter_culture :follower, column_name: proc { |follow| COUNTER_CULTURE_COLUMN_NAME_BY_TYPE[follow.followable_type] },
|
|
column_names: COUNTER_CULTURE_COLUMNS_NAMES
|
|
before_save :calculate_points
|
|
after_create :send_email_notification
|
|
after_save :touch_follower
|
|
|
|
validates :blocked, inclusion: { in: [true, false] }
|
|
validates :followable_type, presence: true
|
|
validates :follower_type, presence: true
|
|
validates :subscription_status, presence: true, inclusion: { in: %w[all_articles none] }
|
|
|
|
def self.need_new_follower_notification_for?(followable_type)
|
|
%w[User Organization].include?(followable_type)
|
|
end
|
|
|
|
private
|
|
|
|
def calculate_points
|
|
self.points = explicit_points + implicit_points
|
|
end
|
|
|
|
def touch_follower
|
|
follower.touch(:updated_at, :last_followed_at)
|
|
end
|
|
|
|
def send_email_notification
|
|
return unless followable.instance_of?(User) && followable.email?
|
|
|
|
Follows::SendEmailNotificationWorker.perform_async(id)
|
|
end
|
|
end
|