docbrown/app
Jeremy Friesen 9df5f6af49
Ensuring reading list excludes unpublished articles (#15490)
* Ensuring reading list excludes unpublished articles

Prior to this commit, if a given user adds an article to their reading
list then the author unpublishes the article, the article remains in the
reading list.  When the given user would then "click" on the now
unpublished article, they would get a 404 Not Found notice.

With this commit, we now exclude unpublished articles from the search
results for the reading list.

This should also address the issue of attempting to archive the reading
list item (because it won't be visible in the listing).

One of the behaviors that is expected is if, in the above scenario, the
author again publishes the article, that article will again "appear" on
the reading list for the given user.

Closes #14796

* Updating documentation and adding spec

* Addressing pull request feedback

Yes, I should've used a scope!  And also, no need to test present.  Just
let it's "truthy"-ness speak for itself!

* Update spec/services/search/reading_list_spec.rb

Co-authored-by: Jamie Gaskins <jamie@forem.com>

Co-authored-by: Jamie Gaskins <jamie@forem.com>
2021-11-24 13:22:26 -05:00
..
assets Preventing author profile from going transparent (#15478) 2021-11-24 09:38:13 -05:00
black_box Make Rubocop happy again (#14729) 2021-09-14 09:15:01 -05:00
components/admin/users Small change to make the tools section of member details mobile friendly. (#15159) 2021-10-22 18:47:20 +02:00
controllers ForemMobile namespaced functions (#15212) 2021-11-23 15:25:29 -06:00
decorators Theming cleanup (#15237) 2021-11-09 10:11:55 -05:00
errors Guarding against spam from OAuth Sources (#15404) 2021-11-18 16:26:39 -05:00
helpers Enable Forem (Passport) Auth (#15141) 2021-11-23 14:59:00 -06:00
javascript Preventing author profile from going transparent (#15478) 2021-11-24 09:38:13 -05:00
lib ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
liquid_tags complete changes (#15420) 2021-11-18 14:19:45 -05:00
mailers ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
models Ensuring reading list excludes unpublished articles (#15490) 2021-11-24 13:22:26 -05:00
policies ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
queries Adds validations to avoid creating unnecessary PNs (#14621) 2021-08-31 15:00:30 -06:00
refinements Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
sanitizers Remove redundant freeze calls (#14596) 2021-08-26 10:01:08 -04:00
serializers ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
services Ensuring reading list excludes unpublished articles (#15490) 2021-11-24 13:22:26 -05:00
uploaders ✂✂✂ Remove events (#15062) 2021-10-15 09:31:08 -04:00
validators Updating valid domain registration (#15436) 2021-11-19 10:05:00 -05:00
view_objects Upgrade to Ruby 3.0.2 (#12103) 2021-08-25 14:26:33 -04:00
views Preventing author profile from going transparent (#15478) 2021-11-24 09:38:13 -05:00
workers Guarding against missing experiments (#15440) 2021-11-22 16:06:32 -05:00