docbrown/spec/policies
Jeremy Friesen c3c884f4d0
Conditional rendering of "Create Post" link (#17076)
* WIP - Conditional rendering of "Create Post" link

This PR builds on the conversation from forem/forem#17056 and moves in a
slightly different direction.

Important in all of this is that the ability to create a post is
enforced on the server.  If the "Create Post" button were to be visible
but the user couldn't create a post when they clicked the button, they
would get an authorization error (or some such response).

This PR posits a different and perhaps competing approach to
forem/forem#16606.  This PR provides a general approach in which we add
class attributes in our HTML erb files.

Note: I have not included Cypress tests as I don't want to yet commit
that time.  I'm also wondering if this is the "right" thing to do.  I
definitely think we want to add some JS tests.  But could we do JS and
unit tests?  (How do we reach consensus regarding our test approach?)

Again, thank you for the conversation and expect an even more "complete"
PR after we have our discussion.

* Extracting AsyncInfo model to ease testing

* Renaming forbidden to visible

* Adding cypress test to assert no 'Create Post'

These are always treacherous.  What happens when we rename the button?
The test will continue to work.

* Apply suggestions from code review

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Switching to pack file for policy

Follows on [Suzanne's comment](https://github.com/forem/forem/pull/17076#issuecomment-1088567286)

* Update app/javascript/packs/applyApplicationPolicyToggles.js

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-04-05 12:47:12 -04:00
..
shared_examples Penciling in a Default Spaces section (#16897) 2022-03-21 09:56:12 -04:00
admin_policy_spec.rb Use build_stubbed in Policy specs (#4017) [ci skip] 2019-09-13 11:38:58 -04:00
api_secret_policy_spec.rb Rename banned and comment_banned roles (#12270) 2021-04-06 10:12:14 -05:00
application_policy_spec.rb Conditional rendering of "Create Post" link (#17076) 2022-04-05 12:47:12 -04:00
article_policy_spec.rb Ensuring users can preview already published posts (#17123) 2022-04-05 12:31:02 -04:00
authorizer_spec.rb Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
comment_policy_spec.rb Adjusting suspended user authorizations (#16634) 2022-02-21 10:08:24 -05:00
discussion_lock_policy_spec.rb Create DiscussionLocks (#13905) 2021-06-10 11:04:33 -04:00
follow_policy_spec.rb Adjusting suspended user authorizations (#16634) 2022-02-21 10:08:24 -05:00
github_repo_policy_spec.rb Split Settings::Authentication from SiteConfig (#13095) 2021-04-12 09:41:09 +02:00
html_variant_policy_spec.rb Use build_stubbed in Policy specs (#4017) [ci skip] 2019-09-13 11:38:58 -04:00
image_upload_policy_spec.rb Rename banned and comment_banned roles (#12270) 2021-04-06 10:12:14 -05:00
internal_policy_spec.rb Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
liquid_tag_policy_spec.rb Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
organization_policy_spec.rb Ensuring the same policies for analytics (#16997) 2022-03-25 14:57:01 -04:00
pinned_article_policy_spec.rb expect to forbid, rather than expect not to permit (#14390) 2021-07-30 11:42:47 -05:00
reaction_policy_spec.rb Adjusting suspended user authorizations (#16634) 2022-02-21 10:08:24 -05:00
response_template_policy_spec.rb Add response templates for internal usage (#6676) 2020-03-20 11:32:55 -04:00
space_policy_spec.rb Penciling in a Default Spaces section (#16897) 2022-03-21 09:56:12 -04:00
stripe_active_card_policy_spec.rb Rename banned and comment_banned roles (#12270) 2021-04-06 10:12:14 -05:00
tag_policy_spec.rb Use build_stubbed in Policy specs (#4017) [ci skip] 2019-09-13 11:38:58 -04:00
user_policy_spec.rb Ensuring the same policies for analytics (#16997) 2022-03-25 14:57:01 -04:00
video_policy_spec.rb Ensuring the VideoPolicy adhears to article creation (#16762) 2022-03-07 15:27:18 -05:00