docbrown/app/lib
Daniel Uber 21e9966ccb
Relax tag validation restriction to permit non-ascii strings (#14710)
* Relax tag validation restriction to permit alphanumeric strings

Non-word symbols like musical notes are still blocked, but most
languages should work.

* Handle redirect after tag edit

The URI.parse(tag.name) was not updated in #13720

Move reused logic into tag_path method in URL module.

* FactoryBot generated tags are non-ascii

This should help expose any cases where we're mistakenly counting on
ascii-only content in tags by causing all generated tags without a
specified name to be of the form `tag你好#{n}` instead of `tag#{n}`.

* Revert "FactoryBot generated tags are non-ascii"

This reverts commit ed1035cd1e91619b2c1599e521b6ddf962c97f80.

It was useful to see how many places the path knowledge is in the
tests (a lot of requests have GET /t/tag.name and need to have GET
URL.tag_path instead).

https://app.travis-ci.com/github/forem/forem/builds/237542600 has the
results.

Reverting because those test-side changes seem like a secondary
concern to the change in this PR (I'll file a follow on issue)
2021-09-14 14:03:54 -05:00
..
acts_as_taggable_on Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606) 2021-05-03 11:09:45 -04:00
constants Bump rubocop from 1.17.0 to 1.18.0 (#14107) 2021-07-01 13:51:49 +02:00
forem_stats_drivers Arrange Datadog Redis integrations more usefully (#14185) 2021-07-09 15:19:37 -04:00
honeycomb [deploy] Optimization:Throttle Noisy Honeycomb Events More (#10143) 2020-09-01 15:21:07 -05:00
middlewares Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
redcarpet/render Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
reverse_markdown/converters Preserve newlines and indentation in <pre> tags from RSS import (#10922) 2020-10-20 09:25:57 -04:00
acts_as_forem_stats_driver.rb Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
api_constraints.rb [15 min fix] Fix some autoloading deprecation warnings (#13793) 2021-05-20 18:10:25 +02:00
app_secrets.rb [deploy] Feature: Setup Admin Area to Update Vault Secrets (#8935) 2020-06-29 15:08:09 -05:00
forem_stats_driver.rb Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
html_css_to_image.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
menu.rb RFC#50-P4: Feature Flagged Routes and Interaction Design (#12967) 2021-03-23 11:12:54 +02:00
release_phase_notifier.rb [deploy] Refactor:Send a Couple More Errors to Honeybadger (#9223) 2020-07-09 10:53:16 -05:00
seeder.rb Cleaning Test Runs for End to End (E2E) Tests (#12143) 2021-01-29 13:34:01 +01:00
throttled_call.rb Spike: Add ThrottledCall utility class (#12779) 2021-03-01 08:51:04 +07:00
url.rb Relax tag validation restriction to permit non-ascii strings (#14710) 2021-09-14 14:03:54 -05:00