b115b2d17e
I was working on another branch and as part of my commit, Rubocop
removed a validation (but not the spec that asserted the validation).
Below is the "non-updating" rubocop offense on the other branch.
```shell
❯ rubocop ./app/models/notification_subscription.rb
Inspecting 1 file
C
Offenses:
app/models/notification_subscription.rb:13:29: C: [Correctable]
Rails/RedundantPresenceValidationOnBelongsTo: Remove explicit presence
validation for notifiable_id.
validates :notifiable_id, presence: true
^^^^^^^^^^^^^^
1 file inspected, 1 offense detected, 1 offense auto-correctable
```
To remediate, I ran:
```shell
> rubocop --only "Rails/RedundantPresenceValidationOnBelongsTo" \
--auto-correct
```
This resolved the `app/models`. Then did some regex magic and removed
the assertions from `spec/models`.
For Forem folks, I wrote a [forem.team post][1] discuss if this is how
we want to proceed.
[1]:https://forem.team/jeremy/rubocop-auto-updating-mayhem-33a6
34 lines
1.1 KiB
Ruby
34 lines
1.1 KiB
Ruby
# @note When we destroy the related user, it's using dependent:
|
|
# :delete for the relationship. That means no before/after
|
|
# destroy callbacks will be called on this object.
|
|
#
|
|
# @note When we destroy the related article, it's using dependent:
|
|
# :delete for the relationship. That means no before/after
|
|
# destroy callbacks will be called on this object.
|
|
class Mention < ApplicationRecord
|
|
belongs_to :user
|
|
belongs_to :mentionable, polymorphic: true
|
|
|
|
validates :user_id, uniqueness: { scope: %i[mentionable_id mentionable_type] }
|
|
validates :mentionable_type, presence: true
|
|
validate :permission
|
|
|
|
after_create_commit :send_email_notification
|
|
|
|
def self.create_all(notifiable)
|
|
Mentions::CreateAllWorker.perform_async(notifiable.id, notifiable.class.name)
|
|
end
|
|
|
|
private
|
|
|
|
def send_email_notification
|
|
user = User.find(user_id)
|
|
return unless user.email.present? && user.notification_setting.email_mention_notifications
|
|
|
|
Mentions::SendEmailNotificationWorker.perform_async(id)
|
|
end
|
|
|
|
def permission
|
|
errors.add(:mentionable_id, "is not valid.") unless mentionable&.valid?
|
|
end
|
|
end
|