71e90a41f5
* Disable all providers when providers_to_enable param is blank * Remove guard, a couple more spec examples * Update app/services/settings/authentication/upsert.rb Co-authored-by: Fernando Valverde <fernando@visualcosita.com> Co-authored-by: Fernando Valverde <fernando@visualcosita.com>
77 lines
2.2 KiB
Ruby
77 lines
2.2 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe Settings::Authentication::Upsert, type: :service do
|
|
before { Settings::Authentication.providers = %w[github] }
|
|
|
|
it "assigns enabled providers from parameters" do
|
|
expect do
|
|
described_class.call(
|
|
{
|
|
"auth_providers_to_enable" => "github,facebook,twitter",
|
|
"github_key" => "asdf",
|
|
"github_secret" => "asdf_secret",
|
|
"twitter_key" => "asdf",
|
|
"twitter_secret" => "asdf_secret",
|
|
"facebook_key" => "asdf",
|
|
"facebook_secret" => "asdf_secret"
|
|
},
|
|
)
|
|
end.to change {
|
|
Settings::Authentication.providers
|
|
}.from(%w[github]).to(%w[github facebook twitter])
|
|
end
|
|
|
|
it "disables providers that are not present" do
|
|
expect do
|
|
described_class.call(
|
|
{
|
|
"auth_providers_to_enable" => "twitter",
|
|
"twitter_key" => "asdf",
|
|
"twitter_secret" => "asdf_secret"
|
|
},
|
|
)
|
|
end.to change {
|
|
Settings::Authentication.providers
|
|
}.from(%w[github]).to(%w[twitter])
|
|
end
|
|
|
|
it "does not save 1 or fewer providers when email_password login is not allowed" do
|
|
expect do
|
|
Settings::Authentication.allow_email_password_login = false
|
|
described_class.call(
|
|
{
|
|
"auth_providers_to_enable" => "twitter",
|
|
"twitter_key" => "asdf",
|
|
"twitter_secret" => "asdf_secret"
|
|
},
|
|
)
|
|
end.not_to change {
|
|
Settings::Authentication.providers
|
|
}
|
|
end
|
|
|
|
it "will save with 1 or providers providers when email_password login is not allowed" do
|
|
expect do
|
|
Settings::Authentication.allow_email_password_login = false
|
|
described_class.call(
|
|
{
|
|
"auth_providers_to_enable" => "twitter,github",
|
|
"twitter_key" => "asdf",
|
|
"twitter_secret" => "asdf_secret",
|
|
"github_key" => "asdf",
|
|
"github_secret" => "asdf_secret"
|
|
},
|
|
)
|
|
end.to change {
|
|
Settings::Authentication.providers
|
|
}.from(%w[github]).to(%w[twitter github])
|
|
end
|
|
|
|
it "disables providers even when provider parameter is blank" do
|
|
expect do
|
|
described_class.call({ "auth_providers_to_enable" => "" })
|
|
end.to change {
|
|
Settings::Authentication.providers
|
|
}.from(%w[github]).to([])
|
|
end
|
|
end
|