docbrown/app
Daniel Uber 913ca720a8
Don't create podcast episodes without any media (#17449)
* Don't create podcast episodes without a media_url

There is an early return from add_media_url to prevent using an empty
enclosure_url, which avoids errors in
`GetMediaUrl.call(a_blank_value)`, however there's also a not null
constraint on podcast_episodes.media_url in the database, which causes
upsert to raise an error.

Returning early here avoids the error (which had halted the worker).

See also
https://app.honeybadger.io/projects/66984/faults/80833402

This error happens regularly, 96 times per day in DEV, it looks like at least
one podcast feed_url is for an rss feed filtered by /tag/podcast/,
(and at least one post was tagged "podcast" but didn't include any
media to get).

My understanding is at worst we'll ignore the error silently.

* Add test cases

given a blog post (not a podcast episode, no media url), don't raise
any error, don't create any episode.

Included codepunk.io feed that was showing this issue initially.
2022-04-27 11:21:03 -05:00
..
assets toggle fix for spaces (#17343) 2022-04-20 16:45:34 +02:00
controllers validate sort direction (#17439) 2022-04-27 08:59:13 -05:00
decorators Profile attribute names should be unique and non-empty (#16396) 2022-04-04 12:14:02 -05:00
errors Favoring re-use of authorization error (#16992) 2022-03-24 08:16:28 -04:00
forms Using a Form Object that will persist for the Creator Settings Form (#15684) 2021-12-10 17:07:40 +02:00
helpers Limit an organizations displayed and add an overflow count (#17339) 2022-04-20 13:10:17 +02:00
javascript Bump focus-trap from 6.7.3 to 6.8.1 (#17425) 2022-04-27 08:09:21 -06:00
lib Avoid redirection by replacing with newer URL (#17320) 2022-04-18 22:12:21 -04:00
liquid_tags Revalidate embedded links that redirect (#17150) 2022-04-07 13:32:07 -04:00
mailers "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
models Removing WeightedQueryStrategy; use VariantQuery now (#17420) 2022-04-27 09:19:09 -04:00
policies Encapsulating the "why we hide/show" something (#17166) 2022-04-11 13:40:16 -04:00
queries validate sort direction (#17439) 2022-04-27 08:59:13 -05:00
refinements
sanitizers Don't sanitize anchor elements with no href (#16667) 2022-02-22 11:27:38 -06:00
serializers Remove unused methods from User (#16616) 2022-02-18 09:02:17 +07:00
services Don't create podcast episodes without any media (#17449) 2022-04-27 11:21:03 -05:00
uploaders small non-views ruby i18n (#16004) 2022-01-11 10:05:18 +07:00
validators Remove the "Getting Started" Section from the Config (#16033) 2022-01-20 07:31:35 -07:00
view_objects Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
views DO NOT MERGE: Remove the Member Index View Feature Flags + old code (#17388) 2022-04-25 14:49:34 +02:00
workers Skip rescoring draft articles (#17379) 2022-04-21 10:56:59 -05:00