2b3f4e1342
* Refactoring cached_followed_tags This refactor consolidates two queries and a loop into a single query. One thing that is unclear is if we're ever really clearing the cache of the user by id? What follows is un-related to the refactor but appears to be related to #14937. > First, I see we set a cache here: > >ebdaaaf15b/app/decorators/user_decorator.rb (L23-L34)> > But when I look at what busts the user cache, it doesn’t look like we’re busting it for the above cached location: > >ebdaaaf15b/app/services/edge_cache/bust_user.rb (L3-L22)> > What if anything am I missing in regards to cache busting? * Adding some deprecated methods * Updating documentation * Bump for travis * Bump for travis * Updating comments to fix confusion NOTE: I might be introducing more confusion, but at least I'm addressing the prior confusion. * Bump for travis * Updating so we don't cache ActiveRecord objects * Selecting only applicable attributes for caching * Apply suggestions from code review Co-authored-by: Michael Kohl <citizen428@forem.com> * Adjusting code based on feedback * Bump for travis * Bump for travis * Update app/decorators/user_decorator.rb Co-authored-by: Michael Kohl <citizen428@forem.com> Co-authored-by: Michael Kohl <citizen428@forem.com>
85 lines
2.6 KiB
Ruby
85 lines
2.6 KiB
Ruby
class AsyncInfoController < ApplicationController
|
|
# No pundit policy. All actions are unrestricted.
|
|
|
|
def base_data
|
|
flash.discard(:notice)
|
|
unless user_signed_in?
|
|
render json: {
|
|
broadcast: broadcast_data,
|
|
param: request_forgery_protection_token,
|
|
token: form_authenticity_token
|
|
}
|
|
return
|
|
end
|
|
@user = current_user.decorate
|
|
respond_to do |format|
|
|
format.json do
|
|
render json: {
|
|
broadcast: broadcast_data,
|
|
param: request_forgery_protection_token,
|
|
token: form_authenticity_token,
|
|
user: user_data,
|
|
creator: user_is_a_creator,
|
|
creator_onboarding: use_creator_onboarding
|
|
}
|
|
end
|
|
end
|
|
end
|
|
|
|
def broadcast_data
|
|
broadcast = Broadcast.announcement.active.first.presence
|
|
return unless broadcast
|
|
|
|
{
|
|
title: broadcast&.title,
|
|
html: broadcast&.processed_html,
|
|
banner_class: helpers.banner_class(broadcast)
|
|
}.to_json
|
|
end
|
|
|
|
def user_data
|
|
Rails.cache.fetch(user_cache_key, expires_in: 15.minutes) do
|
|
{
|
|
id: @user.id,
|
|
name: @user.name,
|
|
username: @user.username,
|
|
profile_image_90: @user.profile_image_url_for(length: 90),
|
|
followed_tags: @user.cached_followed_tags.to_json,
|
|
followed_podcast_ids: @user.cached_following_podcasts_ids,
|
|
reading_list_ids: @user.cached_reading_list_article_ids,
|
|
blocked_user_ids: UserBlock.cached_blocked_ids_for_blocker(@user.id),
|
|
saw_onboarding: @user.saw_onboarding,
|
|
checked_code_of_conduct: @user.checked_code_of_conduct,
|
|
checked_terms_and_conditions: @user.checked_terms_and_conditions,
|
|
display_sponsors: @user.display_sponsors,
|
|
display_announcements: @user.display_announcements,
|
|
trusted: @user.trusted?,
|
|
moderator_for_tags: @user.moderator_for_tags,
|
|
config_body_class: @user.config_body_class,
|
|
feed_style: feed_style_preference,
|
|
created_at: @user.created_at,
|
|
admin: @user.any_admin?
|
|
}
|
|
end.to_json
|
|
end
|
|
|
|
def user_is_a_creator
|
|
@user.creator?
|
|
end
|
|
|
|
def use_creator_onboarding
|
|
FeatureFlag.enabled?(:creator_onboarding) && user_is_a_creator
|
|
end
|
|
|
|
def user_cache_key
|
|
"user-info-#{current_user&.id}__
|
|
#{current_user&.last_sign_in_at}__
|
|
#{current_user&.following_tags_count}__
|
|
#{current_user&.last_followed_at}__
|
|
#{current_user&.last_reacted_at}__
|
|
#{current_user&.updated_at}__
|
|
#{current_user&.reactions_count}__
|
|
#{current_user&.articles_count}__
|
|
#{current_user&.blocking_others_count}__"
|
|
end
|
|
end
|