maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/views
History
Dmitry Maksyoma f63c7f9289
Fix Runkit tags not being activated when comment is added (#6767) 
* Fix Runkit tags not being activated when comment is added

* Runkit tag activation was ran once, on page load. I've changed it to
  run on on comment preview and submit.
* It was necessary to add a check to skip already activated Runkit
  tags. The code didn't take into account that a tag could be already
  processed, and would just crash.

* Fix Runkit tags and add tests

* Add test for previewing article with Runkit tag

* "Fix CodeClimate not finding waitForRunkitAndActivateTags()

* Refactor a test for readability

* Make Rubocop happy

* Improve test for previewing article with Runkit tag

* Use one method for determining active Runkit tags

* Defer loading of JS from embed.runkit.com

* Add utility function dynamicallyLoadScript(url)

* Switch to dynamic loading of Runkit

* parsed content code block is also hidden now to avoid displaying <code /> block before runkit iframe loads.

* Fix Runkit test

* Remove Runkit script caching in v2 form

* Use <%== instead of .html_safe in v2 form

* Update app/assets/javascripts/utilities/dynamicallyLoadScript.js

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-05-15 14:27:46 +02:00
..
additional_content_boxes Refactor ProfileImage (#5803) 2020-02-07 08:56:16 -05:00
admin/application Last general linting sweep (#1947) 2019-03-02 07:47:14 -08:00
api/v0 [deploy] Fix podcast pagination client/API mismatch (#7375) 2020-04-28 10:07:36 -04:00
articles Fix Runkit tags not being activated when comment is added (#6767) 2020-05-15 14:27:46 +02:00
badges Added title attribute for Badges (#5201) 2019-12-27 10:40:29 -05:00
blocks Add SRI to script tags where applicable (#2153) 2019-03-22 14:14:59 -04:00
chat_channel_memberships [deploy] 🚀 Feature: Ability to search discoverable channels and send request to join (#7385) 2020-05-11 09:29:15 -04:00
chat_channels Refactor jbuilder (#7411) 2020-04-24 12:49:12 +02:00
classified_listings [deploy] Home Page Feed redesign + top comments (#7579) 2020-05-12 07:57:57 -05:00
comments [deploy] Fixes some html_safe in Articles (#6500) 2020-05-13 09:22:52 -05:00
credits [deploy] Fix settings billing section and other profile improvements (#7525) 2020-04-27 16:59:03 +02:00
dashboards Sanitizing and rendering html entities in article title (#7593) 2020-05-15 08:04:43 -04:00
devise [deploy] Authentication refactoring: add available and enabled providers (#7505) 2020-04-28 16:16:28 +02:00
doorkeeper Add rel noopener to links opening in a separate tab (#7235) 2020-04-12 17:04:07 +02:00
email_subscriptions Removal of morrrre hardcoded dev.to links (#7390) 2020-04-21 11:50:18 +02:00
events [deploy] Configurable meta keywords (#7591) 2020-04-29 09:40:06 -04:00
feedback_messages [deploy] Refactor to create a helper for the mailer links (#7502) 2020-04-27 09:18:16 -04:00
fields Ignore unused users columns (#6954) [deploy] 2020-04-01 10:11:40 +02:00
followings Refactor jbuilder (#7411) 2020-04-24 12:49:12 +02:00
github_repos Refactoring GitHub Repos functionality - step 1 (#7764) 2020-05-12 13:48:19 +02:00
homepage Stories views reorganization (#1317) 2018-12-13 14:54:02 -05:00
html_variants Campaign settings (#6141) [deploy] 2020-02-18 11:02:09 -06:00
internal Add twitter hashtag to the site config (#7573) 2020-05-14 12:41:15 +02:00
kaminari/internal Refactor internal mods page (#7002) 2020-04-03 10:41:09 -04:00
layouts Generalize internal logo (#7701) 2020-05-07 16:33:04 -04:00
liquid_embeds Fix style issues on liquid tag embed page (#6445) [deploy] 2020-03-04 10:40:34 -05:00
liquids Fix Runkit tags not being activated when comment is added (#6767) 2020-05-15 14:27:46 +02:00
mailers [deploy] 🚀 Feature: Ability to search discoverable channels and send request to join (#7385) 2020-05-11 09:29:15 -04:00
moderations Remove stats from /mod (#7581) 2020-04-28 18:03:08 -04:00
notifications NOT MERGE Add tabs to Crayons and to the notifications page (#7737) 2020-05-14 11:38:57 +02:00
onboardings [deploy] Add generalized community name and description to onboarding slides (#7725) 2020-05-08 14:45:24 -04:00
organizations [deploy] Home Page Feed redesign + top comments (#7579) 2020-05-12 07:57:57 -05:00
pages NOT MERGE Add tabs to Crayons and to the notifications page (#7737) 2020-05-14 11:38:57 +02:00
partnerships [deploy] Configure the community_member_label (rails console update required) (#7564) 2020-04-28 16:56:29 +02:00
podcast_episodes [deploy] Configurable meta keywords (#7591) 2020-04-29 09:40:06 -04:00
podcasts Validate file uploads client-side (#6737) 2020-03-24 09:21:49 +01:00
pro_memberships Replace DEV with the community name... almost everywhere (#7211) 2020-04-10 17:03:16 +02:00
reading_list_items [deploy] Remove ALL Algolia Code (#7577) 2020-04-29 10:11:57 -05:00
response_templates Refactor jbuilder (#7411) 2020-04-24 12:49:12 +02:00
service_worker [deploy] Fix short-circuiting condition for caching of the shell in service worker 🔧 🐢 (#6960) 2020-05-08 10:15:48 -04:00
shared [deploy] Authentication refactoring: cleanups (#7576) 2020-04-29 10:33:30 -04:00
shell [deploy] Add comment subscription component to article page (#7205) 2020-05-05 12:50:30 -04:00
sitemaps Replaced ApplicationConfig with app_url in views (#7708) 2020-05-08 13:19:29 +03:00
social_previews Refactor classified listing social previews (#7679) 2020-05-06 14:00:09 -04:00
stories [deploy] Home Page Feed redesign + top comments (#7579) 2020-05-12 07:57:57 -05:00
tags [deploy] Configurable meta keywords (#7591) 2020-04-29 09:40:06 -04:00
twitch_live_streams Embed Twitch Live Streaming (#2591) 2019-04-29 18:11:53 -04:00
users Fix profile page rendering when a username contains spaces (#7787) 2020-05-13 08:37:50 +02:00
video_chats [deploy] Add codenames proof-of-concept to /connect (#7553) 2020-04-27 19:19:12 -04:00
videos [deploy] Configurable meta keywords (#7591) 2020-04-29 09:40:06 -04:00