docbrown/app/controllers/github_repos_controller.rb
rhymes 81fff248dd
Refactoring GitHub Repos functionality - step 1 (#7764)
* Rename find_or_create to upsert and improve validation and testing

* Add User.authenticated_through?

* Refactor settings/integrations

* Refactor profile github repositories rendering

* Refactor repos fetching

* Only fetch a single repo and improve error messages

* Remove unused code

* Cleanups

* Fix specs

* Remove trailing whitespace

* Fix spec

* Trigger Travis
2020-05-12 13:48:19 +02:00

83 lines
2.4 KiB
Ruby

class GithubReposController < ApplicationController
before_action :authenticate_user!
after_action :verify_authorized
def index
authorize GithubRepo
known_repositories_ids = current_user.github_repos.featured.distinct.pluck(:github_id_code)
# NOTE: this will invoke autopaging, by issuing multiple calls to GitHub
# to fetch all of the user's repositories. This could eventually become slow
@repos = fetch_repositories_from_github(known_repositories_ids)
rescue Octokit::Unauthorized => e
render json: { error: "GitHub Unauthorized: #{e.message}", status: 401 }, status: :unauthorized
end
def update_or_create
authorize GithubRepo
params[:github_repo] = JSON.parse(params[:github_repo])
fetched_repo = fetch_repository_from_github(repo_params[:github_id_code])
unless fetched_repo
render json: { error: "GitHub repository not found", status: 404 }, status: :not_found
return
end
repo = GithubRepo.upsert(current_user, fetched_repo_params(fetched_repo))
current_user.touch(:github_repos_updated_at)
if repo.valid?
render json: { featured: repo.featured }
else
render json: { error: repo.errors.full_messages, status: 422 }, status: :unprocessable_entity
end
end
private
# TODO: use Github::UserClient or something
def create_octokit_client
current_user_token = current_user.identities.where(provider: "github").last.token
Octokit::Client.new(access_token: current_user_token)
end
def fetch_repositories_from_github(known_repositories_ids)
client = create_octokit_client
client.repositories(visibility: :public).map do |repo|
repo.featured = known_repositories_ids.include?(repo.id)
repo
end.sort_by(&:name)
end
def fetch_repository_from_github(repository_id)
client = create_octokit_client
client.repository(repository_id)
rescue Octokit::NotFound
nil
end
def fetched_repo_params(fetched_repo)
{
github_id_code: fetched_repo.id,
name: fetched_repo.name,
description: fetched_repo.description,
language: fetched_repo.language,
fork: fetched_repo.fork,
url: fetched_repo.html_url,
bytes_size: fetched_repo.size,
watchers_count: fetched_repo.watchers,
stargazers_count: fetched_repo.stargazers_count,
featured: repo_params[:featured],
info_hash: fetched_repo.to_hash
}
end
def repo_params
permitted_attributes(GithubRepo)
end
end