No description
Find a file
Jeremy Friesen 816e92e549
Configurable weighted feed strategy (#15240)
* AB Test for Feed Strategy

Adding the plumbing for performing AB Tests on the feed strategy.

You can add the environment variable `AB_TEST_SERVICE_FEED_STRATEGY` to
specify the field test to run.

For example, from the forem application home directory you can run the
following to force a strategy for all users:

```console
AB_TEST_SERVICE_FEED_STRATEGY=original bin/start
```

Forcing the strategy can significantly help with quality assurance testing.

* Adding configurable weighted feed strategy

I wrote about this exploration on [DEV.to][1].  This particular
implementation provides significant configuration options for A/B
testing.

At it's core this `Articles::Feeds::WeightedQueryStrategy` provides a
means to query articles that are relevant to the user.  The
configuration helps us test and refine those values.

Further more this implementation introduces the idea of some common
interfaces for feed strategies.  I'm not happy with the naming
convention but we can work to change that.

This even hints at a mechanism for administrators to configure.

Related to forem/rfcs#314, as I work towards understanding the feed
algorithm. And #15180

[1]:https://dev.to/jeremyf/practicing-postgresql-and-postulating-improvements-5m

* Renaming AbTestService to AbExperiment

I'm loath to end any production class's filename with "test".  I don't
want minitest or rspec coming along and attempting to "test" that file.
In addition, I find that Experiment better describes the concept.

Also, per conversations with Michael K, we favor nouns objects to go
in app/models and verb objects to go in app/services.  That's a great
separation.

* Factoring AbExperiment into a Controller concern

I wish this could be a stand-alone module but the implementation of
field test has cases that require controller context.

* Sanitizing configurable weighted strategy cases

* Minor refactoring of coding structure

* Renaming parameter for clarity

* Renaming variable to avoid confusion

Prior to the commit, `env` is a controller variable.  The injected `env`
variable didn't collide, but did create just a bit of confusion.

With this change, I'm trying to disentangle from that variable.

* Factoring AbExperiment away from mixin concern

Per discussion with Michael K, we both agree that we do not like
controller concern mixins.  They can quickly complicate the legibility
of any given codebase.

This refactor provides a common and simplified interface for a Plain Old
Ruby Object (PORO) that accounts for the implementation considerations
of the underlying "field_test" controller method.

* Adding Datadog.tracer.trace around feed actions

* Adding featured_article_factor

Prior to this commit, there was no consideration for how moderators
engage with an article.  This is a first nudge towards that effort.

* Removing spec

Add a spec that says yes or no we're feature testing something seems
fragile.  Namely, why are we wanting to assert that as a truism.

* Helping ensure we're "tracing" the same things

From the code comment:

> Hey, why the to_a you say?  Because the
> LargeForemExperimental has already done this.  But the
> weighted strategy has not.  I also don't want to alter the
> weighted query implementation as it returns a lovely
> ActiveRecord::Relation.  So this is a concession.

* Addressing parameters for tracing function

* For weight feed query only count positive tags

A user assigns explicit points to the tags that they do or do not want
to see.  This change treats the negative explicit_points as an indicator
that they don't want to see the tag.

* Adding weighted factor for privileged user reactions

* Updating comments to better clarify

* Adding additional constraint for published_at

* Updating documentation and adding logger

* Adding documentation concerning method call

* Upping logging level for experiments

See conversations in https://github.com/forem/forem/pull/15240

* Adding group by clauses to appease postgres configs

* Injecting relevant scoring method's joins

Prior to this commit, we included all of the joins regardless of the
scoring methods chosen.  With this commit, we only inject joins that are
used with the commit.

What this would allow us to do is to then have some pre-cooked scoring
methods but not turn them on.  Or to turn off the more expensive scoring
methods.

* Adding feature flag for feed strategy experiment
2021-11-29 10:46:56 -05:00
.buildkite Removes this dupe container block since we are going to run this pipeline (#11506) 2020-11-19 15:05:49 -06:00
.gems Bugfix for #7663 and refactor of container setup (#7747) 2020-05-28 12:11:51 -05:00
.github Adding program language lens for Code Ownership (#15431) 2021-11-22 11:28:35 -05:00
.husky [15 min fix] Updated husky package and configuration/pre-commit hook (#14346) 2021-07-27 15:39:00 -04:00
.vscode Added the MDX extension for VS Code. (#12816) 2021-02-25 10:22:18 +01:00
.yarn/releases Update to latest yarn version (#10441) 2020-09-28 13:24:35 -04:00
app Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
bin HTML tag and attribute matcher (#15091) 2021-11-03 11:27:12 +07:00
config Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
cypress Rename feeds + update feeds' tabs UI (#15435) 2021-11-29 07:51:24 +00:00
datadog Declare DD_VERSION in prerun.sh 2nd try (#13258) 2021-04-05 17:10:46 -04:00
db ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
lib Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
log Initial commit 2018-02-28 16:11:08 -05:00
public Make podcast-playback to be controllable via keyboard (#14139) 2021-08-20 12:45:53 +02:00
scripts Add real release version into the running code (#14870) 2021-10-04 09:35:20 -04:00
spec Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
vendor Bump view_component from 2.44.0 to 2.45.0 (#15493) 2021-11-29 07:15:12 -07:00
.codeclimate.yml Upgrade to Ruby 3.0.2 (#12103) 2021-08-25 14:26:33 -04:00
.dockerignore Remove docs from repo ✂✂✂ (#14579) 2021-08-23 17:23:42 -04:00
.editorconfig Export articles/posts (#576) 2018-11-21 11:13:36 -05:00
.env_sample ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
.erb-lint.yml Upgrade Rails to 6.1.3.1 (#11333) 2021-04-05 10:39:48 -04:00
.eslintignore Remove non application files from frontend code coverage (#11752) 2020-12-04 20:00:20 -05:00
.eslintrc.js Disabled 'no default exports' rule for Storybook files and Stimulus controllers (#13032) 2021-03-17 21:29:39 -04:00
.gitattributes Enable union merges for translations (#15061) 2021-10-14 10:51:09 +07:00
.gitignore Add .pryrc to gitignore (#14844) 2021-09-28 18:03:02 +02:00
.gitpod.dockerfile Made GitHub CLI install permanent in Gitpod (#14787) 2021-09-21 15:27:39 -04:00
.gitpod.yml Gitpod: wait for postgresql to be listening before startup (#15429) 2021-11-19 11:35:46 -06:00
.lintstagedrc.js Create .lintstagedrc.js (#15209) 2021-10-27 12:40:59 -04:00
.nvmrc Update to use Node 14.x (#13136) 2021-03-29 11:27:20 -04:00
.postcssrc.yml Initial commit 2018-02-28 16:11:08 -05:00
.prettierignore Use yarn 1.21.1 (#5786) 2020-02-05 17:04:06 -05:00
.prettierrc.json Extracting prettier config (#10847) 2020-10-14 22:28:31 -04:00
.rspec [deploy] Spec Speedup: Use Knapsack to Run Parallel Builds (#8390) 2020-06-11 10:27:11 -05:00
.rubocop.yml Rubocop fixes (#14868) 2021-09-30 13:22:09 -04:00
.rubocop_todo.yml ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
.ruby-version Upgrade to Ruby 3.0.2 (#12103) 2021-08-25 14:26:33 -04:00
.simplecov Remove resource_admin dashboards (Administrate) (#11792) 2020-12-08 12:38:13 -06:00
.slugignore Remove docs from repo ✂✂✂ (#14579) 2021-08-23 17:23:42 -04:00
.travis.yml Add assets precompile check to the miscellaneous tasks node (#15280) 2021-11-03 18:09:44 -05:00
.yardopts Adds Ruby source code documentation to docs.dev.to (#2656) 2019-05-02 13:50:58 -04:00
.yarnclean Remove assets folder from .yarnclean (#13869) 2021-05-27 10:39:59 -04:00
.yarnrc Update to latest yarn version (#10441) 2020-09-28 13:24:35 -04:00
babel.config.js Added the babel-inline-react-svg plugin (#15461) 2021-11-23 12:24:50 -05:00
CHANGELOG.md Add support for versioned releases (#13750) 2021-07-28 10:10:33 -04:00
CODE_OF_CONDUCT.md Replace ban/banned with suspend/suspended in user facing text (#5816) [deploy] 2020-02-10 10:12:53 -05:00
config.ru Upgrade Rails to 6.1.3.1 (#11333) 2021-04-05 10:39:48 -04:00
container-compose.yml Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606) 2021-05-03 11:09:45 -04:00
Containerfile Upgrade to Ruby 3.0.2 (#12103) 2021-08-25 14:26:33 -04:00
CONTRIBUTING.md Fix broken links (#14588) 2021-08-24 16:59:56 -04:00
customJsDomEnvironment.js Bump jsdom from 16.7.0 to 18.0.0 (#15047) 2021-10-12 14:32:30 -06:00
cypress.dev.json Cleaning Test Runs for End to End (E2E) Tests (#12143) 2021-01-29 13:34:01 +01:00
cypress.json add retries for cypress ci tests (#14241) 2021-07-15 12:34:30 +01:00
docker-compose.yml Update docker-compose.yml file to permit login (#13792) 2021-05-24 20:03:36 -05:00
Dockerfile Bugfix for #7663 and refactor of container setup (#7747) 2020-05-28 12:11:51 -05:00
empty-module.js Initial commit 2018-02-28 16:11:08 -05:00
Gemfile Bump view_component from 2.44.0 to 2.45.0 (#15493) 2021-11-29 07:15:12 -07:00
Gemfile.lock Bump view_component from 2.44.0 to 2.45.0 (#15493) 2021-11-29 07:15:12 -07:00
gitpod-init.sh Made GitHub CLI install permanent in Gitpod (#14787) 2021-09-21 15:27:39 -04:00
Guardfile Upgrade rubocop* packages to the latest version and fix violations (#11972) 2020-12-21 18:29:43 +01:00
jest.config.js Bump jsdom from 16.7.0 to 18.0.0 (#15047) 2021-10-12 14:32:30 -06:00
jsconfig.json Added the babel-inline-react-svg plugin (#15461) 2021-11-23 12:24:50 -05:00
LICENSE.md Ran all markdown files through prettier to fix a handful. (#4599) 2019-10-28 08:20:53 -04:00
package.json Added the babel-inline-react-svg plugin (#15461) 2021-11-23 12:24:50 -05:00
postcss.config.js Suppress Postcss warnings & Re-enable Benhalpern deploy (#11521) 2020-11-20 11:27:49 -05:00
Procfile remove rake jobs:work references from code (#6082) [deploy] 2020-02-14 15:18:08 -05:00
Procfile.dev Adapt dev env to run on a remote box (#8232) 2020-06-18 13:01:49 +02:00
Procfile.dev-hot Initial commit 2018-02-28 16:11:08 -05:00
Rakefile Remove fix-db-schema-conflicts gem (#12432) 2021-01-26 10:52:38 -05:00
README.md Remove rhymes from the Core Team (#15167) 2021-10-22 20:51:40 +02:00
release-tasks.sh Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606) 2021-05-03 11:09:45 -04:00
SECURITY.md [deploy] 🚀 Feature: Chat channel membership manager component (#8945) 2020-07-20 08:08:31 -04:00
svgo.config.js svgo: update configuration for 2.4 syntax (#14524) 2021-08-17 18:54:10 +02:00
testSetup.js workaround getComputedStyle issues in all jest tests (#14737) 2021-09-21 10:52:54 +01:00
yarn.lock Added the babel-inline-react-svg plugin (#15461) 2021-11-23 12:24:50 -05:00


Forem 🌱

For Empowering Community

ruby version rails version Travis Status for forem/forem Code Climate maintainability Code Climate technical debt CodeTriage badge Dependabot Badge GitPod badge Netlify badge GitHub code size in bytes GitHub commit activity GitHub issues ready for dev Honeybadger badge Knapsack Pro Parallel CI builds for dev.to

Welcome to the Forem codebase, the platform that powers dev.to. We are so excited to have you. With your help, we can build out Forems usability, scalability, and stability to better serve our communities.

What is Forem?

Forem is open source software for building communities. Communities for your peers, customers, fanbases, families, friends, and any other time and space where people need to come together to be part of a collective. See our announcement post for a high-level overview of what Forem is.

dev.to (or just DEV) is hosted by Forem. It is a community of software developers who write articles, take part in discussions, and build their professional profiles. We value supportive and constructive dialogue in the pursuit of great code and career growth for all members. The ecosystem spans from beginner to advanced developers, and all are welcome to find their place within our community. ❤️

Table of Contents

Community

For a place to have open discussions on features, voice your ideas, or get help with general questions please visit our community at forem.dev.

Contributing

We encourage you to contribute to Forem! Please check out the Contributing to Forem guide for guidelines about how to proceed.

Getting Started

This section provides a high-level quick start guide. If you're looking for a more thorough installation guide (for example with macOS, you'll want to refer to our complete Developer Documentation.

We run on a Rails backend, and we are currently transitioning to a Preact-first frontend.

A more complete overview of our stack is available in our docs.

Prerequisites

Local

Containers

Linux

OS X

Installation Documentation

Please see our installation guides, such as the one for macOS.

Developer Documentation

Check out our dedicated docs page for more technical documentation.

Core team

Vulnerability disclosure

Forem is the open source software which powers DEV.

We welcome security research on DEV under the terms of our vulnerability disclosure policy.

Acknowledgments

Thank you to the Twemoji project for the usage of their emojis.

License

This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. Please see the LICENSE file in our repository for the full text.

Like many open source projects, we require that contributors provide us with a Contributor License Agreement (CLA). By submitting code to the Forem project, you are granting us a right to use that code under the terms of the CLA.

Our version of the CLA was adapted from the Microsoft Contributor License Agreement, which they generously made available to the public domain under Creative Commons CC0 1.0 Universal.

Any questions, please refer to our license FAQ doc or email yo@dev.to.


Sloan, the sloth mascot
Happy Coding ❤️

⬆ Back to Top