* Add dual booting logic to Gemfile This might be helpful for the Rails 6.0 upgrade project. * Add more than one gemfile to Travis' configuration We want to see how the application behaves with more than one Rails versions: - Gemfile -> Rails 5.2 - Gemfile.next -> Rails 6.0 This will help us figure out what needs to be addressed before migrating to Rails 6.0. If you want to read more about this technique (dual booting) you can check out this page: https://www.fastruby.io/blog/upgrade-rails/dual-boot/dual-boot-with-rails-6-0-beta.html * Fix joins * Upgrade Gemfile.next.lock * Make sure we're installing the correct versions of gems * Add Rails 6 notes * Update rubocop in Gemfile.next.lock * Fix organization spec * Fix page_views_spec * Add Rails 6 and run rails app:update * Remove some tricks * Remove Gemfile.next for now * Fix .content_type deprecation * Fix deprecation of .where.not NAND/NOR behavior * Fix deprecation of parameterized emails * Fix specs * Remove next flag for now * Fix spec (hopefully) * Add wait_for_javascript * Fix spec, thanks @maestromac! * Try without wait for javascript hack * Remove unnecessary bin/update * Remove file that snuck in the rebase * Update the vendored gems * Replace migrate+db:setup with db:prepare * Update vendored gems * Fix Gemfile.lock and update vendored stuff * Fix Gemfile.lock to be the same as master's minus the changes Co-authored-by: rhymes <rhymesete@gmail.com>
110 lines
4.2 KiB
Ruby
110 lines
4.2 KiB
Ruby
RSpec.shared_examples "GET /api/analytics/:endpoint authorization examples" do |endpoint, params|
|
|
let(:user) { create(:user) }
|
|
let(:api_token) { create(:api_secret, user: user) }
|
|
let(:pro_user) { create(:user, :pro) }
|
|
let(:pro_api_token) { create(:api_secret, user: pro_user) }
|
|
let(:pro_org_member) { create(:user, :pro, :org_member) }
|
|
let(:org_member_token) { create(:api_secret, user: pro_org_member) }
|
|
let(:org) { pro_org_member.organizations.first }
|
|
let(:article) { create(:article, user: user) }
|
|
let(:pro_user_article) { create(:article, user: pro_user) }
|
|
let(:pro_org_article) { create(:article, user: pro_user, organization: org) }
|
|
|
|
context "when an invalid token is given" do
|
|
before { get "/api/analytics/#{endpoint}?#{params}", headers: { "api-key" => "abadskajdlsak" } }
|
|
|
|
it "renders an error message: 'unauthorized' in JSON" do
|
|
expect(response.parsed_body).to include("error" => "unauthorized")
|
|
end
|
|
|
|
it "has a status 401" do
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context "when a valid token is given but the user is not a pro" do
|
|
before { get "/api/analytics/#{endpoint}?#{params}", headers: { "api-key" => api_token.secret } }
|
|
|
|
it "renders an error message: 'unauthorized' in JSON" do
|
|
expect(response.parsed_body).to include("error" => "unauthorized")
|
|
end
|
|
|
|
it "has a status 401" do
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context "when a valid token is given and the user is a pro" do
|
|
before { get "/api/analytics/#{endpoint}?#{params}", headers: { "api-key" => pro_api_token.secret } }
|
|
|
|
it "renders JSON as the content type" do
|
|
expect(response.media_type).to eq "application/json"
|
|
end
|
|
end
|
|
|
|
context "when attempting to view organization analytics without belonging to the organization" do
|
|
before do
|
|
get "/api/analytics/#{endpoint}?organization_id=#{org.id}#{params}", headers: { "api-key" => pro_api_token.secret }
|
|
end
|
|
|
|
it "renders an error message: 'unauthorized' in JSON" do
|
|
expect(response.parsed_body).to include("error" => "unauthorized")
|
|
end
|
|
|
|
it "has a status 401" do
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context "when attempting to view organization analytics and being a member of the organization" do
|
|
before do
|
|
path = "/api/analytics/#{endpoint}?organization_id=#{pro_org_member.organization_ids.first}#{params}"
|
|
get path, headers: { "api-key" => org_member_token.secret }
|
|
end
|
|
|
|
it "renders JSON as the content type" do
|
|
expect(response.media_type).to eq "application/json"
|
|
end
|
|
end
|
|
|
|
context "when attempting to view another organization analytics and not belonging to that organization" do
|
|
it "responds with status 401 unauthorized" do
|
|
org = create(:organization)
|
|
get "/api/analytics/#{endpoint}?organization_id=#{org.id}#{params}", headers: { "api-key" => org_member_token.secret }
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context "when attempting to view someone else's article analytics" do
|
|
it "responds with status 401 unauthorized" do
|
|
get "/api/analytics/#{endpoint}?article_id=#{article.id}#{params}"
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context "when viewing as current user" do
|
|
it "responds with status 200 OK" do
|
|
sign_in pro_user
|
|
get "/api/analytics/#{endpoint}?#{params}"
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
end
|
|
|
|
context "when viewing your own single article's analytics" do
|
|
it "responds with status 200 OK" do
|
|
sign_in pro_user
|
|
get "/api/analytics/#{endpoint}?article_id=#{pro_user_article.id}#{params}"
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
end
|
|
|
|
context "when viewing your own organizaiton's single article's analytics" do
|
|
it "responds with status 200 OK" do
|
|
org_param = "&organization_id=#{pro_org_article.organization.id}"
|
|
|
|
sign_in pro_org_member
|
|
get "/api/analytics/#{endpoint}?article_id=#{pro_org_article.id}#{params}#{org_param}"
|
|
expect(response).to have_http_status(:ok)
|
|
end
|
|
end
|
|
end
|