* Add dual booting logic to Gemfile This might be helpful for the Rails 6.0 upgrade project. * Add more than one gemfile to Travis' configuration We want to see how the application behaves with more than one Rails versions: - Gemfile -> Rails 5.2 - Gemfile.next -> Rails 6.0 This will help us figure out what needs to be addressed before migrating to Rails 6.0. If you want to read more about this technique (dual booting) you can check out this page: https://www.fastruby.io/blog/upgrade-rails/dual-boot/dual-boot-with-rails-6-0-beta.html * Fix joins * Upgrade Gemfile.next.lock * Make sure we're installing the correct versions of gems * Add Rails 6 notes * Update rubocop in Gemfile.next.lock * Fix organization spec * Fix page_views_spec * Add Rails 6 and run rails app:update * Remove some tricks * Remove Gemfile.next for now * Fix .content_type deprecation * Fix deprecation of .where.not NAND/NOR behavior * Fix deprecation of parameterized emails * Fix specs * Remove next flag for now * Fix spec (hopefully) * Add wait_for_javascript * Fix spec, thanks @maestromac! * Try without wait for javascript hack * Remove unnecessary bin/update * Remove file that snuck in the rebase * Update the vendored gems * Replace migrate+db:setup with db:prepare * Update vendored gems * Fix Gemfile.lock and update vendored stuff * Fix Gemfile.lock to be the same as master's minus the changes Co-authored-by: rhymes <rhymesete@gmail.com>
145 lines
6.9 KiB
Ruby
145 lines
6.9 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "NotificationSubscriptions", type: :request do
|
|
let(:user) { create(:user) }
|
|
let(:other_user) { create(:user) }
|
|
let(:article) { create(:article, :with_notification_subscription, user: user) }
|
|
let(:other_article) { create(:article, :with_notification_subscription, user: other_user) }
|
|
let(:headers) { { Accept: "application/json" } }
|
|
let(:comment) { create(:comment, commentable: article, user: user) }
|
|
let(:parent_comment_by_og) { create(:comment, commentable: article, user: user) }
|
|
let(:child_of_parent_by_other) { create(:comment, commentable: article, user: other_user, ancestry: parent_comment_by_og.id.to_s) }
|
|
let(:child_of_child_by_og) { create(:comment, commentable: article, user: user, ancestry: "#{parent_comment_by_og.id}/#{child_of_parent_by_other.id}") }
|
|
let(:child_of_child_of_child_by_other) { create(:comment, commentable: article, user: other_user, ancestry: "#{parent_comment_by_og.id}/#{child_of_parent_by_other.id}/#{child_of_child_by_og.id}") }
|
|
let(:child_of_child_of_child_by_og) { create(:comment, commentable: article, user: user, ancestry: "#{parent_comment_by_og.id}/#{child_of_parent_by_other.id}/#{child_of_child_by_og.id}/#{child_of_child_by_other.id}") }
|
|
let(:child_of_child_by_other) { create(:comment, commentable: article, user: other_user, ancestry: "#{parent_comment_by_og.id}/#{child_of_parent_by_other.id}") }
|
|
let(:child2_of_child_of_child_by_og) { create(:comment, commentable: article, user: user, ancestry: "#{parent_comment_by_og.id}/#{child_of_parent_by_other.id}/#{child_of_child_by_other.id}") }
|
|
let(:parent_comment_by_other) { create(:comment, commentable: article, user: other_user) }
|
|
|
|
describe "#show or GET /notification_subscriptions/:notifiable_type/:notifiable_id" do
|
|
context "when signed in" do
|
|
before { sign_in user }
|
|
|
|
it "returns a JSON response" do
|
|
get "/notification_subscriptions/Article/#{article.id}",
|
|
headers: headers
|
|
expect(response.media_type).to eq "application/json"
|
|
end
|
|
|
|
it "returns the correct subscription boolean as JSON" do
|
|
get "/notification_subscriptions/Article/#{article.id}",
|
|
headers: headers
|
|
expect(JSON.parse(response.body)["config"]).to eq "all_comments"
|
|
end
|
|
|
|
it "returns the correct subscription boolean as JSON if unsubscribed" do
|
|
article.notification_subscriptions.first.delete
|
|
get "/notification_subscriptions/Article/#{article.id}",
|
|
headers: headers
|
|
expect(JSON.parse(response.body)["config"]).to eq "not_subscribed"
|
|
end
|
|
end
|
|
|
|
it "returns a JSON response 'null' if there is no logged in user" do
|
|
get "/notification_subscriptions/Article/#{article.id}", headers: headers
|
|
expect(response.body).to eq "null"
|
|
expect(response.media_type).to eq "application/json"
|
|
end
|
|
end
|
|
|
|
describe "#upsert or POST /notification_subscriptions/:notifiable_type/:notifiable_id" do
|
|
it "returns 404 if there is no logged in user" do
|
|
expect do
|
|
post "/notification_subscriptions/Article/#{article.id}",
|
|
headers: headers,
|
|
params: { config: "all_comments" }
|
|
end.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
|
|
context "when sent as a JSON request with the correct params" do
|
|
before { sign_in user }
|
|
|
|
it "completes a proper subscription" do
|
|
post "/notification_subscriptions/Article/#{other_article.id}",
|
|
headers: headers,
|
|
params: { currently_subscribed: "false" }
|
|
subscription = NotificationSubscription.last
|
|
expect(subscription.user_id).to eq user.id
|
|
expect(subscription.notifiable_id).to eq other_article.id
|
|
expect(subscription.notifiable_type).to eq "Article"
|
|
end
|
|
|
|
it "removes a previous subscription" do
|
|
subscription = article.notification_subscriptions.first
|
|
post "/notification_subscriptions/Article/#{article.id}",
|
|
headers: headers,
|
|
params: { config: "not_subscribed" }
|
|
|
|
expect { subscription.reload }.to raise_error ActiveRecord::RecordNotFound
|
|
end
|
|
|
|
it "updates the article.receive_notifications column correctly if the current_user is the author" do
|
|
post "/notification_subscriptions/Article/#{article.id}",
|
|
headers: headers,
|
|
params: { config: "not_subscribed" }
|
|
expect(article.reload.receive_notifications).to eq false
|
|
end
|
|
|
|
it "updates the comment.receive_notifications column correctly if the current_user is the commenter" do
|
|
post "/notification_subscriptions/Comment/#{comment.id}",
|
|
headers: headers,
|
|
params: { config: "not_subscribed" }
|
|
expect(comment.reload.receive_notifications).to eq false
|
|
end
|
|
end
|
|
|
|
context "when an article has two parent comments by two different people" do
|
|
before do
|
|
sign_in user
|
|
parent_comment_by_og
|
|
parent_comment_by_other
|
|
end
|
|
|
|
it "mutes the parent comment" do
|
|
post "/notification_subscriptions/Comment/#{parent_comment_by_og.id}", headers: headers, params: { config: "not_subscribed" }
|
|
expect(parent_comment_by_og.reload.receive_notifications).to be false
|
|
end
|
|
|
|
it "does not mute the someone else's parent comment" do
|
|
post "/notification_subscriptions/Comment/#{parent_comment_by_og.id}", headers: headers, params: { config: "all_comments" }
|
|
expect(parent_comment_by_other.reload.receive_notifications).to be true
|
|
end
|
|
|
|
it "unmutes the parent comment if already muted" do
|
|
parent_comment_by_og.update(receive_notifications: false)
|
|
post "/notification_subscriptions/Comment/#{parent_comment_by_og.id}", headers: headers, params: { config: "all_comments" }
|
|
expect(parent_comment_by_og.reload.receive_notifications).to eq true
|
|
end
|
|
end
|
|
|
|
context "when an article has a single comment thread with multiple commenters" do
|
|
before do
|
|
child_of_child_of_child_by_og
|
|
child_of_child_of_child_by_other
|
|
child2_of_child_of_child_by_og
|
|
parent_comment_by_other
|
|
sign_in user
|
|
post "/notification_subscriptions/Comment/#{parent_comment_by_og.id}", headers: headers, params: { config: "not_subscribed" }
|
|
end
|
|
|
|
it "mutes all of the original commenter's comments in a single thread" do
|
|
user_ids_of_muted_comments = Comment.where(receive_notifications: false).pluck(:user_id)
|
|
expect(user_ids_of_muted_comments.uniq).to eq [user.id]
|
|
end
|
|
|
|
it "does not mute someone else's comment of a different thread" do
|
|
expect(parent_comment_by_other.receive_notifications).to be true
|
|
end
|
|
|
|
it "does not mute the other commenter's comments in the same thread" do
|
|
results = parent_comment_by_og.subtree.where(user: other_user).pluck(:receive_notifications)
|
|
expect(results.uniq).to eq [true]
|
|
end
|
|
end
|
|
end
|
|
end
|