docbrown/app/models/poll_vote.rb
Jeremy Friesen 2a26fa3538
Refactoring poll/vote/skip logic (#15441)
* Refactoring poll/vote/skip logic

Favor asking the poll if the user has already voted instead of relying
on the poll vote or skip to know about the implementation
details (e.g. should a poll vote know that there's a related model call
poll skipped?  likely not)

This refactor also tidies up the specs, for which there's quite a bit of
chatter.

Found via the `flay` gem.

* Adding method documentation

Also need to bump gitpod's build as it halted for the prior commit.
2021-11-29 10:52:32 -05:00

40 lines
1.3 KiB
Ruby

# @note When we destroy the related user, it's using dependent:
# :delete for the relationship. That means no before/after
# destroy callbacks will be called on this object.
#
# @note When we destroy the related poll, it's using dependent:
# :delete for the relationship. That means no before/after
# destroy callbacks will be called on this object.
class PollVote < ApplicationRecord
belongs_to :user
belongs_to :poll_option
belongs_to :poll
counter_culture :poll_option
counter_culture :poll
# In the future we'll remove this constraint if/when we allow multi-answer polls
validates :poll_id, presence: true, uniqueness: { scope: :user_id }
validates :poll_option_id, presence: true, uniqueness: { scope: :user_id }
validate :one_vote_per_poll_per_user
after_destroy :touch_poll_votes_count
after_save :touch_poll_votes_count
delegate :poll, to: :poll_option, allow_nil: true
private
def one_vote_per_poll_per_user
return false unless poll
return false unless poll.vote_previously_recorded_for?(user_id: user_id)
errors.add(:base, "cannot vote more than once in one poll")
end
def touch_poll_votes_count
poll.update_column(:poll_votes_count, poll.poll_votes.size)
poll_option.update_column(:poll_votes_count, poll_option.poll_votes.size)
end
end