docbrown/spec/requests/search_spec.rb
Anna Buianova 20e242af0d
Rubocop fixes (#20254)
* Fixed redundant alls for rubocop

* Fixed rubocop violations in spec/requests

* Fixed rubocop violations in spec/models

* Fixed Performance/MapMethodChain

* Fixed rubocop violations in spec/requests

* Revert changes to FastlyConfig::Update spec
2023-10-18 17:24:28 -04:00

282 lines
8.9 KiB
Ruby

require "rails_helper"
RSpec.describe "Search", :proper_status do
let(:authorized_user) { create(:user) }
describe "GET /search/tags" do
before do
sign_in authorized_user
end
it "returns nothing if there is no name parameter" do
get search_tags_path
expect(response.parsed_body["result"]).to be_empty
end
it "finds a tag by a partial name" do
tag = create(:tag, name: "elixir")
get search_tags_path(name: "eli")
expect(response.parsed_body["result"].first).to include("name" => tag.name)
end
end
describe "GET /search/listings" do
it "returns the correct keys" do
create(:listing)
get search_listings_path
expect(response.parsed_body["result"]).to be_present
end
it "supports the search params" do
listing = create(:listing)
get search_listings_path(
category: listing.category,
page: 0,
per_page: 1,
term: listing.title.downcase,
)
expect(response.parsed_body["result"].first).to include("title" => listing.title)
end
end
describe "GET /search/usernames" do
before do
sign_in authorized_user
end
it "returns nothing if there is no username parameter" do
get search_usernames_path
expect(response.parsed_body["result"]).to be_empty
end
it "finds a username by a partial username" do
user = create(:user, username: "Sloan")
get search_usernames_path(username: "slo")
expect(response.parsed_body["result"].first).to include("username" => user.username)
end
it "finds a username by a partial name" do
user = create(:user, name: "Sloan")
get search_usernames_path(username: "slo")
expect(response.parsed_body["result"].first).to include("username" => user.username)
end
end
describe "GET /search/feed_content" do
let(:homepage_params) { { class_name: "Article", sort_by: "published_at", sort_direction: "desc" } }
it "does not call Homepage::FetchArticles when class_name is Article with a search term", :aggregate_failures do
allow(Homepage::FetchArticles).to receive(:call)
get search_feed_content_path
expect(Homepage::FetchArticles).not_to have_received(:call)
get search_feed_content_path(class_name: "Article", search_fields: "keyword")
expect(Homepage::FetchArticles).not_to have_received(:call)
end
it "returns the correct keys", :aggregate_failures do
create(:article)
get search_feed_content_path(homepage_params)
expect(response.parsed_body["result"]).to be_present
end
it "parses published_at correctly", :aggregate_failures do
article = create(:article)
get search_feed_content_path(homepage_params.merge(published_at: { gte: article.published_at.iso8601 }))
expect(response.parsed_body["result"].first["id"]).to eq(article.id)
datetime = article.published_at + 1.minute
get search_feed_content_path(homepage_params.merge(published_at: { gte: datetime.iso8601 }))
expect(response.parsed_body["result"]).to be_empty
end
it "supports the user_id parameter" do
allow(Homepage::FetchArticles).to receive(:call)
get search_feed_content_path(homepage_params.merge(user_id: 1))
expect(Homepage::FetchArticles).to have_received(:call).with(hash_including(user_id: "1"))
end
it "supports the organization_id parameter" do
allow(Homepage::FetchArticles).to receive(:call)
get search_feed_content_path(homepage_params.merge(organization_id: 1))
expect(Homepage::FetchArticles).to have_received(:call).with(hash_including(organization_id: "1"))
end
it "supports the tag_names parameter" do
allow(Homepage::FetchArticles).to receive(:call)
get search_feed_content_path(homepage_params.merge(tag_names: %i[ruby]))
expect(Homepage::FetchArticles).to have_received(:call).with(hash_including(tags: %w[ruby]))
end
context "when searching for articles" do
it "calls Search::Article without a class_name" do
allow(Search::Article).to receive(:search_documents)
get search_feed_content_path
expect(Search::Article).to have_received(:search_documents)
end
it "calls Search::Article with class_name=Article" do
allow(Search::Article).to receive(:search_documents)
get search_feed_content_path(class_name: "Article")
expect(Search::Article).to have_received(:search_documents)
end
it "supports the search params", :aggregate_failures do
allow(Search::Article).to receive(:search_documents).and_call_original
article = create(:article)
get search_feed_content_path(
class_name: "Article", page: 0, per_page: 1, search_fields: article.title,
sort_by: :published_at, sort_direction: :desc
)
expect(response.parsed_body["result"].first["id"]).to eq(article.id)
expect(Search::Article).to have_received(:search_documents)
end
it "nullifies invalid sort directions" do
allow(Search::Article).to receive(:search_documents).and_call_original
article = create(:article)
get search_feed_content_path(
class_name: "Article", page: 0, per_page: 1, search_fields: article.title,
sort_by: :published_at, sort_direction: :invalid
)
expect(response.parsed_body["result"].first["id"]).to eq(article.id)
expect(Search::Article)
.to have_received(:search_documents)
.with(hash_including(sort_direction: nil))
end
end
context "when searching for comments" do
it "returns the correct keys for comments" do
create(:comment, body_markdown: "Ruby on Rails rocks!")
get search_feed_content_path(search_fields: "rails", class_name: "Comment")
expect(response.parsed_body["result"]).to be_present
end
it "supports the search params for comments" do
comment = create(:comment, body_markdown: "Ruby on Rails rocks!")
get search_feed_content_path(
search_fields: "rails",
class_name: "Comment",
page: 0,
per_page: 1,
)
expect(response.parsed_body["result"].first).to include("body_text" => comment.body_markdown)
end
end
context "when using searching for users" do
it "returns the correct keys", :aggregate_failures do
create(:user)
get search_feed_content_path(class_name: "User")
expect(response.parsed_body["result"]).to be_present
end
it "supports the search params" do
user = create(:user)
get search_feed_content_path(
class_name: "User", page: 0, per_page: 1, search_fields: user.name,
sort_by: :created_at, sort_direction: :desc
)
expect(response.parsed_body["result"].first["id"]).to eq(user.id)
end
end
context "when using searching for podcasts" do
it "returns the correct keys for podcasts" do
create(:podcast_episode, body: "DHH talks about how Ruby on Rails rocks!")
get search_feed_content_path(search_fields: "rails", class_name: "PodcastEpisode")
expect(response.parsed_body["result"]).to be_present
end
it "supports the search params for podcasts" do
podcast_episode = create(:podcast_episode, body: "DHH talks about how Ruby on Rails rocks!")
get search_feed_content_path(
search_fields: "rails",
class_name: "PodcastEpisode",
page: 0,
per_page: 1,
)
expect(response.parsed_body["result"].first).to include("body_text" => podcast_episode.body_text)
end
end
context "when using searching for tags" do
let!(:tag) { create(:tag, name: "webdev") }
it "returns the correct keys for tags" do
get search_feed_content_path(search_fields: "web", class_name: "Tag")
expect(response.parsed_body["result"]).to be_present
end
it "supports the search params for tags" do
get search_feed_content_path(
search_fields: "web",
class_name: "Tag",
page: 0,
per_page: 1,
)
expect(response.parsed_body["result"].first).to include("name" => tag.name)
end
end
end
describe "GET /search/reactions" do
let(:article) { create(:article) }
before do
sign_in authorized_user
create(:reaction, category: :readinglist, reactable: article, user: authorized_user)
end
it "returns the correct keys", :aggregate_failures do
get search_reactions_path
expect(response.parsed_body["result"]).to be_present
expect(response.parsed_body["total"]).to eq(1)
end
it "supports the search params" do
article.update_columns(title: "Title", cached_tag_list: "ruby, python")
get search_reactions_path(page: 0, per_page: 1, status: %w[valid], tags: %w[ruby], term: "title")
expect(response.parsed_body["result"].first["reactable"]).to include("title" => "Title")
end
end
end