docbrown/spec/requests/internal
Jacob Herrington 00dd84f9e1 Add a default message to badge award action (#5160)
* Add a default message to badge award action

Because:
 - The only badges routinely awarded manually use the same message
 - Right now, unfriendly/unsafe UI can result in an error notification

The only badges that are currently awarded manually (afaik) have the
message "Congrats!!!" so for the time being, if a message is not
supplied to the UI, it will simply use the "Congrats!!!" message as a
default.

That being said, I'm not totally convinced this message won't work for
the long term. Generally, if we are awarding badges by hand, I'd imagine
we'd want a specific message explaining why we are doing that, or just
be okay with "Congrats!"

After talking with Peter about it, the longer term goal should be to
move badge messages into the database so they can be modified in the app
and not hardcoded. That also make sense regarding the effort to
genericize the app eventually.

* Test Badge notifications
2019-12-19 10:38:57 -05:00
..
articles_spec.rb Create InternalPolicy (#4380) 2019-10-17 14:21:43 -04:00
badges_spec.rb Add a default message to badge award action (#5160) 2019-12-19 10:38:57 -05:00
broadcasts_spec.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
buffer_updates_spec.rb Move all internals request spec under internal namespace (#4495) [ci skip] 2019-10-21 16:38:06 -04:00
classified_listings_spec.rb CacheBuster refactoring (#4766) 2019-11-13 10:51:23 -05:00
comments_spec.rb Create InternalPolicy (#4380) 2019-10-17 14:21:43 -04:00
configs_spec.rb Add additional keys to site configuration (#4861) [deploy] 2019-11-20 10:58:10 -05:00
events_spec.rb Move all internals request spec under internal namespace (#4495) [ci skip] 2019-10-21 16:38:06 -04:00
feedback_messages_spec.rb Move all internals request spec under internal namespace (#4495) [ci skip] 2019-10-21 16:38:06 -04:00
growth_spec.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
moderator_logs_spec.rb Implement Moderators audit logs (#3449) 2019-10-23 10:30:45 -04:00
mods_spec.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
organizations_spec.rb Fix Rubocop lints (#5155) 2019-12-19 10:09:37 -05:00
permissions_spec.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
podcasts_spec.rb Fix deprecations in internal/podcasts_spec (#3597) [ci skip] 2019-08-01 11:07:17 -04:00
reactions_spec.rb Move all internals request spec under internal namespace (#4495) [ci skip] 2019-10-21 16:38:06 -04:00
tags_spec.rb Add GET /internal/tags/:id route back in (#3327) 2019-06-28 08:13:03 -04:00
tools_spec.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00
users_banish_spec.rb Move all internals request spec under internal namespace (#4495) [ci skip] 2019-10-21 16:38:06 -04:00
users_spec.rb Move all internals request spec under internal namespace (#4495) [ci skip] 2019-10-21 16:38:06 -04:00
welcome_spec.rb Add single resource admin concept (#5069) [deploy] 2019-12-11 13:17:55 -05:00