maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/services
History
Dwight Scott 71294dca14
OpenGraph fallback for Embeds (merge-by-any-core) (#17001) 
* WIP -- start of OpenGraph class that wraps MetaInspector gem

* use properties method instead of hash

* Update app/services/open_graph.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/open_graph.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/open_graph.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/open_graph.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/open_graph.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/open_graph.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* address PR feedback

* adding some specs

* gem vendor cache

* more specs

* lock metainspector gem to 5.11

* Update app/services/open_graph.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* WIP -- start of incorporating the open graph into the view

* regex match anything

* Update app/liquid_tags/open_graph_tag.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Refactors and Improvements

* build UI (some wonkiness; see loom)

* UI improvements

* add hyperlink to embed url

* display site_name conditionally

* Make PR review changes; implement A-tag fallback for OG

* Address PR review comments

* Fix failing spec

* deleted superfluous assignment; switched filename annotations off

* nudge Travis

* Address PR feedback

* attempting to apply custom styles

* update specs

* update specs

* add favicon if exists

* remove site-name method

* styling changes ✨

* nudge Travis

* PR review comments

* keep border around A-tag fallback

* use preferred description

* remove www prefix from url

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Arit Amana <msarit@gmail.com>
2022-04-04 15:31:38 -04:00
..
admin Display analytics up to yesterday instead of today (#17064) 2022-04-04 15:17:32 -04:00
articles Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
audit Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
authentication Prevent banished users from updating their profiles (#16122) 2022-01-17 10:54:02 -05:00
badges Award badges for github commits with various milestones (#14381) 2022-03-31 12:46:50 -04:00
broadcasts/welcome_notification Login with Google (#15986) 2022-01-13 10:25:52 -06:00
color Spelling (#15702) 2021-12-07 06:59:10 -07:00
credits Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
discover Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
edge_cache ✂✂✂ Remove events (#15062) 2021-10-15 09:31:08 -04:00
exporter Create Settings::SMTP (#13943) 2021-06-14 10:29:43 -04:00
fastly_config Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
feeds Only fetch RSS of users who can create articles (#16766) 2022-03-04 14:06:38 -05:00
follows Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
giphy
github Implement Unified Embeds for Github Repo, Issue, Pull-Request and Comment URLs (#16422) 2022-02-07 16:38:43 -05:00
homepage Extracting duplicate logic (#16035) 2022-01-10 15:19:04 -05:00
html Remove line break after linking username mentions (#15788) 2021-12-16 10:39:07 -06:00
images Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
listings ListingsToolkit refactoring (#16184) 2022-01-21 09:27:10 +07:00
loggers Move LogWorkerQueueStats from labor to services (#11642) 2020-11-30 09:31:15 +07:00
mailchimp Handle GibbonError when Mailchimp api key was not set (#14695) 2021-09-13 10:30:35 -05:00
markdown_processor Allowing dependency injection for LiquidTag policy (#16511) 2022-02-10 07:47:16 -05:00
mentions Issue #9077 has already been resolved, added specs (#15342) 2021-11-17 11:27:50 +02:00
moderator Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
notification_subscriptions Add Article post_commit when user_id changes with specs (#15132) 2021-10-25 10:53:21 +07:00
notifications Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
organizations Organizations delete optimizations and refactoring (#13610) 2021-05-11 12:14:55 +03:00
payments Validate payment info present before attempting to process (#15629) 2021-12-03 13:09:23 -06:00
podcasts Add Errno::EHOSTUNREACH to Podcasts's rescue list (#16884) 2022-03-15 14:05:04 -04:00
profile_fields Profile attribute names should be unique and non-empty (#16396) 2022-04-04 12:14:02 -05:00
push_notifications Fix Rpush app when creating Android notification (#15529) 2021-11-30 10:05:40 +05:30
re_captcha Spelling (#15702) 2021-12-07 06:59:10 -07:00
search Added "Tags" category to search results (#16265) 2022-01-26 20:51:15 +03:00
settings/authentication Disable all providers when providers_to_enable param is blank (#15260) 2021-11-02 21:20:26 -04:00
slack Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
spam Refactoring Spam Handler (#15412) 2021-11-30 12:45:12 -05:00
tag_moderators ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
twitter_client Match error class using case instead of if/elsif/else (#16952) 2022-03-21 15:34:49 -05:00
user_subscriptions Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
users Profile attribute names should be unique and non-empty (#16396) 2022-04-04 12:14:02 -05:00
analytics_service_spec.rb Ensure the domain of other_url is different from top_url (#16373) 2022-02-01 09:18:49 -05:00
article_with_video_creation_service_spec.rb Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121) 2021-07-08 09:31:34 -05:00
bulk_sql_delete_spec.rb Routine rubocop fixes (#10237) 2020-09-08 12:06:47 -04:00
email_digest_article_collector_spec.rb Don't include "anti-followed" tags in email digest (#14782) 2021-09-30 10:44:38 +07:00
email_digest_spec.rb Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121) 2021-07-08 09:31:34 -05:00
feature_flag_spec.rb Add FeatureFlag.all (#16496) 2022-02-11 13:38:17 +07:00
flare_tag_spec.rb Routine Rubocop fixes (#16838) 2022-03-09 09:32:50 -05:00
medium_article_retrieval_service_spec.rb
open_graph_spec.rb OpenGraph fallback for Embeds (merge-by-any-core) (#17001) 2022-04-04 15:31:38 -04:00
rate_limit_checker_spec.rb Fixing Rubocop's auto-correct recommendations (#16098) 2022-01-13 21:40:19 -05:00
tag_adjustment_creation_service_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
tag_adjustment_update_service_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00