docbrown/app/services/notifications
Jacob Herrington 099b188530 Rename uncommunicative variables (#3890)
* Clarify uncommunicative variables in labor classes

Single letter variable names are largely a question of preference, in
some cases I think that convention mitigates the opaque nature of single
letter variable names (e.g., e for error, i for index, etc).

However, in some cases they can be unclear and there isn't much reason
to use single letter variables unless for some reason character length is
really important.

In this case, I would prefer clarity in variable names over brevity of
code so I've used Reek to identify short variable names and I'm changing
them.

It's pretty boring, but hopefully incremental code love changes like
this one add up and improve readability and accessibility for those
interested in reading this codebase.

* Remove commented code from 2 years ago

* Clarify uncommunicative naming in services classes

There is some context for this change in 6b81880f

* Clarify uncommunicative naming in models

There is some context for this change in 6b81880f

* Clarify uncommunicative naming in liquid_tags

There is some context for this change in 6b81880f
2019-09-02 13:05:07 -04:00
..
milestone send_milestone_notification in own job (#2804) 2019-05-16 13:46:50 -04:00
moderation Moved send_mention_notification to ActiveJob (#3566) 2019-08-01 16:35:25 -04:00
new_badge_achievement Move send new badge achievement notification to ActiveJob (#2474) 2019-04-29 10:51:08 -04:00
new_comment Return original body instead of nil for new comment push notifications (#3273) 2019-06-24 08:33:35 -04:00
new_follower Rename uncommunicative variables (#3890) 2019-09-02 13:05:07 -04:00
new_mention Fix mention notification to mention proper user (#3721) 2019-08-14 14:43:21 -04:00
notifiable_action Add backend functionality for muting users you follow (#3240) 2019-06-20 11:28:50 -04:00
reactions Rename uncommunicative variables (#3890) 2019-09-02 13:05:07 -04:00
tag_adjustment_notification Improve mod roundrobin notification and internal tooling (#3855) 2019-08-27 21:54:09 -04:00
welcome_notification Allow for the sending of arbitrary broadcasts (#3569) 2019-07-29 17:10:49 -04:00
moderation.rb Improve mod roundrobin notification and internal tooling (#3855) 2019-08-27 21:54:09 -04:00
remove_all.rb Move remove_all notifications method in own job (#2882) 2019-05-20 13:54:39 -04:00
remove_each.rb Add context data to comment notifications (#3258) 2019-06-21 14:26:19 -04:00
update.rb ActiveJob for updating notifications #1996 (#2839) 2019-05-15 12:37:25 -04:00