Daniel Uber 6f84f4afe8 Validate profile field "website url" is in fact a url (don't generate local path links). (#14302) ... * Validate website_url profile field is a url related to issue #14300 May need a data update script to (fixup? remove?) invalid profiles since not being able to save existing profiles will cause problems. * Check that URI is a valid url Require the scheme to be one of https or http, not something like mailto:// or telnet:// (nobody would do that, but don't try and link to it if they did). * Rubocop fixup for validation rule URI::regexp is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp Prefer %w[] literals for arrays of words Prefer the new style validations `validates :column, format: value` to validates_format_of * Permit empty website_url fields The previous validation was rejecting nil, which was the default. This caused a lot of user factory calls to fail (since users didn't need website urls in the profiles during testing unless the test was about the website url link). * Use :url validation as suggested * Update validation error message The validate_url gem gives a more complete error message to the user. Update the spec to expect this. * Use url_field rather than text_field in profile form https://apidock.com/rails/v6.1.3.1/ActionView/Helpers/FormHelper/url_field * Add data update to either fixup or clear invalid website urls Checking blazer there are about 2600 profiles with "invalid" website urls, typically a hostname, sometimes a hostname + path component, which should be fixed up. Naively add https:// to the front of the url, check that a valid scheme and host are present on the resulting url, and save. If an invalid url is generated (specifically, if host or scheme are nil), just set the website url (with the invalid link) to an empty string. It's possible we'd want to notify users affected by this, that was not included in this pass. * Skip validations for intentionally invalid test cases		2021-07-22 12:02:29 -05:00
..
ahoy	[deploy] Rubocop: fix Rails/HasManyOrHasOneDependent for Ahoy::Visit and Badge (#9565)	2020-07-31 11:43:50 -04:00
concerns	Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606)	2021-05-03 11:09:45 -04:00
settings	Make smtp "domain" setting explicit (#14097)	2021-07-12 09:22:37 -05:00
shared_examples	Remove CustomProfileField (#14286)	2021-07-22 10:05:39 +07:00
users	Fix brand color validation (#14303)	2021-07-22 09:35:20 +01:00
webhook	Add missing presence validators to models (#10495)	2020-10-01 16:15:32 +02:00
api_secret_spec.rb	Limit the Number of API Keys a User Can Have (#7870)	2020-05-15 11:33:02 +02:00
application_record_spec.rb	Switch decorators to Rails builtin decorations - take 2 (#6125) [deploy]	2020-02-19 15:30:53 -05:00
article_destroy_spec.rb	[deploy] Rubocop: fix violations of Layout/LineLength (#9197)	2020-07-08 08:36:36 -05:00
article_spec.rb	Allow multiple users to fetch all articles from the same RSS feed (#14160)	2021-07-19 15:15:32 +02:00
audit_log_spec.rb	Add missing presence validators to models (#10495)	2020-10-01 16:15:32 +02:00
badge_achievement_spec.rb	Configure badge credits by admins (#13145)	2021-03-30 10:58:48 +03:00
badge_spec.rb	Refactor cache purging (#12811)	2021-03-02 10:09:05 -05:00
banished_user_spec.rb	Introduce BanishedUser table (#5589) [deploy]	2020-01-21 17:15:58 -05:00
broadcast_spec.rb	Fix Rails/HasManyOrHasOneDependent for Broadcast and Collection (#9662)	2020-08-07 14:27:24 -04:00
chat_channel_membership_spec.rb	Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606)	2021-05-03 11:09:45 -04:00
chat_channel_spec.rb	[deploy] Encode domain name in pusher channels (#11136)	2020-10-28 14:52:38 -04:00
collection_spec.rb	Fix Rails/HasManyOrHasOneDependent for Broadcast and Collection (#9662)	2020-08-07 14:27:24 -04:00
comment_spec.rb	Fix shorten_urls to not remove formatting and image tags (#14262)	2021-07-20 10:10:34 -04:00
consumer_app_spec.rb	Have specs run without Redis and refactor ConsumerApp and Device (#13647)	2021-05-07 08:03:16 +02:00
credit_spec.rb	Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556)	2020-07-29 11:31:01 +02:00
data_update_script_spec.rb	Save Data Update Script errors to database and show them on http://localhost:3000/admin/data_update_scripts (#12348)	2021-01-21 14:48:34 +01:00
device_spec.rb	Have specs run without Redis and refactor ConsumerApp and Device (#13647)	2021-05-07 08:03:16 +02:00
discussion_lock_spec.rb	Create DiscussionLocks (#13905)	2021-06-10 11:04:33 -04:00
display_ad_event_spec.rb	Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556)	2020-07-29 11:31:01 +02:00
display_ad_spec.rb	[deploy] Remove orphaned DisplayAdEvent rows (#9765)	2020-08-14 09:29:08 -04:00
email_authorization_spec.rb	Add missing presence validators to models (#10495)	2020-10-01 16:15:32 +02:00
email_message_spec.rb	[deploy] Add missing foreign keys to ahoy_messages and articles (#10321)	2020-09-16 19:47:03 +02:00
event_spec.rb	Move Events::BustCacheJob to Sidekiq and rename (#5379)	2020-01-06 15:51:46 -05:00
feedback_message_spec.rb	[15-min-fix] Better feedback messaging (#13254)	2021-04-12 09:05:45 -04:00
follow_spec.rb	Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121)	2021-07-08 09:31:34 -05:00
forem_instance_spec.rb	Create Settings::SMTP (#13943)	2021-06-14 10:29:43 -04:00
github_issue_spec.rb	✂️ Remove the approvals gem ✂️ (#12978)	2021-03-19 13:28:06 -07:00
github_repo_spec.rb	Fix Ruby 2.7 kwargs' warnings & misc spec warnings (#13256)	2021-04-06 16:57:59 -04:00
hair_trigger_spec.rb	Search results: prioritize articles titles (#13918)	2021-06-09 14:28:19 +02:00
html_variant_spec.rb	[15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured (#13767)	2021-05-19 15:03:20 +02:00
html_variant_success_spec.rb	Unskip all skipped specs (#2941)	2019-05-25 11:04:38 -04:00
html_variant_trial_spec.rb	Unskip all skipped specs (#2941)	2019-05-25 11:04:38 -04:00
identity_spec.rb	Add Sign in with Apple (#11934)	2020-12-18 10:22:33 -06:00
listing_category_spec.rb	Rubocop: Fix ListingCategory has_many relation to Listing (#9853)	2020-08-19 19:23:49 +02:00
listing_spec.rb	Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606)	2021-05-03 11:09:45 -04:00
mention_spec.rb	Add Mentions::CreateAllWorker for Sidekiq (#5463)	2020-01-13 13:23:30 -06:00
message_spec.rb	Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121)	2021-07-08 09:31:34 -05:00
navigation_link_spec.rb	Update NavigationLink handling (#12316)	2021-01-20 13:57:59 -05:00
note_spec.rb	[deploy] Add missing dependent clauses to User and cleanup relations (#10011)	2020-08-28 20:19:24 +02:00
notification_spec.rb	UsersSettings RFC: Code to Sync User Settings updates to new tables (#13719)	2021-05-27 09:52:54 -04:00
notification_subscription_spec.rb	Add missing presence validators to models (#10495)	2020-10-01 16:15:32 +02:00
organization_membership_spec.rb	[deploy] Create private group chat channel for orgs (#7270)	2020-04-16 17:02:06 -04:00
organization_spec.rb	Organizations delete optimizations and refactoring (#13610)	2021-05-11 12:14:55 +03:00
page_spec.rb	[15 min fix] Refactor private landing pages model code (#13982)	2021-06-15 18:17:15 +02:00
page_view_spec.rb	Remove UserHistory Feature and PageViews from Algolia (#6127) [deploy]	2020-02-18 10:06:30 -05:00
pinned_article_spec.rb	Pin posts to feed (#13807)	2021-06-04 10:54:53 +02:00
podcast_episode_appearance_spec.rb	Add podcast_appearances joined table (forem#82) (#11354)	2020-11-30 17:12:52 +01:00
podcast_episode_spec.rb	[15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured (#13767)	2021-05-19 15:03:20 +02:00
podcast_ownership_spec.rb	Podcast ownership join table (MLH Fellowship #81) (#11410)	2020-11-19 12:41:17 +01:00
podcast_spec.rb	Podcast ownership join table (MLH Fellowship #81) (#11410)	2020-11-19 12:41:17 +01:00
poll_option_spec.rb	Add missing presence validators to models (#10495)	2020-10-01 16:15:32 +02:00
poll_skip_spec.rb	Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556)	2020-07-29 11:31:01 +02:00
poll_spec.rb	Add missing presence validators to models (#10495)	2020-10-01 16:15:32 +02:00
poll_vote_spec.rb	Upgrade Rubocop related gems and fix new violations (#3581) [ci skip]	2019-07-30 14:29:05 -04:00
profile_field_group_spec.rb	Replace calls to Flipper with FeatureFlag (#11386)	2020-11-12 14:15:33 +01:00
profile_field_spec.rb	Remove CustomProfileField (#14286)	2021-07-22 10:05:39 +07:00
profile_pin_spec.rb	Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556)	2020-07-29 11:31:01 +02:00
profile_spec.rb	Validate profile field "website url" is in fact a url (don't generate local path links). (#14302)	2021-07-22 12:02:29 -05:00
rating_vote_spec.rb	[deploy] Add missing foreign keys to models related to users (#10018)	2020-08-31 15:39:57 +02:00
reaction_spec.rb	Rename SiteConfig to Settings::General (#13573)	2021-05-21 14:45:37 +02:00
response_template_spec.rb	[deploy] Rubocop: fix violations of Layout/LineLength (#9197)	2020-07-08 08:36:36 -05:00
role_spec.rb	Rename banned and comment_banned roles (#12270)	2021-04-06 10:12:14 -05:00
sponsorship_spec.rb	Add missing presence validators to models (#10495)	2020-10-01 16:15:32 +02:00
tag_adjustment_spec.rb	[deploy] Rubocop: fix violations of Layout/LineLength (#9197)	2020-07-08 08:36:36 -05:00
tag_spec.rb	Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606)	2021-05-03 11:09:45 -04:00
timeframe_spec.rb	Remove timeframer from app/labor (#11782)	2020-12-08 12:52:33 +07:00
tweet_spec.rb	[deploy] Rubocop: fix violations of Layout/LineLength (#9197)	2020-07-08 08:36:36 -05:00
user_block_spec.rb	Fix and refactor hide user content (#12307)	2021-01-18 11:08:23 -05:00
user_role_spec.rb	[Search 2.0] Users (#13453)	2021-04-24 19:06:06 +02:00
user_spec.rb	Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121)	2021-07-08 09:31:34 -05:00
user_subscription_spec.rb	Improve error message of User Subscriptions (#11689)	2020-12-01 08:41:49 -08:00