maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/services
History
Joshua Wehner a20cf3e02b
Unique cross-model-slug check is likely misconfigured (#19263) 
* Page unique_cross_model_slug seems misconfigured

* Update validator test

* More verbose invalid attribute message

* Try dynamic model/attribute registration

* Rubocop

* Use the cross-model-slug existence check

* Register with the dynamic cross-model-slug checker

* Cleanup

* Add missing keys to fr

* Update format regex

* Adjust validation: always presence, unique if changed

* Tests can create reserved-word pages when they need to

* Slugs can be mixed case?

* Case-sensitive is better, actually

* Refactor to use CrossModel check

* Refactor, rename for clarity

* Refactor, avoid mocking oneself

* Refactor, injectable everything

* Add reservedword check to extracted exists? checker

* Move to concerns

* Without dynamic registration

* extend when needed

* Cleanup comments, remove registration references

---------

Co-authored-by: Goran <gorang.pub@gmail.com>
2023-04-07 17:04:45 +02:00
..
admin
articles Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
audit
authentication Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
badges Expand Badges::AwardYearlyClub to include year 8 (#18959) 2023-01-16 08:51:01 -05:00
broadcasts/welcome_notification Round Robin Notifications Refactor (#19026) 2023-02-01 15:21:36 +02:00
color
credits Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
discover
edge_cache Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
error_messages
exporter
fastly_config
feeds Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
follows
giphy
github Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
homepage
html Ensure rendering parity on DisplayAd, Comment, & Article (#19091) 2023-04-07 09:30:17 -04:00
images
listings
loggers
mailchimp
markdown_processor Ensure rendering parity on DisplayAd, Comment, & Article (#19091) 2023-04-07 09:30:17 -04:00
mentions Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
moderator Clear trusted cache in rolify callback (#19275) 2023-04-03 14:45:00 +02:00
notification_subscriptions Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
notifications Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
organizations Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
payments
podcasts Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
profile_fields
push_notifications
re_captcha
search Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
settings
slack Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
spam Adding configurations to tighten spam handling (#18195) 2022-08-01 11:21:34 -04:00
tag_moderators Clear trusted cache in rolify callback (#19275) 2023-04-03 14:45:00 +02:00
twitter_client
user_subscriptions
users Unique cross-model-slug check is likely misconfigured (#19263) 2023-04-07 17:04:45 +02:00
analytics_service.rb Frontend for multiple reactions (v1) (#18808) 2023-01-23 16:00:50 +01:00
application_service.rb
article_api_index_service.rb Remove featured number usage from articles (#18510) 2022-09-28 08:59:03 -06:00
article_with_video_creation_service.rb
bulk_sql_delete.rb
calculate_reaction_points.rb Refactor reaction categories as abstract class collection (#18540) 2022-11-01 10:50:37 +01:00
comment_creator.rb Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
content_renderer.rb Ensure rendering parity on DisplayAd, Comment, & Article (#19091) 2023-04-07 09:30:17 -04:00
display_ad_event_rollup.rb Rollup service to compact DisplayAdEvent records (#18508) 2022-10-19 16:21:47 +02:00
email_digest.rb
email_digest_article_collector.rb
feature_flag.rb Extract article markdown rendering to service (#18754) 2022-12-14 15:30:26 +01:00
flare_tag.rb
instrumentation.rb Bump ddtrace from 0.54.2 to 1.0.0 (#17662) 2022-05-18 15:46:49 -04:00
markdown_processor.rb Ensure rendering parity on DisplayAd, Comment, & Article (#19091) 2023-04-07 09:30:17 -04:00
medium_article_retrieval_service.rb Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
notifications.rb
open_graph.rb Ensuring that embed fallback renders URL (#17680) 2022-05-17 07:43:17 -04:00
rate_limit_checker.rb Routine rubocop fixes (#19254) 2023-03-24 14:37:44 +03:00
reaction_handler.rb Round Robin Notification Tweaks (#18995) 2023-01-26 19:31:45 +02:00
tag_adjustment_creation_service.rb
tag_adjustment_update_service.rb