68867e7c68
* Make test fail again Minimal reproduction via `rspec spec/system/user/trusted_user_flags_user_spec.rb --order=random --seed=9374` which runs in this order: - when signed in as a trusted user - when not logged in - when signed in as the non-trusted user - when signed in as the user Because "not logged in" immediately precedes "non-trusted user" in this order, the browser store cache is cleared and there is no user. Since there's no user, the flag is not removed. * Wait for current user promise before processing current user * Extract button callback registration to function This addresses a code climate concern (function exceeded 50 lines) by extracting the button behavior to a function of (button, id, name), and calls that within the exported initFlag function. * Prefer request to fetch Addresses feedback to use @utilities/http's request method in place of fetch (which automatically adds the needed csrf headers) * Reorder imports Satisfies code climate report that imports are out of order * Add honeybadger notify to error handling Do more than just notify that something went wrong. Notify honeybadger on failure to flag/unflag a user. * Remove temp variable This makes the notify code look more like the suggestion * Reduce function arglist Since the user id and name are properties of the flagButton's dataset, we can efficiently extract them from the flagButton. Only pull user id from dataset to check if current user = profile user, and extract id and name from dataset after passing the flagButton. * reorder imports Not sure how I managed to reverse this in 18aeb675b but here we go again * Test button behavior The original tests only asserted that the link to reactions was present and labeled correctly. Add additional check that we can use the button and that the label toggling occurs (this adds a request to the test case, but adds a test for user facing behavior). * Tame eslint check I was getting conflicting feedback on import ordering from code climate and eslint. Since telling eslint to ignore its rules was immediately clear to me (there's an example on the line before this) that's the direction I headed, but I can revisit if it matters https://github.com/forem/forem/pull/13279#issuecomment-814411401 captures the conflict (code climate wants @utilities/http first, eslint wants ../chat/util first, one or the other fails regardless of the ordering. * Use multiple rules in one ignore comment https://eslint.org/docs/user-guide/configuring/rules#disabling-rules supports multiple warnings separated by commas * Remove stray comment * Move documentation comment to the code it describes * Replace invalid name I had copied from the suggested code snippet the userData.profileUserID name, but userData in this context is a global function, and `profileUserId` (capitalization) is the bound variable in this context. Fix it before we throw an error trying to report an error (ironically, before the window alert telling the user an error occurred, I think this would have been visible only in console). * Actually call the remove button function |
||
|---|---|---|
| .buildkite | ||
| .gems | ||
| .github | ||
| .vscode | ||
| .yarn/releases | ||
| app | ||
| bin | ||
| config | ||
| cypress | ||
| datadog | ||
| db | ||
| docs | ||
| lib | ||
| log | ||
| public | ||
| scripts | ||
| spec | ||
| vendor | ||
| .codeclimate.yml | ||
| .dockerignore | ||
| .editorconfig | ||
| .env_sample | ||
| .erb-lint.yml | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .gitattributes | ||
| .gitdocs.js | ||
| .gitignore | ||
| .gitpod.dockerfile | ||
| .gitpod.yml | ||
| .nvmrc | ||
| .postcssrc.yml | ||
| .prettierignore | ||
| .prettierrc.json | ||
| .rspec | ||
| .rubocop.yml | ||
| .rubocop_todo.yml | ||
| .ruby-version | ||
| .simplecov | ||
| .slugignore | ||
| .travis.yml | ||
| .validaterc | ||
| .yardopts | ||
| .yarnrc | ||
| babel.config.js | ||
| CODE_OF_CONDUCT.md | ||
| config.ru | ||
| container-compose.yml | ||
| Containerfile | ||
| CONTRIBUTING.md | ||
| cypress.dev.json | ||
| cypress.json | ||
| docker-compose.yml | ||
| Dockerfile | ||
| empty-module.js | ||
| Gemfile | ||
| Gemfile.lock | ||
| Guardfile | ||
| jest.config.js | ||
| jsconfig.json | ||
| LICENSE.md | ||
| package.json | ||
| postcss.config.js | ||
| Procfile | ||
| Procfile.dev | ||
| Procfile.dev-hot | ||
| Rakefile | ||
| README.md | ||
| release-tasks.sh | ||
| SECURITY.md | ||
| svgo.config.js | ||
| testSetup.js | ||
| yarn.lock | ||
Forem 🌱
For Empowering Community
Welcome to the Forem codebase, the platform that powers dev.to. We are so excited to have you. With your help, we can build out Forem’s usability, scalability, and stability to better serve our communities.
What is Forem?
Forem is open source software for building communities. Communities for your peers, customers, fanbases, families, friends, and any other time and space where people need to come together to be part of a collective. See our announcement post for a high-level overview of what Forem is.
dev.to (or just DEV) is hosted by Forem. It is a community of software developers who write articles, take part in discussions, and build their professional profiles. We value supportive and constructive dialogue in the pursuit of great code and career growth for all members. The ecosystem spans from beginner to advanced developers, and all are welcome to find their place within our community. ❤️
Table of Contents
- What is Forem?
- Table of Contents
- Community
- Contributing
- Getting Started
- Developer Documentation
- Core team
- Vulnerability disclosure
- License
Community
For a place to have open discussions on features, voice your ideas, or get help with general questions please visit our community at forem.dev.
Contributing
We encourage you to contribute to Forem! Please check out the Contributing to Forem guide for guidelines about how to proceed.
Getting Started
This section provides a high-level quick start guide. If you're looking for the installation guide, you'll want to refer to our complete Developer Documentation.
We run on a Rails backend, and we are currently transitioning to a Preact-first frontend.
A more complete overview of our stack is available in our docs.
Prerequisites
Local
- Ruby: we recommend using rbenv to install the Ruby version listed on the badge.
- Yarn 1.x: please refer to their installation guide.
- PostgreSQL 11 or higher.
- ImageMagick: please refer to ImageMagick's installation instructions.
- Redis 4 or higher.
- Elasticsearch 7 or higher.
Containers
Linux
- Podman 1.9.2 or higher
- Podman Compose 0.1.5 or higher
OS X
Installation Documentation
View Full Installation Documentation.
Developer Documentation
Check out our dedicated docs page for more technical documentation.
Core team
- @benhalpern
- @jessleenyc
- @peterkimfrank
- @maestromac
- @zhao-andy
- @lightalloy
- @rhymes
- @jacobherrington
- @mstruve
- @atsmith813
- @citizen428
- @nickytonline
- @joshpuetz
- @vaidehijoshi
- @juliannatetreault
- @ridhwana
- @fdoxyz
- @msarit
- @jdoss
- @cmgorton
- @andygeorge
- @phannon716
- @s_aitchison
- @jgaskins
- @djuber
Vulnerability disclosure
Forem is the open source software which powers DEV.
We welcome security research on DEV under the terms of our vulnerability disclosure policy.
Acknowledgments
Thank you to the Twemoji project for the usage of their emojis.
License
This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. Please see the LICENSE file in our repository for the full text.
Like many open source projects, we require that contributors provide us with a Contributor License Agreement (CLA). By submitting code to the Forem project, you are granting us a right to use that code under the terms of the CLA.
Our version of the CLA was adapted from the Microsoft Contributor License Agreement, which they generously made available to the public domain under Creative Commons CC0 1.0 Universal.
Any questions, please refer to our license FAQ doc or email yo@dev.to.
Happy Coding ❤️