maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/requests
History
Ridhwana 7a9629172d
Profile generalization for the onboarding workflow (#11629) 
* feat: v1 of the profile form

* feat: fix inputs and create a handleChange event

* feat: update the submit values to represent values from the form

* feat: ensure that errors and success is handled on send

* refactor: remove unused code

* feat: replace the old profile form with a new one

* fix: use the renames file

* refactor: safety net for groups

* chore: fix code climate issue

* tests: amend + add tests

* test: fix broken spec

* feat: update the setup for the test

* tests: refactored them to move the fake response into the before all

* feat: clunky way to quickly cater for color field since it was a quick and easy implementation

* feat: add a field.description to the color field

* refactor: pull some duplicate code into a new function

* chore: cater for a textarea field

* overflow issue

* refactor: use FormField instead of manual divs

* Update spec/requests/users_onboarding_spec.rb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update spec/requests/users_onboarding_spec.rb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* refactor: move out of method and into a constant

* refactor: user_onboarding_update to be more readable

* refactor: use current.save instead of declaring a new variable

* refactor: remove explicit check for bookean

* refactor: use request from '@utilities/http' instead :)

* refactor: no need for if with destructured groups

* refactor: move color field to its own component

* chore: remove colorfield now thats its a component

* fix: forgot about field

* feat: a text area component

* chore: remove textField function in favor of component

* refactor: checkbox refactor

* refactor: add a switch statement

* chore: move into a more organized folder

* fix: move the handler to props and off from field

* fix: add a conditional so we dont hit an error undefined method `success?' for nil:NilClass

* refactor: change from component to function

* feat: add a key attribute

* refactor: add role for readers

* refactor: remove unnecessary guard clauses

* refactor: use function instead of an arrow

* chore: document components

* test

* padding

* fixes

* test: fix the tests by using more general matchers

Co-authored-by: Paweł Ludwiczak <ludwiczakpawel@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-12-08 19:53:00 +02:00
..
admin Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
api/v0 Disable ActionController auto params wrapping (#11692) 2020-12-02 15:17:43 +01:00
articles Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
incoming_webhooks/mailchimp Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
notifications [deploy] Remove All Notification Count Helper Classes (#8221) 2020-06-02 09:48:02 -05:00
oauth Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
podcasts [deploy] Validate both images and pattern_images when creating podcasts (#7828) 2020-05-14 11:23:04 -04:00
resource_admin [deploy] Move /internal to `/admin (#9639) 2020-08-07 10:36:26 -04:00
shared_examples nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
stories Remove concept of "ongoing" field tests and clarify a/b test instructions/expectations. (#11734) 2020-12-07 13:52:54 -05:00
user Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
api_secrets_create_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
api_secrets_destroy_spec.rb Fix access token revoking (#3131) 2019-06-11 15:53:58 -04:00
article_approvals_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
async_info_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
badges_spec.rb Add badges index page. (#4236) 2019-10-06 17:34:52 -04:00
buffer_updates_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
chat_channel_memberships_spec.rb Optimization:Dont Notify of Channel Leavings (#10518) 2020-10-02 16:19:54 +02:00
chat_channels_spec.rb 🚀 Ability to allow tag moderators to create chat channels (#9741) 2020-12-08 13:10:36 +07:00
collections_spec.rb [deploy] Add index and show pages for series (#9201) 2020-07-29 10:01:52 -04:00
comments_create_spec.rb [deploy] Revert "Async Handle Notifications for Comments When Saved (#9680)" (#9686) 2020-08-08 20:16:27 -05:00
comments_destroy_spec.rb Rubocop: Enable and fix Style/StringConcatenation (#9844) 2020-08-18 14:50:15 +02:00
comments_spec.rb Remove concept of "ongoing" field tests and clarify a/b test instructions/expectations. (#11734) 2020-12-07 13:52:54 -05:00
comments_update_spec.rb [deploy] Remove redirect on comments#update (#10337) 2020-09-29 15:33:51 -04:00
credits_spec.rb [deploy] Rename classified listings (#7910) 2020-05-27 13:35:09 +00:00
dashboard_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
display_ad_events_spec.rb [deploy] Refactor: Run Display Ad Events Controller in all Envs (#11144) 2020-10-28 17:15:43 -05:00
editor_spec.rb [Email/Password Authentication] Allow Admins to enable email/password login (#10745) 2020-10-12 12:54:35 -04:00
email_subscriptions_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
errors_request_spec.rb Use custom, dynamic, error pages (#11744) 2020-12-07 18:55:41 +01:00
events_spec.rb Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556) 2020-07-29 11:31:01 +02:00
feedback_messages_spec.rb Fixes a rubocop failure that slipped through in a previous PR (#11715) 2020-12-03 10:00:50 +01:00
followings_spec.rb [deploy] Reintroduce sticky_nav changes (ab81f36 & 7f92855) (#10263) 2020-09-09 15:33:13 -04:00
follows_bulk_show_spec.rb [deploy] Bulk Fetch Follow Button Data for Users (#7676) 2020-05-08 13:58:58 -05:00
follows_create_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
follows_show_spec.rb Rubocop: enable and fix Style/Send and Style/Next (#9366) 2020-07-20 16:28:00 +02:00
follows_update_spec.rb Add implicit points to follows to improve feed relevancy (in all algorithms) (#11513) 2020-11-25 16:09:51 -05:00
ga_events_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
github_repos_spec.rb [EOY2020 Issue] Default new forems to Email Authentication only (#11696) 2020-12-02 16:49:07 -05:00
html_variant_successes_spec.rb Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
html_variant_trials_spec.rb Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
image_uploads_spec.rb Upgrade to Rails 6.0 (#7658) 2020-06-04 11:54:25 +02:00
invitations_spec.rb Small Rubocop fixes (#11182) 2020-10-30 14:45:55 +01:00
liquid_embeds_spec.rb [deploy] Decouple Twitter authentication from fetching tweets (#7920) 2020-05-19 18:05:41 -04:00
liquid_tags_request_spec.rb [deploy] Add LiquidTagsController (#10241) 2020-09-08 12:07:33 -04:00
listings_spec.rb Fixing missing category in listing modal (#11301) 2020-11-06 12:29:20 -05:00
messages_spec.rb [deploy] Optimization/Bug Fix:Only Send Mentioned User Notifications, not all for every message (#9493) 2020-07-27 11:16:41 -05:00
moderations_spec.rb Bug Fix:Remove Score Filter From Tag Mod Index (#11599) 2020-11-24 14:18:14 -06:00
notification_counts_spec.rb [deploy] Optimization:Use Scope and current_user to Get Notification Count (#8177) 2020-06-01 09:27:46 -05:00
notification_subscriptions_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
notifications_spec.rb Optimization:Speed Up Notifications Spec By Combining Assertions (#11200) 2020-11-02 07:56:23 -06:00
onboardings_spec.rb [deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) (#8435) 2020-07-07 07:37:04 -05:00
open_search_spec.rb [deploy] Remove need for ENV vars during asset precompile (#10349) 2020-09-16 13:57:05 -04:00
organizations_update_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
page_views_spec.rb Remove concept of "ongoing" field tests and clarify a/b test instructions/expectations. (#11734) 2020-12-07 13:52:54 -05:00
pages_spec.rb feat: allow the contact page to be overridden by pages (#10924) 2020-10-19 16:16:56 -04:00
partnerships_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
poll_skips_spec.rb Small ActiveRecord optimizations: begone race conditions and hello bulk insert (#8436) 2020-06-15 17:57:14 +02:00
poll_votes_spec.rb Fix rubocop detected offenses (#4552) 2019-10-24 11:53:03 -04:00
profile_field_groups_request_spec.rb Deployment Task: Update onboarding fields prior to #11629 (#11704) 2020-12-07 14:57:18 -05:00
profile_pins_spec.rb [deploy] Finalize deleting user associations (#5624) 2020-01-23 11:29:47 -05:00
profiles_request_spec.rb Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
pusher_auth_spec.rb Remove commented code and tests (#3989) [ci skip] 2019-09-09 14:51:02 -04:00
rating_votes_spec.rb Add experience level averaging to articles (#1922) 2019-02-28 08:17:29 -08:00
reactions_spec.rb Remove concept of "ongoing" field tests and clarify a/b test instructions/expectations. (#11734) 2020-12-07 13:52:54 -05:00
reading_list_items_spec.rb [deploy] Fix Reading List Counter Without last_reacted_at Default (#10933) 2020-10-19 13:26:19 -05:00
registrations_spec.rb Ensure first user of a Forem has a trusted role (#11700) 2020-12-02 08:44:35 -08:00
response_templates_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
search_spec.rb Feature:Backend Username Search Endpoint for Mention Completion (#11479) 2020-11-18 16:43:59 -06:00
service_worker_spec.rb Add config option for Forem collective noun (#11107) 2020-10-27 12:45:52 -04:00
shells_spec.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
sitemaps_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
social_previews_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
stories_index_spec.rb Spec Speed Up:Stories Index Spec (#11361) 2020-11-16 13:27:57 -06:00
stories_show_spec.rb Adds ability for admins to create new tags via /admin/tags (#11240) 2020-12-02 08:12:57 -06:00
stripe_active_cards_spec.rb [deploy] Add audit logs for credit card actions (#9416) 2020-07-22 08:23:42 +07:00
tag_adjustments_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
tags_spec.rb [deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) (#8435) 2020-07-07 07:37:04 -05:00
twilio_tokens_spec.rb Code cleanups (#659) 2018-08-07 11:00:13 -04:00
user_blocks_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
user_subscriptions_spec.rb Improve error message of User Subscriptions (#11689) 2020-12-01 08:41:49 -08:00
users_onboarding_spec.rb Profile generalization for the onboarding workflow (#11629) 2020-12-08 19:53:00 +02:00
video_chats_spec.rb Refactoring ChatChannel - distributing into services (#9253) 2020-08-07 10:41:34 +02:00
video_states_update_spec.rb [deploy] Refactor/Feature:Use SiteConfig video_encoder_key For Processing Videos (#10848) 2020-10-15 10:16:50 -05:00
videos_spec.rb Rubocop: re-activate Style/RegexpLiteral and fix violations (#9418) 2020-07-22 16:28:27 +02:00