ae22dc93a9
* Fix broken job specs Many job specs were putting their assertions inside a block provided to ActiveJob's perform_now. Unfortunately, this syntax does not error and simply ignores the provided block. The tests were therefore not executing their assertions. As a result many of them were actually broken to begin with. Many used incorrect stubbing, were trying to stub instances of models that wouldn't actually be returned by ActiveRecord queries, etc. This commit fixes the syntax and does it's best to fix the tests. Many of these assertions/spec could use more TLC, but this work at least gets them passing/executing. * Avoid time comparison precision issues * Implement review feedback Adds negative test cases for when record is not found/nil. Also some formatting changes as I was paying more attention to the rubocop setup now. * Add without article context to job spec * Remove unused lets |
||
|---|---|---|
| .. | ||
| bust_cache_job_spec.rb | ||
| calculate_score_job_spec.rb | ||
| create_first_reaction_job_spec.rb | ||
| create_id_code_job_spec.rb | ||
| send_email_notification_job_spec.rb | ||
| touch_user_job_spec.rb | ||