docbrown/spec
rhymes 5e9be0c32d
Disable ActionController auto params wrapping (#11692)
* Disable ActionController auto params wrapping

Rails by default accepts wrapped and unwrapped parameters in JSON requests (with or without a root object), regardless of the fact that the contract with the client requests wrapped parameters or not. This results in unforeseeable bugs when the client sends unwrapped parameters in lieu of wrapped ones.

As undeterministic bugs are a PITA and this is the classic grey area in Rails apps and as the customer facing API is fully documented and the internal can be manually adjusted, we disable this and be done with this odd feature.

https://github.com/forem/forem/issues/11645
https://github.com/forem/forem/pull/11638

* Remove accidentally committed file
2020-12-02 15:17:43 +01:00
..
black_box Routine rubocop fixes (#10237) 2020-09-08 12:06:47 -04:00
decorators Add implicit points to follows to improve feed relevancy (in all algorithms) (#11513) 2020-11-25 16:09:51 -05:00
factories Add podcast_appearances joined table (forem#82) (#11354) 2020-11-30 17:12:52 +01:00
fixtures fix: Parsing of preamble with escaped content in runkit tags (#11466) 2020-11-27 16:56:52 -05:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Move GeneratedImage to Images::GenerateSocialmage (#11691) 2020-12-02 11:03:14 +07:00
initializers Refactor:Implement Carrierwave Monkeypatch in all Envs (#11233) 2020-11-03 10:51:53 -06:00
labor Move GeneratedImage to Images::GenerateSocialmage (#11691) 2020-12-02 11:03:14 +07:00
lib Add implicit points to follows to improve feed relevancy (in all algorithms) (#11513) 2020-11-25 16:09:51 -05:00
liquid_tags Add community_emoji to SiteConfig (#11450) 2020-11-17 14:02:04 -08:00
mailers Update trusted role email Subject (#11519) 2020-11-20 09:54:21 -06:00
models Improve error message of User Subscriptions (#11689) 2020-12-01 08:41:49 -08:00
policies [deploy] [Admin Tooling] Allow admins unpublish articles from the Mod Actions Panel (#10038) 2020-09-02 16:08:08 -05:00
queries/admin Add all new functionality for trusted (#10816) 2020-10-15 17:00:49 -04:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Disable ActionController auto params wrapping (#11692) 2020-12-02 15:17:43 +01:00
routing Redirect old settings routes to new ones (#11681) 2020-11-30 16:54:31 +01:00
serializers/search [deploy] Refactor:Remove Reaction Search Code (#10377) 2020-09-23 12:27:50 -05:00
services Move GeneratedImage to Images::GenerateSocialmage (#11691) 2020-12-02 11:03:14 +07:00
support Add implicit points to follows to improve feed relevancy (in all algorithms) (#11513) 2020-11-25 16:09:51 -05:00
system Adds ability for admins to create new tags via /admin/tags (#11240) 2020-12-02 08:12:57 -06:00
tasks Refactor:Send Welcome Broadcast Notifications From Sidekiq (#9923) 2020-08-21 12:57:08 -04:00
uploaders Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556) 2020-07-29 11:31:01 +02:00
view_objects Enable Rubocop 0.89 cops and fix Lint/ violations (#9709) 2020-08-10 16:57:12 +02:00
views Comments UI update (#11283) 2020-11-18 18:21:19 -05:00
workers Move LogWorkerQueueStats from labor to services (#11642) 2020-11-30 09:31:15 +07:00
rails_helper.rb Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
spec_helper.rb Manually load dotenv in test (#9971) 2020-08-24 20:19:03 +02:00