docbrown/app
Suzanne Aitchison 5bed8f56d4
improve keyboard accessibility of modals 12427 10610 (#12511)
* adds focusTrap wrapper to preact Modal component

* add view specific code for focus trap in admin add nav link

* add script to return a focustrap toggle, use in add nav link modal partial

* add trap to edit nav link modal

* add handlers for sign up modal

* update modal controller for admin section, update nav link modals to use

* update other admin modals with new data values for trap

* remove unneeded erb script file

* remove unneeded target

* refactor to remove extra unneeded param

* remove duplicate code, store getFocusTrapToggle in window

* trap focus in comment and bookmark showModal instances for not logged in user

* remove need for activator id

* clean up id refs no longer needed

* remove custom code and re-use focsu-trap lib

* update storybook docs

* update default export in focusTrap

* prevent close button click triggering a modal toggle twice

* ensure if user navigates from a modal the trap is deactivated

* add jsdoc comments and add dynamic import

* ensure admin controller modal traps are cleaned up on disconnect

* update sign up modal to use crayons

* update modal controller and admin nav links modals to use preact modal

* update profile fields modals for new controller

* tweak styling of sign up and admin modals to match previous

* update listings modal to use crayons modal, adapt focus trap to work with click outside

* memoize deactivate callback to ensure modal can be presented on first page load

* add missed focustrap changes

* fix focus trap issues in onboarding flow

* refactor onboarding focus trap, remove getFocusTrapToggle

* tweaks for styling and article modal toggle

* add click outside tests to modal

* add cypress tests for the login modal

* update liquid tag tests affected by change

* refactors to address review comments

* fix issue with login modal presented twice on comment add

* change ids to selectors in admin modals

* small pr comment refactors

* add listings e2e tests

* add nav link modal tests

* fix issue with help modal

* tweak to fix ui bug from merge

* remove context from showLoginModal

* rename toggleModal

* rename state property for clarity

Co-authored-by: Nick Taylor <nick@dev.to>
2021-02-24 16:01:10 +00:00
..
assets improve keyboard accessibility of modals 12427 10610 (#12511) 2021-02-24 16:01:10 +00:00
black_box
controllers Prevent banned users from using API (#12730) 2021-02-18 17:56:16 -05:00
decorators Fix profile field production display area functionality and remove SiteConfig.dev_to? hacks for better generalization (#12015) 2021-02-11 10:05:06 -05:00
errors Prevent suspended users from self-deleting and returning (#12503) 2021-02-11 09:28:59 +07:00
helpers Navigation Items and Role access for Data Update Scripts (#12292) 2021-02-09 17:41:14 +02:00
javascript improve keyboard accessibility of modals 12427 10610 (#12511) 2021-02-24 16:01:10 +00:00
lib Navigation Items and Role access for Data Update Scripts (#12292) 2021-02-09 17:41:14 +02:00
liquid_tags improve keyboard accessibility of modals 12427 10610 (#12511) 2021-02-24 16:01:10 +00:00
mailers Email confirmation to abuse reports (#12557) 2021-02-03 22:59:50 +03:00
middlewares
models Drop language settings columns (#12699) 2021-02-16 23:29:44 +07:00
policies Prevent banned users from using API (#12730) 2021-02-18 17:56:16 -05:00
queries/admin
refinements
sanitizers Video max width (#12436) 2021-01-26 15:12:37 +01:00
serializers Remove language settings (#12502) 2021-02-04 08:35:00 +07:00
services Prevent banned users from using API (#12730) 2021-02-18 17:56:16 -05:00
uploaders Refactor:Change Image Article Upload Path to uploads/articles (#12668) 2021-02-15 11:52:00 -06:00
validators
view_objects
views improve keyboard accessibility of modals 12427 10610 (#12511) 2021-02-24 16:01:10 +00:00
workers Extract page view updates into workers (#12686) 2021-02-17 09:24:05 +07:00