a8b7f6eea4
* Use proper auth chain before checking parameters * Refactor AnalyticsController * Add a bunch of test and rewrite reactions counts with a single query * Add tests for follows totals * Use round and add more refactoring * Add tests to group by day to fallback during refactoring * Use group by to calculate comments count by day * Use group by to calculate follows count by day * Use group by to calculate reactions stats by day * Use group by to calculate page_views stats by day * Move calculations per day back in the cached block * Add a few comments and a little bit of refactoring * Add indexes (concurrently) for analytics * Make tests more time robust * Use a date range cache related to the requesting user or org * Freezing time in UTC should help when tests are ran on time zones over the day line * Remove explicit returns * Page title is escaped, guard against that * Move Analytics service spec in the proper place
74 lines
2.3 KiB
Ruby
74 lines
2.3 KiB
Ruby
module Api
|
|
module V0
|
|
class AnalyticsController < ApiController
|
|
respond_to :json
|
|
|
|
rescue_from ArgumentError, with: :error_unprocessable_entity
|
|
rescue_from UnauthorizedError, with: :error_unauthorized
|
|
|
|
before_action :authenticate_with_api_key_or_current_user
|
|
before_action :authorize_pro_user
|
|
before_action :authorize_user_organization
|
|
before_action :load_owner
|
|
before_action :validate_date_params, only: [:historical]
|
|
|
|
def totals
|
|
analytics = AnalyticsService.new(@owner, article_id: analytics_params[:article_id])
|
|
data = analytics.totals
|
|
render json: data.to_json
|
|
end
|
|
|
|
def historical
|
|
analytics = AnalyticsService.new(
|
|
@owner,
|
|
start_date: params[:start], end_date: params[:end], article_id: params[:article_id],
|
|
)
|
|
data = analytics.grouped_by_day
|
|
render json: data.to_json
|
|
end
|
|
|
|
def past_day
|
|
analytics = AnalyticsService.new(
|
|
@owner, start_date: 1.day.ago, article_id: params[:article_id]
|
|
)
|
|
data = analytics.grouped_by_day
|
|
render json: data.to_json
|
|
end
|
|
|
|
private
|
|
|
|
def authorize_pro_user
|
|
raise UnauthorizedError unless @user&.has_role?(:pro)
|
|
end
|
|
|
|
def authorize_user_organization
|
|
return unless analytics_params[:organization_id]
|
|
|
|
@org = Organization.find_by(id: analytics_params[:organization_id])
|
|
raise UnauthorizedError unless @org && @user.org_member?(@org)
|
|
end
|
|
|
|
def load_owner
|
|
@owner = @org || @user
|
|
end
|
|
|
|
def validate_date_params
|
|
raise ArgumentError, "Required 'start' parameter is missing" if analytics_params[:start].blank?
|
|
raise ArgumentError, "Date parameters 'start' or 'end' must be in the format of 'yyyy-mm-dd'" unless valid_date_params?
|
|
end
|
|
|
|
def analytics_params
|
|
params.permit(:organization_id, :article_id, :start, :end)
|
|
end
|
|
|
|
def valid_date_params?
|
|
date_regex = /\A\d{4}-\d{1,2}-\d{1,2}\Z/ # for example, 2019-03-22 or 2019-2-1
|
|
if analytics_params[:end]
|
|
(analytics_params[:start] =~ date_regex)&.zero? && (analytics_params[:end] =~ date_regex)&.zero?
|
|
else
|
|
(analytics_params[:start] =~ date_regex)&.zero?
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|