docbrown/spec/services/feeds
Jeremy Friesen 4e76771867
Favoring User scope as parameter for feed fetching (#16763)
This change makes it easier to resolve forem/forem#16487.

What do I mean by that?  To address forem/forem#16487, I need to only
select user's who are authorized to create articles.  In
forem/forem#16732 I added a method that will allow chaining of a User
scope.  So with this current commit and forem/forem#16732, I'm
triangulating on an approach that will make that change easier.

I did not want to conflate those two, as mixing this PR's change and
what is necessary for the closing PR would create a more complicated
review.  Not unduly complicated, but one that will require more tests
and a change in logic.  And for someone reviewing the diff, those
concerns could easily be lost.

Yes, I have changed the method signature, but that method signature is
limited to one location:

```shell
❯ rg "Feeds::Import.call"

app/workers/feeds/import_articles_worker.rb
21:      ::Feeds::Import.call(users_scope: users_scope, earlier_than: earlier_than)
```

So I look to the method signature a bit as an internal API, hence the change.

Related to forem/forem#16487
2022-03-02 16:45:06 -05:00
..
assemble_article_markdown_spec.rb Use the rss item's url when handling relative image links (#15497) 2021-12-09 14:08:54 -06:00
clean_html_spec.rb Move HtmlCleaner from app/labor into service (#11609) 2020-11-27 08:21:57 +07:00
import_spec.rb Favoring User scope as parameter for feed fetching (#16763) 2022-03-02 16:45:06 -05:00
validate_url_spec.rb Add missing features to new feed importer (#11501) 2020-11-24 18:11:13 +01:00