692243ab50
* Allow admins to suggest default users to follow during onboarding Allows the onboarding "follow users" slide to be configured by admins. Closes https://github.com/thepracticaldev/dev.to/issues/7106. * Remove redundant safety checks, refactor specs * Add explicit note about how suggested users are used in onboarding * Some configs_controller cleanup and fix copypasta in configs/show template * Fetch SiteConfig.suggested_users via before_action * Use presence instead of empty?
85 lines
2.5 KiB
Ruby
85 lines
2.5 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "Users", type: :request do
|
|
describe "GET /users" do
|
|
let(:user) { create(:user) }
|
|
let!(:suggested_users_list) { %w[eeyore] }
|
|
let!(:suggested_user) { create(:user, name: "Eeyore", username: "eeyore", summary: "I am always sad :(") }
|
|
|
|
before do
|
|
allow(SiteConfig).to receive(:suggested_users).and_return(suggested_users_list)
|
|
end
|
|
|
|
context "when no state params are present" do
|
|
it "returns no users" do
|
|
sign_in user
|
|
get users_path
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.parsed_body).to be_empty
|
|
end
|
|
end
|
|
|
|
context "when follow_suggestions params are present and no suggestions are found" do
|
|
it "returns the default suggested_users from SiteConfig if they are present" do
|
|
sign_in user
|
|
|
|
get users_path(state: "follow_suggestions")
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.parsed_body.first).to include(
|
|
"id" => suggested_user.id,
|
|
"name" => suggested_user.name,
|
|
"username" => suggested_user.username,
|
|
"summary" => suggested_user.summary,
|
|
"profile_image_url" => ProfileImage.new(suggested_user).get(width: 90),
|
|
"following" => false,
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when follow_suggestions params are present" do
|
|
it "returns follow suggestions for an authenticated user" do
|
|
user = create(:user)
|
|
tag = create(:tag)
|
|
user.follow(tag)
|
|
|
|
other_user = create(:user)
|
|
create(:article, user: other_user, tags: [tag.name])
|
|
|
|
sign_in user
|
|
|
|
get users_path(state: "follow_suggestions")
|
|
|
|
response_user = response.parsed_body.first
|
|
expect(response_user["id"]).to eq(other_user.id)
|
|
end
|
|
|
|
it "returns follow suggestions that have profile images" do
|
|
user = create(:user)
|
|
tag = create(:tag)
|
|
user.follow(tag)
|
|
|
|
other_user = create(:user)
|
|
create(:article, user: other_user, tags: [tag.name])
|
|
|
|
sign_in user
|
|
|
|
get users_path(state: "follow_suggestions")
|
|
|
|
response_user = response.parsed_body.first
|
|
expect(response_user["profile_image_url"]).to eq(other_user.profile_image_url)
|
|
end
|
|
end
|
|
|
|
context "when sidebar_suggestions params are present" do
|
|
it "returns no sidebar suggestions for an authenticated user" do
|
|
sign_in create(:user)
|
|
|
|
get users_path(state: "sidebar_suggestions")
|
|
|
|
expect(response.parsed_body).to be_empty
|
|
end
|
|
end
|
|
end
|
|
end
|