docbrown/app/javascript/topNavigation/__tests__/utilities.test.js
Marcy Sutton f072730f0f
Header navigation dropdown accessibility (#11509)
* Improve keyboard a11y of header menu dropdown

This commit also includes some cleanup of unnecessary functions that seemed to degrade performance.

Closes https://github.com/forem/forem/issues/1154

* Add temporary focus style on navigation-button

* Put menu items in a list

* Adjust menu button based on VoiceOver testing

* Refactor menu logic to be reusable/work on touch

* Preserve admin link visibility

* Focus on first item on menu open

* Clean up some HTML and CSS

* Apply suggestions from code review

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Ensure menu hides on click outside

* Rename toggle function and adjust formatting

* Update nav button focus style

* Clean up padding on header avatar focus style

* Make button show focus state for keyboard only

Using .focus-visible:focus targets keyboard focus and eliminates a flash of the blue border on click before focus is moved to the child item (which also has no focus style on mouse click)

* Update app/views/layouts/_top_bar.html.erb

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Add some defensive programming

* Removed initializeTouchDevice from base.js.erb

* navigation-butt ID is now member-menu-button

* Moved all the logic from initializeTouchDevice.js into a pack file/utilities.

* committing re-ordered schema after setup

* add tests for initializeTouchDevice

* remove some unneeded html setup

* make sure menu doesn't close if user tabs back from sign out

* Revert "committing re-ordered schema after setup"

This reverts commit a41a1c861cca3b97d8a7b8a99268b8afaae9f028.

* optimized code

* small tweaks, only show outline when focused

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Nick Taylor <nick@dev.to>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-01-27 09:39:17 +00:00

247 lines
8.7 KiB
JavaScript

// TODO: Once this is merged, PR up the removal of this and in other tests and move it to testSetup.js
import '@testing-library/jest-dom';
import {
getByTestId,
getByLabelText,
getByText,
fireEvent,
waitFor,
} from '@testing-library/dom';
import {
getInstantClick,
initializeMobileMenu,
setCurrentPageIconLink,
initializeTouchDevice,
} from '../utilities';
// TODO: ★★★ These tests should be promoted to E2E tests once we have that in place. ★★★
describe('top navigation utilitities', () => {
beforeEach(() => {
// Recreating the body element completely so as to remove any CSS classes
// that were added to it.
document.body = document.createElement('body');
});
describe('getInstantClick', () => {
it('should fail if not found in the alloted time.', async () => {
await expect(getInstantClick(50)).rejects.toEqual(
new Error('Unable to resolve InstantClick'),
);
});
it('should resolve InstantClick.', async () => {
global.InstantClick = {};
expect(await getInstantClick(50)).toEqual(InstantClick);
delete global.InstantClick;
});
});
describe('initializeMobileMenu', () => {
it('should open the hamburger menu', () => {
document.body.innerHTML = `
<button aria-label="nav-button-left" class="crayons-btn crayons-btn--ghost crayons-btn--icon-rounded js-hamburger-trigger inline-block m:hidden mx-2">
<svg><title>Navigation menu</title></svg>
</button>
`;
const navButton = getByLabelText(document.body, 'nav-button-left');
initializeMobileMenu([navButton], []);
expect(document.body).not.toHaveClass('hamburger-open');
navButton.click();
expect(document.body).toHaveClass('hamburger-open');
});
it('should close the hamburger menu', () => {
document.body.innerHTML = `
<button aria-label="nav-button-left" class="crayons-btn crayons-btn--ghost crayons-btn--icon-rounded js-hamburger-trigger inline-block m:hidden mx-2">
<svg><title>Navigation menu</title></svg>
</button>
`;
const navButton = getByLabelText(document.body, 'nav-button-left');
initializeMobileMenu([navButton], []);
expect(document.body).not.toHaveClass('hamburger-open');
navButton.click();
expect(document.body).toHaveClass('hamburger-open');
navButton.click();
expect(document.body).not.toHaveClass('hamburger-open');
});
it('should open the more menu', () => {
document.body.innerHTML = `
<a href="javascript:void(0)" class="crayons-link crayons-link--secondary crayons-link--block crayons-link--block--indented fs-s js-nav-more-trigger">More...</a>
<div class="hidden js-nav-more spec-nav-more">
<div class="flex justify-around p-4 mt-4 border-solid border-0 border-t-1 border-base-10">
</div>
</div>
`;
const navMoreLink = getByText(document.body, 'More...');
initializeMobileMenu([], [navMoreLink]);
navMoreLink.click();
expect(navMoreLink).toHaveClass('hidden');
});
});
describe('setCurrentPageIconLink', () => {
it('should set the current page icon', () => {
document.body.innerHTML = `
<a href="/connect" id="connect-link" class="crayons-header__link crayons-btn crayons-btn--ghost crayons-btn--icon-rounded" aria-label="Connect"></a>
<a href="/notifications" id="notifications-link" class="crayons-header__link crayons-btn crayons-btn--ghost crayons-btn--icon-rounded" aria-label="Notifications"></a>
`;
const connectLink = getByLabelText(document.body, 'Connect');
const notificationsLink = getByLabelText(document.body, 'Notifications');
const pageEntries = Object.entries({
'page-1': connectLink,
'page-2': notificationsLink,
});
const page = 'page-1';
setCurrentPageIconLink(page, pageEntries);
expect(connectLink).toHaveClass('crayons-header__link--current');
expect(notificationsLink).not.toHaveClass(
'crayons-header__link--current',
);
});
it('should set the current page icon and remove the previous current page icon styling', () => {
document.body.innerHTML = `
<a href="/connect" id="connect-link" class="crayons-header__link crayons-btn crayons-btn--ghost crayons-btn--icon-rounded" aria-label="Connect"></a>
<a href="/notifications" id="notifications-link" class="crayons-header__link crayons-header__link--current crayons-btn crayons-btn--ghost crayons-btn--icon-rounded" aria-label="Notifications"></a>
`;
const connectLink = getByLabelText(document.body, 'Connect');
const notificationsLink = getByLabelText(document.body, 'Notifications');
const pageEntries = Object.entries({
'page-1': connectLink,
'page-2': notificationsLink,
});
const page = 'page-1';
setCurrentPageIconLink(page, pageEntries);
expect(connectLink).toHaveClass('crayons-header__link--current');
expect(notificationsLink).not.toHaveClass(
'crayons-header__link--current',
);
});
});
describe('initializeTouchDevice', () => {
const initialMenuHTML = `
<div class="crayons-header__menu" id="crayons-header__menu" data-testid="menu-dropdown">
<button type="button" class="crayons-header__menu__trigger" id="member-menu-button" aria-label="Navigation menu">
<span class="crayons-avatar crayons-avatar--l"><img class="crayons-avatar__image" alt="" id="nav-profile-image" src=""></span>
</button>
<div class="crayons-dropdown left-2 right-2 s:right-4 s:left-auto p-0 crayons-header__menu__dropdown inline-block">
<ul class="p-0" id="crayons-header__menu__dropdown__list">
<li id="user-profile-link-placeholder" class="border-0 border-b-1 border-solid border-base-20 p-1 mb-1">
<a id="first-nav-link" class="crayons-link crayons-link--block" href="">
</a>
</li>
<li class="px-1 py-1">
<a href="/signout_confirm" class="crayons-link crayons-link--block" id="last-nav-link">Sign Out</a>
</li>
</ul>
</div>
</div>
`;
it('toggles dropdown menu expanded state', async () => {
document.body.innerHTML = initialMenuHTML;
const menuNavButton = getByLabelText(document.body, 'Navigation menu');
const memberMenu = getByTestId(document.body, 'menu-dropdown');
initializeTouchDevice(memberMenu, menuNavButton);
await waitFor(() =>
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('false'),
);
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('false');
expect(memberMenu).not.toHaveClass('showing');
fireEvent.click(menuNavButton);
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('true');
expect(memberMenu).toHaveClass('showing');
fireEvent.click(menuNavButton);
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('false');
expect(memberMenu).not.toHaveClass('showing');
});
it('closes menu on Escape key', async () => {
document.body.innerHTML = initialMenuHTML;
const menuNavButton = getByLabelText(document.body, 'Navigation menu');
const memberMenu = getByTestId(document.body, 'menu-dropdown');
initializeTouchDevice(memberMenu, menuNavButton);
await waitFor(() =>
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('false'),
);
fireEvent.click(menuNavButton);
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('true');
expect(memberMenu).toHaveClass('showing');
fireEvent.keyUp(memberMenu, { key: 'Escape' });
await waitFor(() =>
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('false'),
);
expect(memberMenu).not.toHaveClass('showing');
});
it('closes the menu on click outside', async () => {
document.body.innerHTML = `
<div data-testid="container">
${initialMenuHTML}
</div>
`;
const menuNavButton = getByLabelText(document.body, 'Navigation menu');
const memberMenu = getByTestId(document.body, 'menu-dropdown');
const outerWrapper = getByTestId(document.body, 'container');
initializeTouchDevice(memberMenu, menuNavButton);
await waitFor(() =>
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('false'),
);
fireEvent.click(menuNavButton);
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('true');
expect(memberMenu).toHaveClass('showing');
fireEvent.click(outerWrapper);
await waitFor(() =>
expect(menuNavButton.getAttribute('aria-expanded')).toEqual('false'),
);
expect(memberMenu).not.toHaveClass('showing');
});
});
});