docbrown/app/controllers/notifications_controller.rb
rhymes f7d6874956 Paginate notifications (#3948)
* Use offset instead of page and explain things

* Make load more button work

* Add tests for admin view

* Restore the previous logged out behavior

* Modernize initNotifications.js

* Revert "Modernize initNotifications.js"

This reverts commit 4a112b797d7911c4ab63ad0c0a07111b4e7abe25.

* Fix elements presence errors

* Change load-more-button to only appear if 7 or more posts (and some notification copy adjustments)
2019-09-07 11:54:30 -04:00

79 lines
3.2 KiB
Ruby

class NotificationsController < ApplicationController
# No authorization required because we provide authentication on notifications page
def index
return unless user_signed_in?
@notifications_index = true
@user = user_to_view
# NOTE: this controller is using offset based pagination by assuming that
# the id of the last notification also corresponds to the newest `notified_at`
# this might not be forever true but it's good enough for now
if params[:offset]
num = 30
notified_at_offset = Notification.find(params[:offset])&.notified_at
else
num = 8
end
@notifications = if (params[:org_id].present? || params[:filter] == "org") && allowed_user?
organization_notifications
elsif params[:org_id].blank? && params[:filter].present?
filtered_notifications
else
Notification.where(user_id: @user.id).order("notified_at DESC")
end
# if offset based pagination is invoked by the frontend code, we filter out all earlier ones
@notifications = @notifications.where("notified_at < ?", notified_at_offset) if notified_at_offset
@notifications = NotificationDecorator.decorate_collection(@notifications.limit(num))
@last_user_reaction = @user.reactions.last&.id
@last_user_comment = @user.comments.last&.id
@organizations = @user.member_organizations if @user.organizations
# The first call, the one coming from the browser URL bar will render the "index" view, which renders
# the first few notifications. After that the JS frontend code (see `initNotification.js`)
# will call this action again by sending the offset id for the last known notifications, the result
# will be the partial rendering of only the list of notifications that will be attached to the DOM by JS
render partial: "notifications_list" if notified_at_offset
end
private
def user_to_view
if params[:username] && current_user.admin?
User.find_by(username: params[:username])
else
current_user
end
end
def filtered_notifications
if params[:filter].to_s.casecmp("posts").zero?
Notification.where(user_id: @user.id, notifiable_type: "Article", action: "Published").
order("notified_at DESC")
elsif params[:filter].to_s.casecmp("comments").zero?
Notification.where(user_id: @user.id, notifiable_type: "Comment", action: nil). # Nil action means not reaction in this context
or(Notification.where(user_id: @user.id, notifiable_type: "Mention")).
order("notified_at DESC")
end
end
def organization_notifications
if params[:filter].to_s.casecmp("comments").zero?
Notification.where(organization_id: params[:org_id], notifiable_type: "Comment", action: nil, user_id: nil). # Nil action means not reaction in this context
or(Notification.where(organization_id: params[:org_id], notifiable_type: "Mention", user_id: nil)).
order("notified_at DESC")
else
Notification.where(organization_id: params[:org_id], user_id: nil).
order("notified_at DESC")
end
end
def allowed_user?
@user.organization_id == params[:org_id] || @user.admin?
end
end