* schema file undelete description * feat: v1 of the script * Flesh out remaining enums under their categories * complete UsersSettings data update script * complete DUS for relevant attributes in users and profiles tables * complete DUS for users_notification_settings * alphabetize user_settings sql file * safeguard against null values for "null: false" settings * Set up actual UsersSettings DUS and specs files * fix broken DUS script * complete specs for UsersSetting DUS * Address QA of specs * complete specs for users_notification_settings DUS * fix the typos (thanks Julianna!) * begin implementation * still building * add missing attribute "email_membership_newsletter" * complete sync code (except race condition for user profile) * complete implementation, remains tests * Address PR review and fix Travis fails * remove superfluous Profile.new * fix travis fails * feat: update the users_notification_setting attributes from the user model * feat: use the config fonts enums to display the fonts * feat: loop through the keys * fix profile = nil blowing up; add specs for notification_setting model * remove unneeded spec * remove feed validation until after sync code removed; fixes feed_import spec failures * remove spec associated with feed_url validation in user_setting model * fix failing spec 😅 * add TODO * feat: set the user settings in the user controller and use it in the customization form * feat: move some update logic to the users settings controller thats being used from customization * feat: show the updated values form the users_settingd and not the user instance * Generalize redirect back to current tab * still trying to reflect changed theme upon refresh * customizations take effect on refresh * remove 'with_feed' scope from user model Co-authored-by: Jamie Gaskins <jamie@forem.com> * start with takeover for fields previously in profiles table * Takeover code for `publishing_from_rss` section in Settings (#13914) * implement takeover code part 1 * implement takeover code * fix feed fetch * need rhymes help * complete implementation; specs pending * fix STUPID omission that caused so many headaches 😫 * implement profile fields pointing to users_settings 🎉 * run migrations * implement inbox type & guidelines takeover code; specs pending (#13911) * Point changes in notification settings to `users_notification_settings` table (#13910) * implement takeover code; remains specs * address PR feedback; remove related sync code * address PR review feedback * need help with routing and specs * address pr review * addressing pr review * Treat implementation edge cases and omissions 😅 * fix uncommented comment * fixing implementation cases * address more PR review feedback * fixing notifications use-cases * refactor settings controller * more pr review changes * solving bugs * fix broken onboarding * handle eperience_level calls * more fixes * remove unneeded mappings * add To-dos for quety updates * remove done TODO * purge done TODOs * update notification_settings-related queries * start fixing specs * fixing specs * fix notification and lrg_forem specs * fixing broken specs * still fixing * fix line dif and remove reloads from user.rb * run specs * silence bullet and other fixes * remove setting migration scripts and specs, fix more settings for specs * handle missing user for article builder and fix notification specs * fix some final controller specs and re-add incorrectly removed specs * remove deprecated data update scripts and related workers, put travis back * refactor admin tags mods controller, write/move specs for users notifications settings controller * schema cleanup and other small refactors for consistency * set field we can invalidate in spec via active record instead of at the db level * remove I think an uneccessary hook call from subscribe_to_mailchimp_newsletter * use bnefore_create to setup settings, please dont blow up the test suite * mailchimp bot fix * remove decorator in favor of single model method Co-authored-by: Arit Amana <msarit@gmail.com> Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com> Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com> Co-authored-by: Jamie Gaskins <jamie@forem.com>
151 lines
4.8 KiB
Ruby
151 lines
4.8 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe Articles::Builder, type: :service do
|
|
let(:user) { create(:user) }
|
|
let(:tag) { nil }
|
|
let(:prefill) { nil }
|
|
|
|
context "when tag_user_editor_v2" do
|
|
let(:user) { create(:user) }
|
|
let(:tag) { create(:tag) }
|
|
let(:submission_template) { tag.submission_template_customized(user.name).to_s }
|
|
let(:correct_attributes) do
|
|
{
|
|
body_markdown: submission_template.split("---").last.to_s.strip,
|
|
cached_tag_list: tag.name,
|
|
processed_html: "",
|
|
user_id: user.id,
|
|
title: submission_template.split("title:")[1].to_s.split("\n")[0].to_s.strip
|
|
}
|
|
end
|
|
|
|
it "initializes an article with the correct attributes and needs authorization" do
|
|
subject, needs_authorization = described_class.call(user, tag, prefill)
|
|
|
|
expect(subject).to be_an_instance_of(Article)
|
|
expect(subject).to have_attributes(correct_attributes)
|
|
expect(needs_authorization).to be true
|
|
end
|
|
end
|
|
|
|
context "when tag_user" do
|
|
let(:tag) { create(:tag, submission_template: "submission_template") }
|
|
let(:correct_attributes) do
|
|
{
|
|
body_markdown: tag.submission_template_customized(user.name),
|
|
processed_html: "",
|
|
user_id: user.id
|
|
}
|
|
end
|
|
|
|
it "initializes an article with the correct attributes and needs authorization" do
|
|
subject, needs_authorization = described_class.call(user, tag, prefill)
|
|
|
|
expect(subject).to be_an_instance_of(Article)
|
|
expect(subject).to have_attributes(correct_attributes)
|
|
expect(needs_authorization).to be true
|
|
end
|
|
end
|
|
|
|
context "when prefill_user_editor_v2" do
|
|
let(:user) { create(:user) }
|
|
let(:prefill) { "dsdweewewew" }
|
|
let(:correct_attributes) do
|
|
{
|
|
body_markdown: prefill.split("---").last.to_s.strip,
|
|
cached_tag_list: prefill.split("tags:")[1].to_s.split("\n")[0].to_s.strip,
|
|
processed_html: "",
|
|
user_id: user.id,
|
|
title: prefill.split("title:")[1].to_s.split("\n")[0].to_s.strip
|
|
}
|
|
end
|
|
|
|
it "initializes an article with the correct attributesand needs authorization" do
|
|
subject, needs_authorization = described_class.call(user, tag, prefill)
|
|
|
|
expect(subject).to be_an_instance_of(Article)
|
|
expect(subject).to have_attributes(correct_attributes)
|
|
expect(needs_authorization).to be true
|
|
end
|
|
end
|
|
|
|
context "when prefill_user" do
|
|
let(:prefill) { "dsdweewewew" }
|
|
let(:correct_attributes) do
|
|
{
|
|
body_markdown: prefill,
|
|
processed_html: "",
|
|
user_id: user.id
|
|
}
|
|
end
|
|
|
|
it "initializes an article with the correct attributes and needs authorization" do
|
|
subject, needs_authorization = described_class.call(user, tag, prefill)
|
|
|
|
expect(subject).to be_an_instance_of(Article)
|
|
expect(subject).to have_attributes(correct_attributes)
|
|
expect(needs_authorization).to be true
|
|
end
|
|
end
|
|
|
|
context "when tag" do
|
|
let(:user) { create(:user) }
|
|
let(:tag) { create(:tag) }
|
|
let(:correct_attributes) do
|
|
{
|
|
body_markdown: "---\ntitle: \npublished: false\ndescription: \ntags: #{tag.name}\n---\n\n",
|
|
processed_html: "",
|
|
user_id: user.id
|
|
}
|
|
end
|
|
|
|
it "initializes an article with the correct attributes and does not need authorization" do
|
|
user.setting.update(editor_version: "v1")
|
|
subject, needs_authorization = described_class.call(user, tag, prefill)
|
|
|
|
expect(subject).to be_an_instance_of(Article)
|
|
expect(subject).to have_attributes(correct_attributes)
|
|
expect(needs_authorization).to be false
|
|
end
|
|
end
|
|
|
|
context "when user_editor_v2" do
|
|
let(:user) { create(:user) }
|
|
let(:correct_attributes) do
|
|
{
|
|
user_id: user.id
|
|
}
|
|
end
|
|
|
|
it "initializes an article with the correct attributes and does not need authorization" do
|
|
subject, needs_authorization = described_class.call(user, tag, prefill)
|
|
|
|
expect(subject).to be_an_instance_of(Article)
|
|
expect(subject).to have_attributes(correct_attributes)
|
|
expect(needs_authorization).to be false
|
|
end
|
|
end
|
|
|
|
context "when user_editor_v1" do
|
|
let(:user) { create(:user) }
|
|
let(:correct_attributes) do
|
|
body = "---\ntitle: \npublished: false\ndescription: \ntags: " \
|
|
"\n//cover_image: https://direct_url_to_image.jpg\n---\n\n"
|
|
|
|
{
|
|
body_markdown: body,
|
|
processed_html: "",
|
|
user_id: user.id
|
|
}
|
|
end
|
|
|
|
it "initializes an article with the correct attributes and does not need authorization" do
|
|
user.setting.update(editor_version: "v1")
|
|
subject, needs_authorization = described_class.call(user, tag, prefill)
|
|
|
|
expect(subject).to be_an_instance_of(Article)
|
|
expect(subject).to have_attributes(correct_attributes)
|
|
expect(needs_authorization).to be false
|
|
end
|
|
end
|
|
end
|