* Favoring single SQL and computation over enum Prior to this commit, we ran a SQL statement to generate a list of articles then applied some minor randomization. With this commit, I'm removing the randomization in favor of expected values, and collapsing the result set into a single inline SQL and some post query simple arithmatic. Let's check my math. For each article we sum: * `article.score` * `article.comments_count` * 14 * a random number between 0 and 5 (`rand(6)`) with expected value of 2.5 * the tag's (taggings_count + 1) / 2 The new SQL query sums the `article.score` and the `article.comments_count` * 14. I then reduce the remainder of the equation. From "for each article sum `(rand(5) + (taggings_count + 1) / 2)`" we have the following: `article_count * (2.5 + (taggings_count + 1) / 2)` Which is equivalent to: `article_count * ((taggings_count + 1 + (2.5 * 2)) / 2)` Which is equivalent to: `article_count * ((taggings_count + 6) / 2)` This change reduces computation time by favoring expected values. * Fixing broken behavior and adding comments
141 lines
4.6 KiB
Ruby
141 lines
4.6 KiB
Ruby
class Tag < ActsAsTaggableOn::Tag
|
|
self.ignored_columns = %w[mod_chat_channel_id].freeze
|
|
|
|
attr_accessor :points, :tag_moderator_id, :remove_moderator_id
|
|
|
|
acts_as_followable
|
|
resourcify
|
|
|
|
# This model doesn't inherit from ApplicationRecord so this has to be included
|
|
include Purgeable
|
|
include PgSearch::Model
|
|
|
|
ALLOWED_CATEGORIES = %w[uncategorized language library tool site_mechanic location subcommunity].freeze
|
|
HEX_COLOR_REGEXP = /\A#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})\z/
|
|
|
|
belongs_to :badge, optional: true
|
|
|
|
has_many :articles, through: :taggings, source: :taggable, source_type: "Article"
|
|
|
|
has_one :sponsorship, as: :sponsorable, inverse_of: :sponsorable, dependent: :destroy
|
|
|
|
mount_uploader :profile_image, ProfileImageUploader
|
|
mount_uploader :social_image, ProfileImageUploader
|
|
|
|
validates :text_color_hex, format: HEX_COLOR_REGEXP, allow_nil: true
|
|
validates :bg_color_hex, format: HEX_COLOR_REGEXP, allow_nil: true
|
|
validates :category, presence: true, inclusion: { in: ALLOWED_CATEGORIES }
|
|
|
|
validate :validate_alias_for, if: :alias_for?
|
|
validate :validate_name, if: :name?
|
|
|
|
before_validation :evaluate_markdown
|
|
before_validation :pound_it
|
|
|
|
before_save :calculate_hotness_score
|
|
before_save :mark_as_updated
|
|
|
|
after_commit :bust_cache
|
|
|
|
pg_search_scope :search_by_name,
|
|
against: :name,
|
|
using: { tsearch: { prefix: true } }
|
|
|
|
scope :eager_load_serialized_data, -> {}
|
|
scope :supported, -> { where(supported: true) }
|
|
|
|
# possible social previews templates for articles with a particular tag
|
|
def self.social_preview_templates
|
|
Rails.root.join("app/views/social_previews/articles").children.map { |ch| File.basename(ch, ".html.erb") }
|
|
end
|
|
|
|
def submission_template_customized(param_0 = nil)
|
|
submission_template&.gsub("PARAM_0", param_0)
|
|
end
|
|
|
|
def tag_moderator_ids
|
|
User.with_role(:tag_moderator, self).order(id: :asc).ids
|
|
end
|
|
|
|
def self.valid_categories
|
|
ALLOWED_CATEGORIES
|
|
end
|
|
|
|
def self.aliased_name(word)
|
|
tag = find_by(name: word.downcase)
|
|
return unless tag
|
|
|
|
tag.alias_for.presence || tag.name
|
|
end
|
|
|
|
def self.find_preferred_alias_for(word)
|
|
find_by(name: word.downcase)&.alias_for.presence || word.downcase
|
|
end
|
|
|
|
def validate_name
|
|
errors.add(:name, "is too long (maximum is 30 characters)") if name.length > 30
|
|
# [:alnum:] is not used here because it supports diacritical characters.
|
|
# If we decide to allow diacritics in the future, we should replace the
|
|
# following regex with [:alnum:].
|
|
errors.add(:name, "contains non-alphanumeric characters") unless name.match?(/\A[[:alnum:]]+\z/i)
|
|
end
|
|
|
|
def errors_as_sentence
|
|
errors.full_messages.to_sentence
|
|
end
|
|
|
|
private
|
|
|
|
def evaluate_markdown
|
|
self.rules_html = MarkdownProcessor::Parser.new(rules_markdown).evaluate_markdown
|
|
self.wiki_body_html = MarkdownProcessor::Parser.new(wiki_body_markdown).evaluate_markdown
|
|
end
|
|
|
|
# @note The following implementation echoes the past hotness score,
|
|
# but favors expected values instead of random numbers for
|
|
# each article (see SHA
|
|
# 98e97e7aa8e0fc163cd7d9b063f51f01ab10a189).
|
|
def calculate_hotness_score
|
|
# SELECT
|
|
# (SUM(comments_count) * 14 + SUM(score)) AS partial_score,
|
|
# COUNT(id) AS article_count
|
|
# FROM articles
|
|
# WHERE
|
|
# (cached_tag_list ~ '[[:<:]]javascript[[:>:]]')
|
|
# AND (articles.featured_number > 1639594999)
|
|
#
|
|
# Due to the construction of the query, there will be one entry.
|
|
# Furthermore, we need to first convert to an array then call
|
|
# `.first`. The ActiveRecord query handler is ill-prepared to
|
|
# call "first" on this.
|
|
score_attributes = Article.cached_tagged_with(name)
|
|
.where("articles.featured_number > ?", 7.days.ago.to_i)
|
|
.select("(SUM(comments_count) * 14 + SUM(score)) AS partial_score, COUNT(id) AS article_count")
|
|
.to_a
|
|
.first
|
|
|
|
self.hotness_score =
|
|
score_attributes.partial_score.to_i +
|
|
(score_attributes.article_count.to_i * ((taggings_count + 6) / 2))
|
|
end
|
|
|
|
def bust_cache
|
|
Tags::BustCacheWorker.perform_async(name)
|
|
Rails.cache.delete("view-helper-#{name}/tag_colors")
|
|
end
|
|
|
|
def validate_alias_for
|
|
return if Tag.exists?(name: alias_for)
|
|
|
|
errors.add(:tag, "alias_for must refer to an existing tag")
|
|
end
|
|
|
|
def pound_it
|
|
text_color_hex&.prepend("#") unless text_color_hex&.starts_with?("#") || text_color_hex.blank?
|
|
bg_color_hex&.prepend("#") unless bg_color_hex&.starts_with?("#") || bg_color_hex.blank?
|
|
end
|
|
|
|
def mark_as_updated
|
|
self.updated_at = Time.current # Acts-as-taggable didn't come with this by default
|
|
end
|
|
end
|