* Bypass recaptcha for authenticated users abuse reports * Moves bypass_recaptcha? to helper method to have one definition of the criteria for this * User must be 1 month old at least in order to bypass_recaptcha? * Fixes test * Better spec message * Bypasses auditable users * Adds better test coverage over recaptcha bypass cases * include Helper removed from FeedbackMessagesController * Adds some inline comments for clarity and banned check
43 lines
1.4 KiB
Ruby
43 lines
1.4 KiB
Ruby
class FeedbackMessagesController < ApplicationController
|
|
# No authorization required for entirely public controller
|
|
skip_before_action :verify_authenticity_token
|
|
|
|
def create
|
|
flash.clear
|
|
rate_limit!(:feedback_message_creation)
|
|
|
|
params = feedback_message_params.merge(reporter_id: current_user&.id)
|
|
@feedback_message = FeedbackMessage.new(params)
|
|
|
|
recaptcha_disabled = ReCaptcha.call(current_user).disabled?
|
|
if (recaptcha_disabled || recaptcha_verified?) && @feedback_message.save
|
|
Slack::Messengers::Feedback.call(
|
|
user: current_user,
|
|
type: feedback_message_params[:feedback_type],
|
|
category: feedback_message_params[:category],
|
|
reported_url: feedback_message_params[:reported_url],
|
|
message: feedback_message_params[:message],
|
|
)
|
|
rate_limiter.track_limit_by_action(:feedback_message_creation)
|
|
|
|
redirect_to feedback_messages_path
|
|
else
|
|
@previous_message = feedback_message_params[:message]
|
|
|
|
flash[:notice] = "Make sure the forms are filled 🤖"
|
|
render "pages/report_abuse"
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def recaptcha_verified?
|
|
recaptcha_params = { secret_key: SiteConfig.recaptcha_secret_key }
|
|
params["g-recaptcha-response"] && verify_recaptcha(recaptcha_params)
|
|
end
|
|
|
|
def feedback_message_params
|
|
allowed_params = %i[message feedback_type category reported_url]
|
|
params.require(:feedback_message).permit(allowed_params)
|
|
end
|
|
end
|