docbrown/spec/requests/comments_spec.rb

259 lines
9.1 KiB
Ruby

require "rails_helper"
require "requests/shared_examples/comment_hide_or_unhide_request"
RSpec.describe "Comments", type: :request do
let(:user) { create(:user) }
let(:article) { create(:article, user_id: user.id) }
let(:podcast) { create(:podcast) }
let(:podcast_episode) { create(:podcast_episode, podcast_id: podcast.id) }
let(:comment) do
create(:comment,
commentable_id: article.id,
commentable_type: "Article",
user_id: user.id)
end
let(:podcast_comment) do
create(:comment,
commentable_id: podcast_episode.id,
commentable_type: "PodcastEpisode",
user_id: user.id)
end
describe "GET comment index" do
it "returns 200" do
get comment.path
expect(response).to have_http_status(:ok)
end
it "displays a comment" do
get comment.path
expect(response.body).to include(comment.processed_html)
end
it "displays full discussion text" do
get comment.path
expect(response.body).to include("FULL DISCUSSION")
end
context "when the comment is a root" do
it "does not display top of thread button" do
get comment.path
expect(response.body).not_to include("TOP OF THREAD")
end
it "displays the comment hidden message if the comment is hidden" do
comment.update(hidden_by_commentable_user: true)
get comment.path
hidden_comment_message = "Comment hidden by post author - thread only visible in this permalink"
expect(response.body).to include(hidden_comment_message)
end
it "displays the comment anyway if it is hidden" do
comment.update(hidden_by_commentable_user: true)
get comment.path
expect(response.body).to include(comment.processed_html)
end
end
context "when the comment is a child comment" do
let(:child) { create(:comment, parent_id: comment.id, commentable: article, user_id: user.id) }
it "displays proper button and text for child comment" do
get child.path
expect(response.body).to include("TOP OF THREAD")
expect(response.body).to include(CGI.escapeHTML(comment.title(150)))
expect(response.body).to include(child.processed_html)
end
it "does not display the comment if it is hidden" do
child.update(hidden_by_commentable_user: true)
get comment.path
expect(response.body).not_to include child.processed_html
end
end
context "when the comment is two levels nested and hidden" do # child of a child
let(:child) { create(:comment, parent_id: comment.id, commentable: article, user_id: user.id) }
let(:child_of_child) { create(:comment, parent_id: child.id, commentable: article, user_id: user.id, hidden_by_commentable_user: true) }
it "does not display the hidden comment in the child's permalink" do
get child.path
expect(response.body).not_to include(child_of_child.processed_html)
end
it "does not display the hidden comment in the article's comments section" do
get "#{article.path}/comments"
expect(response.body).not_to include(child_of_child.processed_html)
end
end
context "when the comment is a sibling of a child comment and is hidden" do
let(:child) { create(:comment, parent_id: comment.id, commentable: article, user_id: user.id) }
let(:sibling) { create(:comment, parent_id: comment.id, commentable: article, user_id: user.id, hidden_by_commentable_user: true) }
it "does not display the hidden comment in the article's comments section" do
get "#{article.path}/comments"
expect(response.body).not_to include(sibling.processed_html)
end
it "shows the hidden comments message in the comment's permalink" do
get sibling.path
hidden_comment_message = "Comment hidden by post author - thread only visible in this permalink"
expect(response.body).to include(hidden_comment_message)
end
it "does not show the sibling comment in the child's comment permalink" do
get child.path
expect(response.body).not_to include(sibling.processed_html)
end
it "shows the comment in the permalink" do
get sibling.path
expect(response.body).to include(sibling.processed_html)
end
end
context "when the comment is three levels nested and hidden" do # child of a child of a child
let(:child) { create(:comment, parent_id: comment.id, commentable: article, user_id: user.id) }
let(:second_level_child) { create(:comment, parent_id: child.id, commentable: article, user_id: user.id) }
let(:third_level_child) { create(:comment, parent_id: second_level_child.id, commentable: article, user_id: user.id, hidden_by_commentable_user: true) }
let(:fourth_level_child) { create(:comment, parent_id: third_level_child.id, commentable: article, user_id: user.id) }
it "does not show the hidden comment in the article's comments section" do
get "#{article.path}/comments"
expect(response.body).not_to include(third_level_child.processed_html)
end
it "does not show the hidden comment's children in the article's comments section" do
fourth_level_child
get "#{article.path}/comments"
expect(response.body).not_to include(fourth_level_child.processed_html)
end
it "does not show the hidden comment in its parent's permalink" do
get second_level_child.path
expect(response.body).not_to include(third_level_child.processed_html)
end
it "does not show the hidden comment's child in its parent's permalink" do
fourth_level_child
get second_level_child.path
expect(response.body).not_to include(fourth_level_child.processed_html)
end
it "shows the comment in the permalink" do
get third_level_child.path
expect(response.body).to include(third_level_child.processed_html)
end
it "shows the fourth level child in the hidden comment's permalink" do
fourth_level_child
get third_level_child.path
expect(response.body).to include(fourth_level_child.processed_html)
end
end
context "when the comment is for a podcast's episode" do
it "works" do
get podcast_comment.path
expect(response).to have_http_status(:ok)
end
end
context "when the article is unpublished" do
before do
new_markdown = article.body_markdown.gsub("published: true", "published: false")
comment
article.update(body_markdown: new_markdown)
end
it "raises a Not Found error" do
expect { get comment.path }.to raise_error("Not Found")
end
end
context "when the article is deleted" do
before do
comment
article.destroy
get comment.path
end
it "renders deleted article comment view" do
expect(response.body).to include("Comment from a deleted article or podcast")
end
end
context "when the podcast is deleted" do
before do
podcast_comment
podcast_episode.destroy
get podcast_comment.path
end
it "renders deleted article comment view" do
expect(response.body).to include("Comment from a deleted article or podcast")
end
end
end
describe "GET /:username/:slug/comments/:id_code/edit" do
context "when not logged-in" do
it "returns unauthorized error" do
expect do
get "/#{user.username}/#{article.slug}/comments/#{comment.id_code_generated}/edit"
end.to raise_error(Pundit::NotAuthorizedError)
end
end
context "when logged-in" do
before do
sign_in user
end
it "returns 200" do
get "/#{user.username}/#{article.slug}/comments/#{comment.id_code_generated}/edit"
expect(response).to have_http_status(:ok)
end
it "returns the comment" do
get "/#{user.username}/#{article.slug}/comments/#{comment.id_code_generated}/edit"
expect(response.body).to include CGI.escapeHTML(comment.body_markdown)
end
end
end
describe "POST /comments/preview" do
it "returns 401 if user is not logged in" do
post "/comments/preview",
params: { comment: { body_markdown: "hi" } },
headers: { HTTP_ACCEPT: "application/json" }
expect(response).to have_http_status(:unauthorized)
end
context "when logged-in" do
before do
sign_in user
post "/comments/preview",
params: { comment: { body_markdown: "hi" } },
headers: { HTTP_ACCEPT: "application/json" }
end
it "returns 200 on good request" do
expect(response).to have_http_status(:ok)
end
it "returns json" do
expect(response.content_type).to eq("application/json")
end
end
end
describe "PATCH /comments/:comment_id/hide" do
include_examples "PATCH /comments/:comment_id/hide or unhide", path: "hide", hidden: "true"
end
describe "PATCH /comments/:comment_id/unhide" do
include_examples "PATCH /comments/:comment_id/hide or unhide", path: "unhide", hidden: "false"
end
end